bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-13 14:53:33 +00:00
Code Issues Releases Wiki Activity

[PM-21441] Defect - Notification bar sometimes gets cut off in fill dev (#14764)

Browse Source 
* PM-21441

* revert default value
This commit is contained in:
Daniel Riera
2025-05-13 16:08:43 -04:00
committed by GitHub
parent bacd1fb999
commit d50db0d0dd
1 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
apps/browser/src/autofill/overlay/notifications/content/overlay-notifications-content.service.ts
View File

@@ -17,7 +17,7 @@ export class OverlayNotificationsContentService
private notificationBarIframeElement: HTMLIFrameElement | null = null; private notificationBarIframeElement: HTMLIFrameElement | null = null;
private currentNotificationBarType: string | null = null; private currentNotificationBarType: string | null = null;
private removeTabFromNotificationQueueTypes = new Set(["add", "change"]); private removeTabFromNotificationQueueTypes = new Set(["add", "change"]);
private notificationRefreshFlag: boolean; private notificationRefreshFlag: boolean = false;
private notificationBarElementStyles: Partial<CSSStyleDeclaration> = { private notificationBarElementStyles: Partial<CSSStyleDeclaration> = {
height: "82px", height: "82px",
width: "430px", width: "430px",
@@ -57,6 +57,7 @@ export class OverlayNotificationsContentService
void sendExtensionMessage("checkNotificationQueue"); void sendExtensionMessage("checkNotificationQueue");
void sendExtensionMessage("notificationRefreshFlagValue").then((notificationRefreshFlag) => { void sendExtensionMessage("notificationRefreshFlagValue").then((notificationRefreshFlag) => {
this.notificationRefreshFlag = !!notificationRefreshFlag; this.notificationRefreshFlag = !!notificationRefreshFlag;
this.setNotificationRefreshBarHeight();
}); });
} }
@@ -223,15 +224,31 @@ export class OverlayNotificationsContentService
this.notificationBarElement.id = "bit-notification-bar"; this.notificationBarElement.id = "bit-notification-bar";
setElementStyles(this.notificationBarElement, this.notificationBarElementStyles, true); setElementStyles(this.notificationBarElement, this.notificationBarElementStyles, true);
this.setNotificationRefreshBarHeight();
if (this.notificationRefreshFlag) {
setElementStyles(this.notificationBarElement, { height: "400px", right: "0" }, true);
}
this.notificationBarElement.appendChild(this.notificationBarIframeElement); this.notificationBarElement.appendChild(this.notificationBarIframeElement);
} }
} }
/**
* Sets the height of the notification bar based on the value of `notificationRefreshFlag`.
* If the flag is `true`, the bar is expanded to 400px and aligned right.
* If the flag is `false`, `null`, or `undefined`, it defaults to height of 82px.
* Skips if the notification bar element has not yet been created.
*
*/
private setNotificationRefreshBarHeight() {
const isNotificationV3 = !!this.notificationRefreshFlag;
if (!this.notificationBarElement) {
return;
}
if (isNotificationV3) {
setElementStyles(this.notificationBarElement, { height: "400px", right: "0" }, true);
}
}
/** /**
* Sets up the message listener for the initialization of the notification bar. * Sets up the message listener for the initialization of the notification bar.
* This will send the initialization data to the notification bar iframe. * This will send the initialization data to the notification bar iframe.