bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 00:33:44 +00:00
Code Issues Releases Wiki Activity

Removed auth status reference from browser-fido2-user-interface service

Browse Source
This commit is contained in:
gbubemismith
2023-09-04 15:35:29 -04:00
parent a655b96bfe
commit d53bd3fe5b
2 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/browser/src/background/main.background.ts
View File

@@ -564,10 +564,7 @@ export default class MainBackground {
this.browserPopoutWindowService = new BrowserPopoutWindowService(); this.browserPopoutWindowService = new BrowserPopoutWindowService();
this.popupUtilsService = new PopupUtilsService(this.isPrivateMode); this.popupUtilsService = new PopupUtilsService(this.isPrivateMode);
this.fido2UserInterfaceService = new BrowserFido2UserInterfaceService( this.fido2UserInterfaceService = new BrowserFido2UserInterfaceService(this.popupUtilsService);
this.popupUtilsService,
this.authService
);
this.fido2AuthenticatorService = new Fido2AuthenticatorService( this.fido2AuthenticatorService = new Fido2AuthenticatorService(
this.cipherService, this.cipherService,
this.fido2UserInterfaceService, this.fido2UserInterfaceService,

7
apps/browser/src/services/fido2/browser-fido2-user-interface.service.ts
View File

@@ -14,7 +14,6 @@ import {
fromEventPattern, fromEventPattern,
} from "rxjs"; } from "rxjs";
import { AuthService } from "@bitwarden/common/auth/abstractions/auth.service";
import { Utils } from "@bitwarden/common/platform/misc/utils"; import { Utils } from "@bitwarden/common/platform/misc/utils";
import { UserRequestedFallbackAbortReason } from "@bitwarden/common/vault/abstractions/fido2/fido2-client.service.abstraction"; import { UserRequestedFallbackAbortReason } from "@bitwarden/common/vault/abstractions/fido2/fido2-client.service.abstraction";
import { import {
@@ -102,7 +101,7 @@ export type BrowserFido2Message = { sessionId: string } & (
); );
export class BrowserFido2UserInterfaceService implements Fido2UserInterfaceServiceAbstraction { export class BrowserFido2UserInterfaceService implements Fido2UserInterfaceServiceAbstraction {
constructor(private popupUtilsService: PopupUtilsService, private authService: AuthService) {} constructor(private popupUtilsService: PopupUtilsService) {}
async newSession( async newSession(
fallbackSupported: boolean, fallbackSupported: boolean,
@@ -110,7 +109,6 @@ export class BrowserFido2UserInterfaceService implements Fido2UserInterfaceServi
): Promise<Fido2UserInterfaceSession> { ): Promise<Fido2UserInterfaceSession> {
return await BrowserFido2UserInterfaceSession.create( return await BrowserFido2UserInterfaceSession.create(
this.popupUtilsService, this.popupUtilsService,
this.authService,
fallbackSupported, fallbackSupported,
abortController abortController
); );
@@ -120,13 +118,11 @@ export class BrowserFido2UserInterfaceService implements Fido2UserInterfaceServi
export class BrowserFido2UserInterfaceSession implements Fido2UserInterfaceSession { export class BrowserFido2UserInterfaceSession implements Fido2UserInterfaceSession {
static async create( static async create(
popupUtilsService: PopupUtilsService, popupUtilsService: PopupUtilsService,
authService: AuthService,
fallbackSupported: boolean, fallbackSupported: boolean,
abortController?: AbortController abortController?: AbortController
): Promise<BrowserFido2UserInterfaceSession> { ): Promise<BrowserFido2UserInterfaceSession> {
return new BrowserFido2UserInterfaceSession( return new BrowserFido2UserInterfaceSession(
popupUtilsService, popupUtilsService,
authService,
fallbackSupported, fallbackSupported,
abortController abortController
); );
@@ -148,7 +144,6 @@ export class BrowserFido2UserInterfaceSession implements Fido2UserInterfaceSessi
private constructor( private constructor(
private readonly popupUtilsService: PopupUtilsService, private readonly popupUtilsService: PopupUtilsService,
private readonly authService: AuthService,
private readonly fallbackSupported: boolean, private readonly fallbackSupported: boolean,
readonly abortController = new AbortController(), readonly abortController = new AbortController(),
readonly sessionId = Utils.newGuid() readonly sessionId = Utils.newGuid()