1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 13:53:34 +00:00

resolve the button name (#17094)

This commit is contained in:
cyprain-okeke
2025-10-29 16:02:59 +01:00
committed by GitHub
parent b1738cc6b2
commit d567530e15
5 changed files with 7 additions and 4 deletions

View File

@@ -38,7 +38,7 @@
<billing-pricing-card <billing-pricing-card
[tagline]="'planDescFamiliesV2' | i18n" [tagline]="'planDescFamiliesV2' | i18n"
[price]="{ amount: familiesData.price, cadence: 'monthly' }" [price]="{ amount: familiesData.price, cadence: 'monthly' }"
[button]="{ type: 'secondary', text: ('upgradeToFamilies' | i18n) }" [button]="{ type: 'secondary', text: ('startFreeFamiliesTrial' | i18n) }"
[features]="familiesData.features" [features]="familiesData.features"
(buttonClick)="openUpgradeDialog('Families')" (buttonClick)="openUpgradeDialog('Families')"
> >

View File

@@ -98,7 +98,7 @@ describe("UpgradeAccountComponent", () => {
expect(sut["familiesCardDetails"].price.amount).toBe(40 / 12); expect(sut["familiesCardDetails"].price.amount).toBe(40 / 12);
expect(sut["familiesCardDetails"].price.cadence).toBe("monthly"); expect(sut["familiesCardDetails"].price.cadence).toBe("monthly");
expect(sut["familiesCardDetails"].button.type).toBe("secondary"); expect(sut["familiesCardDetails"].button.type).toBe("secondary");
expect(sut["familiesCardDetails"].button.text).toBe("upgradeToFamilies"); expect(sut["familiesCardDetails"].button.text).toBe("startFreeFamiliesTrial");
expect(sut["familiesCardDetails"].features).toEqual(["Feature A", "Feature B", "Feature C"]); expect(sut["familiesCardDetails"].features).toEqual(["Feature A", "Feature B", "Feature C"]);
}); });

View File

@@ -119,7 +119,7 @@ export class UpgradeAccountComponent implements OnInit {
}, },
button: { button: {
text: this.i18nService.t( text: this.i18nService.t(
this.isFamiliesPlan(tier.id) ? "upgradeToFamilies" : "upgradeToPremium", this.isFamiliesPlan(tier.id) ? "startFreeFamiliesTrial" : "upgradeToPremium",
), ),
type: buttonType, type: buttonType,
}, },

View File

@@ -161,7 +161,7 @@ export class UpgradePaymentComponent implements OnInit, AfterViewInit {
}; };
this.upgradeToMessage = this.i18nService.t( this.upgradeToMessage = this.i18nService.t(
this.isFamiliesPlan ? "upgradeToFamilies" : "upgradeToPremium", this.isFamiliesPlan ? "startFreeFamiliesTrial" : "upgradeToPremium",
); );
} else { } else {
this.complete.emit({ status: UpgradePaymentStatus.Closed, organizationId: null }); this.complete.emit({ status: UpgradePaymentStatus.Closed, organizationId: null });

View File

@@ -11975,5 +11975,8 @@
}, },
"cardNumberLabel": { "cardNumberLabel": {
"message": "Card number" "message": "Card number"
},
"startFreeFamiliesTrial": {
"message": "Start free Families trial"
} }
} }