bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-18 17:23:37 +00:00
Code Issues Releases Wiki Activity

[PM-10375] Remove Identity Margin (#10349)

Browse Source 
* remove margin from the last form field across identity sections

* remove bottom margin from the item name when it is the only field

* replace JS margin solution with CSS
This commit is contained in:
Nick Krantz
2024-08-01 10:48:09 -05:00
committed by GitHub
parent 0d76835cd8
commit d6f57149d9
3 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/vault/src/cipher-view/custom-fields/custom-fields-v2.component.html
View File

@@ -4,7 +4,7 @@
</bit-section-header> </bit-section-header>
<bit-card> <bit-card>
<div <div
class="tw-border-secondary-300" class="tw-border-secondary-300 [&_bit-form-field:last-of-type]:tw-mb-0"
*ngFor="let field of fields; let last = last" *ngFor="let field of fields; let last = last"
[ngClass]="{ 'tw-mb-4': !last }" [ngClass]="{ 'tw-mb-4': !last }"
> >

6
libs/vault/src/cipher-view/item-details/item-details-v2.component.html
View File

@@ -3,7 +3,9 @@
<h2 bitTypography="h6">{{ "itemDetails" | i18n }}</h2> <h2 bitTypography="h6">{{ "itemDetails" | i18n }}</h2>
</bit-section-header> </bit-section-header>
<bit-card> <bit-card>
<bit-form-field> <bit-form-field
[disableMargin]="!cipher.collectionIds?.length && !cipher.organizationId && !cipher.folderId"
>
<bit-label> <bit-label>
{{ "itemName" | i18n }} {{ "itemName" | i18n }}
</bit-label> </bit-label>
@@ -19,7 +21,7 @@
<ul <ul
[attr.aria-label]="'itemLocation' | i18n" [attr.aria-label]="'itemLocation' | i18n"
*ngIf="cipher.collectionIds || cipher.organizationId || cipher.folderId" *ngIf="cipher.collectionIds?.length || cipher.organizationId || cipher.folderId"
> >
<li <li
*ngIf="cipher.organizationId && organization" *ngIf="cipher.organizationId && organization"

6
libs/vault/src/cipher-view/view-identity-sections/view-identity-sections.component.html
View File

@@ -3,7 +3,7 @@
<h2 bitTypography="h6">{{ "personalDetails" | i18n }}</h2> <h2 bitTypography="h6">{{ "personalDetails" | i18n }}</h2>
</bit-section-header> </bit-section-header>
<bit-card> <bit-card class="[&_bit-form-field:last-of-type]:tw-mb-0">
<bit-form-field *ngIf="cipher.identity.fullName"> <bit-form-field *ngIf="cipher.identity.fullName">
<bit-label>{{ "name" | i18n }}</bit-label> <bit-label>{{ "name" | i18n }}</bit-label>
<input bitInput [value]="cipher.identity.fullName" readonly data-testid="name" /> <input bitInput [value]="cipher.identity.fullName" readonly data-testid="name" />
@@ -48,7 +48,7 @@
<h2 bitTypography="h6">{{ "identification" | i18n }}</h2> <h2 bitTypography="h6">{{ "identification" | i18n }}</h2>
</bit-section-header> </bit-section-header>
<bit-card> <bit-card class="[&_bit-form-field:last-of-type]:tw-mb-0">
<bit-form-field *ngIf="cipher.identity.ssn"> <bit-form-field *ngIf="cipher.identity.ssn">
<bit-label>{{ "ssn" | i18n }}</bit-label> <bit-label>{{ "ssn" | i18n }}</bit-label>
<input bitInput type="password" [value]="cipher.identity.ssn" readonly data-testid="ssn" /> <input bitInput type="password" [value]="cipher.identity.ssn" readonly data-testid="ssn" />
@@ -113,7 +113,7 @@
<h2 bitTypography="h6">{{ "contactInfo" | i18n }}</h2> <h2 bitTypography="h6">{{ "contactInfo" | i18n }}</h2>
</bit-section-header> </bit-section-header>
<bit-card> <bit-card class="[&_bit-form-field:last-of-type]:tw-mb-0">
<bit-form-field *ngIf="cipher.identity.email"> <bit-form-field *ngIf="cipher.identity.email">
<bit-label>{{ "email" | i18n }}</bit-label> <bit-label>{{ "email" | i18n }}</bit-label>
<input bitInput [value]="cipher.identity.email" readonly data-testid="email" /> <input bitInput [value]="cipher.identity.email" readonly data-testid="email" />