From d9d4b251a817dad98e89bacb198c5af4213a7358 Mon Sep 17 00:00:00 2001 From: Jimmy Vo Date: Thu, 12 Dec 2024 11:44:47 -0500 Subject: [PATCH] Addressing code review 3 --- .../member-dialog/member-dialog.component.ts | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.ts b/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.ts index eac4bdbe0f3..51a35baa7c3 100644 --- a/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.ts +++ b/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.ts @@ -273,9 +273,12 @@ export class MemberDialogComponent implements OnDestroy { } private setFormValidators(organization: Organization) { - const _orgSeatLimitReachedValidator = [ + const emailsControlValidators = [ Validators.required, commaSeparatedEmails, + inputEmailLimitValidator(organization, (maxEmailsCount: number) => + this.i18nService.t("tooManyEmails", maxEmailsCount), + ), orgSeatLimitReachedValidator( organization, this.params.allOrganizationUserEmails, @@ -283,17 +286,8 @@ export class MemberDialogComponent implements OnDestroy { ), ]; - const _inputEmailLimitValidator = [ - Validators.required, - commaSeparatedEmails, - inputEmailLimitValidator(organization, (maxEmailsCount: number) => - this.i18nService.t("tooManyEmails", maxEmailsCount), - ), - ]; - const emailsControl = this.formGroup.get("emails"); - emailsControl.setValidators(_orgSeatLimitReachedValidator); - emailsControl.setValidators(_inputEmailLimitValidator); + emailsControl.setValidators(emailsControlValidators); emailsControl.updateValueAndValidity(); }