1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 08:13:42 +00:00

Add type=button to stories (#12930)

This commit is contained in:
Oscar Hinton
2025-01-17 14:57:31 +01:00
committed by GitHub
parent 2726b3a957
commit dafeb1492a
9 changed files with 46 additions and 22 deletions

View File

@@ -15,8 +15,8 @@ import { KitchenSinkToggleList } from "./kitchen-sink-toggle-list.component";
<bit-dialog title="Dialog Title" dialogSize="large">
<span bitDialogContent> Dialog body text goes here. </span>
<ng-container bitDialogFooter>
<button bitButton buttonType="primary" (click)="dialogRef.close()">OK</button>
<button bitButton buttonType="secondary" bitDialogClose>Cancel</button>
<button type="button" bitButton buttonType="primary" (click)="dialogRef.close()">OK</button>
<button type="button" bitButton buttonType="secondary" bitDialogClose>Cancel</button>
</ng-container>
</bit-dialog>
`,
@@ -42,7 +42,7 @@ class KitchenSinkDialog {
</bit-breadcrumbs>
</p>
<div class="tw-mb-6 tw-mt-6">
<div class="tw-my-6">
<h1 bitTypography="h1">Bitwarden Kitchen Sink<bit-avatar text="Bit Warden"></bit-avatar></h1>
<a bitLink linkType="primary" href="#">Learn more</a>
</div>
@@ -68,8 +68,8 @@ class KitchenSinkDialog {
<h2 bitTypography="h2" class="tw-mb-6">About</h2>
<bit-kitchen-sink-table></bit-kitchen-sink-table>
<button bitButton (click)="openDialog()">Open Dialog</button>
<button bitButton (click)="openDrawer()">Open Drawer</button>
<button type="button" bitButton (click)="openDialog()">Open Dialog</button>
<button type="button" bitButton (click)="openDrawer()">Open Drawer</button>
</bit-section>
<bit-section>
<h2 bitTypography="h2" class="tw-mb-6">Companies using Bitwarden</h2>

View File

@@ -20,7 +20,11 @@ import { KitchenSinkSharedModule } from "../kitchen-sink-shared.module";
<td bitCell>Password Manager</td>
<td bitCell>Everyone</td>
<td bitCell>
<button bitIconButton="bwi-ellipsis-v" [bitMenuTriggerFor]="menu1"></button>
<button
type="button"
bitIconButton="bwi-ellipsis-v"
[bitMenuTriggerFor]="menu1"
></button>
<bit-menu #menu1>
<a href="#" bitMenuItem>Anchor link</a>
<a href="#" bitMenuItem>Another link</a>
@@ -33,7 +37,11 @@ import { KitchenSinkSharedModule } from "../kitchen-sink-shared.module";
<td bitCell>Secrets Manager</td>
<td bitCell>Developers</td>
<td bitCell>
<button bitIconButton="bwi-ellipsis-v" [bitMenuTriggerFor]="menu2"></button>
<button
type="button"
bitIconButton="bwi-ellipsis-v"
[bitMenuTriggerFor]="menu2"
></button>
<bit-menu #menu2>
<a href="#" bitMenuItem>Anchor link</a>
<a href="#" bitMenuItem>Another link</a>

View File

@@ -7,7 +7,7 @@ import { KitchenSinkSharedModule } from "../kitchen-sink-shared.module";
selector: "bit-kitchen-sink-toggle-list",
imports: [KitchenSinkSharedModule],
template: `
<div class="tw-mt-6 tw-mb-6">
<div class="tw-my-6">
<bit-toggle-group [(selected)]="selectedToggle" aria-label="Company list filter">
<bit-toggle value="all"> All <span bitBadge variant="info">3</span> </bit-toggle>