From db19d6e2261ef052729370b22bd5ba3bf27a4184 Mon Sep 17 00:00:00 2001
From: Jordan Aasen <166539328+jaasen-livefront@users.noreply.github.com>
Date: Wed, 29 Jan 2025 14:06:03 -0800
Subject: [PATCH] [PM-17688] - generator dialog - add missing button label i18n
 keys. fix logic for disabling button (#13140)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* add missing button label i18n keys. fix logic for displaying button label

* Update comment

Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>

---------

Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
---
 apps/browser/src/_locales/en/messages.json             |  3 +++
 apps/desktop/src/locales/en/messages.json              |  3 +++
 .../vault/credential-generator-dialog.component.html   |  3 ++-
 .../app/vault/credential-generator-dialog.component.ts | 10 ++++++++--
 apps/web/src/locales/en/messages.json                  |  3 +++
 .../cipher-form-generator.component.html               |  4 ++--
 .../cipher-form-generator.component.ts                 |  2 +-
 7 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/apps/browser/src/_locales/en/messages.json b/apps/browser/src/_locales/en/messages.json
index 666dea3f5b8..91178757430 100644
--- a/apps/browser/src/_locales/en/messages.json
+++ b/apps/browser/src/_locales/en/messages.json
@@ -2064,6 +2064,9 @@
   "usernameGenerator": {
     "message": "Username generator"
   },
+  "useThisEmail": {
+    "message": "Use this email"
+  },
   "useThisPassword": {
     "message": "Use this password"
   },
diff --git a/apps/desktop/src/locales/en/messages.json b/apps/desktop/src/locales/en/messages.json
index 4f18a88d994..3577c295c6f 100644
--- a/apps/desktop/src/locales/en/messages.json
+++ b/apps/desktop/src/locales/en/messages.json
@@ -2553,6 +2553,9 @@
   "catchallEmailDesc": {
     "message": "Use your domain's configured catch-all inbox."
   },
+  "useThisEmail": {
+    "message": "Use this email"
+  },
   "random": {
     "message": "Random"
   },
diff --git a/apps/desktop/src/vault/app/vault/credential-generator-dialog.component.html b/apps/desktop/src/vault/app/vault/credential-generator-dialog.component.html
index 713118aeace..84e64956ca5 100644
--- a/apps/desktop/src/vault/app/vault/credential-generator-dialog.component.html
+++ b/apps/desktop/src/vault/app/vault/credential-generator-dialog.component.html
@@ -4,7 +4,7 @@
     <vault-cipher-form-generator
       [type]="data.type"
       (valueGenerated)="onCredentialGenerated($event)"
-      [algorithm]="algorithm"
+      [onAlgorithmSelected]="onAlgorithmSelected"
     />
     <bit-item>
       <button
@@ -28,6 +28,7 @@
       appA11yTitle="{{ buttonLabel }}"
       bitButton
       bitDialogClose
+      [disabled]="!(buttonLabel && credentialValue)"
     >
       {{ buttonLabel }}
     </button>
diff --git a/apps/desktop/src/vault/app/vault/credential-generator-dialog.component.ts b/apps/desktop/src/vault/app/vault/credential-generator-dialog.component.ts
index ae6f031005e..6ffac5ce4fb 100644
--- a/apps/desktop/src/vault/app/vault/credential-generator-dialog.component.ts
+++ b/apps/desktop/src/vault/app/vault/credential-generator-dialog.component.ts
@@ -46,8 +46,14 @@ export class CredentialGeneratorDialogComponent {
     private dialogService: DialogService,
   ) {}
 
-  algorithm = (selected: AlgorithmInfo) => {
-    this.buttonLabel = selected.useGeneratedValue;
+  onAlgorithmSelected = (selected?: AlgorithmInfo) => {
+    if (selected) {
+      this.buttonLabel = selected.useGeneratedValue;
+    } else {
+      // clear the credential value when the user is
+      // selecting the credential generation algorithm
+      this.credentialValue = undefined;
+    }
   };
 
   applyCredentials = () => {
diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json
index 9e5b25a4abf..a5a7df3c4d8 100644
--- a/apps/web/src/locales/en/messages.json
+++ b/apps/web/src/locales/en/messages.json
@@ -6752,6 +6752,9 @@
   "catchallEmailDesc": {
     "message": "Use your domain's configured catch-all inbox."
   },
+  "useThisEmail": {
+    "message": "Use this email"
+  },
   "random": {
     "message": "Random",
     "description": "Generates domain-based username using random letters"
diff --git a/libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.html b/libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.html
index 16bccebb939..a73cc31652c 100644
--- a/libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.html
+++ b/libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.html
@@ -2,11 +2,11 @@
   *ngIf="type === 'password'"
   [disableMargin]="disableMargin"
   (onGenerated)="onCredentialGenerated($event)"
-  (onAlgorithm)="algorithm($event)"
+  (onAlgorithm)="onAlgorithmSelected($event)"
 ></tools-password-generator>
 <tools-username-generator
   *ngIf="type === 'username'"
   [disableMargin]="disableMargin"
   (onGenerated)="onCredentialGenerated($event)"
-  (onAlgorithm)="algorithm($event)"
+  (onAlgorithm)="onAlgorithmSelected($event)"
 ></tools-username-generator>
diff --git a/libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.ts b/libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.ts
index fdde5e15d91..ff705b2d1ba 100644
--- a/libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.ts
+++ b/libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.ts
@@ -19,7 +19,7 @@ import { AlgorithmInfo, GeneratedCredential } from "@bitwarden/generator-core";
 })
 export class CipherFormGeneratorComponent {
   @Input()
-  algorithm: (selected: AlgorithmInfo) => void;
+  onAlgorithmSelected: (selected: AlgorithmInfo) => void;
 
   /**
    * The type of generator form to show.