From dced4735c9e0dd54cd019afaeb227186cdf8c518 Mon Sep 17 00:00:00 2001 From: Maciej Zieniuk Date: Mon, 4 Nov 2024 21:42:35 +0000 Subject: [PATCH] PM-14445: Fix Browser strict mode --- apps/browser/package.json | 2 +- apps/browser/src/key-management/tsconfig.json | 12 ------------ apps/browser/tsconfig.json | 9 ++++++++- 3 files changed, 9 insertions(+), 14 deletions(-) delete mode 100644 apps/browser/src/key-management/tsconfig.json diff --git a/apps/browser/package.json b/apps/browser/package.json index 6c41f6267cc..31b316eec84 100644 --- a/apps/browser/package.json +++ b/apps/browser/package.json @@ -12,7 +12,7 @@ "build:prod": "cross-env NODE_ENV=production NODE_OPTIONS=\"--max-old-space-size=4096\" webpack", "build:prod:beta": "cross-env BETA_BUILD=1 NODE_ENV=production webpack", "build:prod:watch": "cross-env NODE_ENV=production webpack --watch", - "dist": "npm run build:prod && gulp dist", + "dist": "tsc-strict && npm run build:prod && gulp dist", "dist:beta": "npm run build:prod:beta && cross-env BETA_BUILD=1 gulp dist", "dist:mv3": "cross-env MANIFEST_VERSION=3 npm run build:prod && cross-env MANIFEST_VERSION=3 gulp dist", "dist:mv3:beta": "cross-env MANIFEST_VERSION=3 npm run build:prod:beta && cross-env MANIFEST_VERSION=3 BETA_BUILD=1 gulp dist", diff --git a/apps/browser/src/key-management/tsconfig.json b/apps/browser/src/key-management/tsconfig.json deleted file mode 100644 index 9d0e7445536..00000000000 --- a/apps/browser/src/key-management/tsconfig.json +++ /dev/null @@ -1,12 +0,0 @@ -{ - "extends": "../../tsconfig.json", - "compilerOptions": { - "plugins": [ - { - "name": "typescript-strict-plugin", - "paths": ["./"], - "excludePattern": ["**/*.spec.ts"] - } - ] - } -} diff --git a/apps/browser/tsconfig.json b/apps/browser/tsconfig.json index e27d80e595a..3b432f36b6a 100644 --- a/apps/browser/tsconfig.json +++ b/apps/browser/tsconfig.json @@ -36,7 +36,14 @@ "@bitwarden/key-management": ["../../libs/key-management/src"], "@bitwarden/vault": ["../../libs/vault/src"] }, - "useDefineForClassFields": false + "useDefineForClassFields": false, + "plugins": [ + { + "name": "typescript-strict-plugin", + "paths": ["./src/key-management"], + "excludePattern": ["**/*.spec.ts"] + } + ] }, "angularCompilerOptions": { "strictTemplates": true,