1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-23 03:33:54 +00:00

refactor(sso-config-tweaks): [Auth/PM-933] Tweaks to SSO Config Page (#16374)

Makes some tweaks to the SSO config page:
- SSO Identifier: update hint text
- Single Sign-On Service URL: make required, remove hint text
- Client Secret: make hidden by default (add view/hide toggle)
This commit is contained in:
rr-bw
2025-10-01 08:54:33 -07:00
committed by GitHub
parent 7b94d6ab2b
commit de3759fa85
3 changed files with 20 additions and 8 deletions

View File

@@ -30,8 +30,8 @@
<bit-label>{{ "ssoIdentifier" | i18n }}</bit-label>
<input bitInput type="text" formControlName="ssoIdentifier" />
<bit-hint>
{{ "ssoIdentifierHintPartOne" | i18n }}
<a bitLink routerLink="../domain-verification">{{ "claimedDomains" | i18n }}</a>
{{ "ssoIdentifierHint" | i18n }}
<a bitLink routerLink="../domain-verification">{{ "claimedDomainsLearnMore" | i18n }}</a>
</bit-hint>
</bit-form-field>
@@ -209,7 +209,14 @@
<bit-form-field>
<bit-label>{{ "clientSecret" | i18n }}</bit-label>
<input bitInput type="text" formControlName="clientSecret" appInputStripSpaces />
<input bitInput type="password" formControlName="clientSecret" appInputStripSpaces />
<button
type="button"
bitIconButton
bitSuffix
bitPasswordInputToggle
[(toggled)]="showClientSecret"
></button>
</bit-form-field>
<bit-form-field>
@@ -488,7 +495,6 @@
formControlName="idpSingleSignOnServiceUrl"
appInputStripSpaces
/>
<bit-hint>{{ "idpSingleSignOnServiceUrlRequired" | i18n }}</bit-hint>
</bit-form-field>
<bit-form-field>

View File

@@ -121,6 +121,8 @@ export class SsoComponent implements OnInit, OnDestroy {
spMetadataUrl: string;
spAcsUrl: string;
showClientSecret = false;
protected openIdForm = this.formBuilder.group<ControlsOf<SsoConfigView["openId"]>>(
{
authority: new FormControl("", Validators.required),
@@ -156,7 +158,7 @@ export class SsoComponent implements OnInit, OnDestroy {
idpEntityId: new FormControl("", Validators.required),
idpBindingType: new FormControl(Saml2BindingType.HttpRedirect),
idpSingleSignOnServiceUrl: new FormControl(),
idpSingleSignOnServiceUrl: new FormControl("", Validators.required),
idpSingleLogoutServiceUrl: new FormControl(),
idpX509PublicCert: new FormControl("", Validators.required),
idpOutboundSigningAlgorithm: new FormControl(defaultSigningAlgorithm),