From def877dd427bdcd8a056cb50cd824a2bbb167811 Mon Sep 17 00:00:00 2001 From: Miles Blackwood Date: Thu, 5 Jun 2025 12:05:26 -0400 Subject: [PATCH] Final generic => basic. --- .../background/abstractions/notification.background.ts | 4 ++-- .../src/autofill/background/notification.background.ts | 4 ++-- .../notification/refactor/basic-notification.lit-stories.ts | 2 +- .../autofill/enums/notification-queue-message-type.enum.ts | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/browser/src/autofill/background/abstractions/notification.background.ts b/apps/browser/src/autofill/background/abstractions/notification.background.ts index dc28904e108..6a8b898ad38 100644 --- a/apps/browser/src/autofill/background/abstractions/notification.background.ts +++ b/apps/browser/src/autofill/background/abstractions/notification.background.ts @@ -13,7 +13,7 @@ const StandardNotificationType = { ChangePassword: "change", UnlockVault: "unlock", AtRiskPassword: "at-risk-password", - Generic: "generic", + Basic: "basic", } as const; type StandardNotificationTypes = @@ -66,7 +66,7 @@ export type BasicNotificationData = { }; export type BasicNotificationQueueMessage = TempNotificationQueueMessage< - typeof StandardNotificationType.Generic, + typeof StandardNotificationType.Basic, BasicNotificationData >; diff --git a/apps/browser/src/autofill/background/notification.background.ts b/apps/browser/src/autofill/background/notification.background.ts index efed6c43a5b..0d921666d71 100644 --- a/apps/browser/src/autofill/background/notification.background.ts +++ b/apps/browser/src/autofill/background/notification.background.ts @@ -394,7 +394,7 @@ export default class NotificationBackground { } /** - * Open the generic notification + * Open the basic notification * * @param message NotificationBackgroundExtensionMessage * @param sender chrome.runtime.MessageSender @@ -410,7 +410,7 @@ export default class NotificationBackground { const queueMessage: BasicNotificationQueueMessage = { domain: Utils.getDomain(sender.tab.url), - type: StandardNotificationType.Generic, + type: StandardNotificationType.Basic, tab: sender.tab, launchTimestamp, wasVaultLocked, diff --git a/apps/browser/src/autofill/content/components/lit-stories/notification/refactor/basic-notification.lit-stories.ts b/apps/browser/src/autofill/content/components/lit-stories/notification/refactor/basic-notification.lit-stories.ts index d7f2e285667..89fe1746a72 100644 --- a/apps/browser/src/autofill/content/components/lit-stories/notification/refactor/basic-notification.lit-stories.ts +++ b/apps/browser/src/autofill/content/components/lit-stories/notification/refactor/basic-notification.lit-stories.ts @@ -21,7 +21,7 @@ export default { theme: { control: "select", options: [...Object.values(ThemeTypes)] }, }, args: { - title: "Generic Alert", + title: "Basic Notification", message: "Notifications are happening, more or less constantly.", footer: ExampleComponent({ message: "Plain" }), theme: ThemeTypes.Light, diff --git a/apps/browser/src/autofill/enums/notification-queue-message-type.enum.ts b/apps/browser/src/autofill/enums/notification-queue-message-type.enum.ts index 89c6ed987e3..00d8c3b2b8d 100644 --- a/apps/browser/src/autofill/enums/notification-queue-message-type.enum.ts +++ b/apps/browser/src/autofill/enums/notification-queue-message-type.enum.ts @@ -3,7 +3,7 @@ const NotificationQueueMessageType = { ChangePassword: "change", UnlockVault: "unlock", AtRiskPassword: "at-risk-password", - Generic: "generic", + Basic: "basic", } as const; type NotificationQueueMessageTypes =