From e184d44eca14f795a08368f9742bfe8c9022858c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Anders=20=C3=85berg?= Date: Tue, 14 Oct 2025 15:48:38 -0700 Subject: [PATCH] clean up unwrap() --- apps/desktop/desktop_native/macos_provider/src/lib.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/apps/desktop/desktop_native/macos_provider/src/lib.rs b/apps/desktop/desktop_native/macos_provider/src/lib.rs index 285022395d4..bae74a1d6fa 100644 --- a/apps/desktop/desktop_native/macos_provider/src/lib.rs +++ b/apps/desktop/desktop_native/macos_provider/src/lib.rs @@ -224,7 +224,6 @@ enum SerializedMessage { } impl MacOSProviderClient { - // FIXME: Remove unwraps! They panic and terminate the whole application. #[allow(clippy::unwrap_used)] fn add_callback(&self, callback: Box) -> u32 { let sequence_number = self @@ -233,13 +232,12 @@ impl MacOSProviderClient { self.response_callbacks_queue .lock() - .unwrap() + .expect("response callbacks queue mutex should not be poisoned") .insert(sequence_number, (callback, Instant::now())); sequence_number } - // FIXME: Remove unwraps! They panic and terminate the whole application. #[allow(clippy::unwrap_used)] fn send_message( &self, @@ -264,7 +262,7 @@ impl MacOSProviderClient { if let Some((callback, _)) = self .response_callbacks_queue .lock() - .unwrap() + .expect("response callbacks queue mutex should not be poisoned") .remove(&sequence_number) { callback.error(BitwardenError::Internal(format!(