bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 05:13:29 +00:00
Code Issues Releases Wiki Activity

[PM-22417] Enable autofill overlay for siteone.com (#16457)

Browse Source 
* [PM-22417] Enable autofill overlay for siteone.com

* Fix broken test

* Remove the magic number
This commit is contained in:
Jeffrey Holland
2025-09-23 15:38:53 +02:00
committed by GitHub
parent 18594ade72
commit e18f3cf8c9
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts
View File

@@ -578,7 +578,7 @@ describe("CollectAutofillContentService", () => {
const autofillFieldsData = await Promise.resolve(autofillFieldsPromise); const autofillFieldsData = await Promise.resolve(autofillFieldsPromise);
expect(collectAutofillContentService["getAutofillFieldElements"]).toHaveBeenCalledWith( expect(collectAutofillContentService["getAutofillFieldElements"]).toHaveBeenCalledWith(
100, 200,
formFieldElements, formFieldElements,
); );
expect(collectAutofillContentService["buildAutofillFieldItem"]).toHaveBeenCalledTimes(2); expect(collectAutofillContentService["buildAutofillFieldItem"]).toHaveBeenCalledTimes(2);

7
apps/browser/src/autofill/services/collect-autofill-content.service.ts
View File

@@ -278,7 +278,12 @@ export class CollectAutofillContentService implements CollectAutofillContentServ
private async buildAutofillFieldsData( private async buildAutofillFieldsData(
formFieldElements: FormFieldElement[], formFieldElements: FormFieldElement[],
): Promise<AutofillField[]> { ): Promise<AutofillField[]> {
const autofillFieldElements = this.getAutofillFieldElements(100, formFieldElements); // Maximum number of form fields to process for autofill to prevent performance issues on pages with excessive fields
const autofillFieldsLimit = 200;
const autofillFieldElements = this.getAutofillFieldElements(
autofillFieldsLimit,
formFieldElements,
);
const autofillFieldDataPromises = autofillFieldElements.map(this.buildAutofillFieldItem); const autofillFieldDataPromises = autofillFieldElements.map(this.buildAutofillFieldItem);
return Promise.all(autofillFieldDataPromises); return Promise.all(autofillFieldDataPromises);