bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 22:33:35 +00:00
Code Issues Releases Wiki Activity

[PM-11941] Migrate TOTP Generator to use SDK (#12987)

Browse Source 
* Refactored totp service to use sdk

Fixed strict typescript issues

* Fixed dependency issues

* Returned object that contains code and period, removed get interval function

* removed dependencies

* Updated to use refactored totp service

* removed sdk service undefined check

* removed undefined as an input from the getCode function

* Made getcode$ an observable

* refactored to use getcodee$

* Filter out emmissions

* updated sdk version

* Fixed readability nit

* log error on overlay if totp response does not return a code

* fix(totpGeneration): [PM-11941] Totp countdown not working on clients

* Used optional chaining if totpresponse returns null or undefined
This commit is contained in:
SmithThe4th
2025-03-06 14:01:07 -05:00
committed by GitHub
parent 1415041fd7
commit e327816bc4
24 changed files with 345 additions and 443 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/cli/src/commands/get.command.ts
View File

@@ -254,8 +254,8 @@ export class GetCommand extends DownloadCommand {
return Response.error("No TOTP available for this login.");
}
const totp = await this.totpService.getCode(cipher.login.totp);
if (totp == null) {
const totpResponse = await firstValueFrom(this.totpService.getCode$(cipher.login.totp));
if (!totpResponse.code) {
return Response.error("Couldn't generate TOTP code.");
}
@@ -276,7 +276,7 @@ export class GetCommand extends DownloadCommand {
}
}
const res = new StringResponse(totp);
const res = new StringResponse(totpResponse.code);
return Response.success(res);
}