1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00

Billing - Prefer signal & change detection (#16944)

This commit is contained in:
Oscar Hinton
2025-10-23 22:02:01 +02:00
committed by GitHub
parent a592f2b866
commit e3f943364f
83 changed files with 429 additions and 9 deletions

View File

@@ -25,6 +25,8 @@ export enum AddExistingOrganizationDialogResultType {
Submitted = "submitted",
}
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "./add-existing-organization-dialog.component.html",
standalone: false,

View File

@@ -100,6 +100,8 @@ export class PlanCard {
}
}
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "./create-client-dialog.component.html",
standalone: false,

View File

@@ -39,6 +39,8 @@ export const openManageClientNameDialog = (
dialogConfig,
);
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "manage-client-name-dialog.component.html",
standalone: false,

View File

@@ -35,6 +35,8 @@ export const openManageClientSubscriptionDialog = (
ManageClientSubscriptionDialogParams
>(ManageClientSubscriptionDialogComponent, dialogConfig);
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "./manage-client-subscription-dialog.component.html",
standalone: false,

View File

@@ -57,6 +57,8 @@ import {
import { NoClientsComponent } from "./no-clients.component";
import { ReplacePipe } from "./replace.pipe";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "manage-clients.component.html",
imports: [

View File

@@ -4,6 +4,8 @@ import { GearIcon } from "@bitwarden/assets/svg";
import { NoItemsModule } from "@bitwarden/components";
import { SharedOrganizationModule } from "@bitwarden/web-vault/app/admin-console/organizations/shared";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-no-clients",
imports: [SharedOrganizationModule, NoItemsModule],
@@ -27,8 +29,14 @@ import { SharedOrganizationModule } from "@bitwarden/web-vault/app/admin-console
})
export class NoClientsComponent {
icon = GearIcon;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() showAddOrganizationButton = true;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() disableAddOrganizationButton = false;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-output-emitter-ref
@Output() addNewOrganizationClicked = new EventEmitter();
addNewOrganization = () => this.addNewOrganizationClicked.emit();

View File

@@ -14,6 +14,8 @@ export class FreeFamiliesSponsorshipPolicy extends BasePolicyEditDefinition {
component = FreeFamiliesSponsorshipPolicyComponent;
}
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "free-families-sponsorship.component.html",
imports: [SharedModule],

View File

@@ -8,15 +8,25 @@ import {
} from "@bitwarden/common/billing/models/response/invoices.response";
import { FileDownloadService } from "@bitwarden/common/platform/abstractions/file-download/file-download.service";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-invoices",
templateUrl: "./invoices.component.html",
standalone: false,
})
export class InvoicesComponent implements OnInit {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() startWith?: InvoicesResponse;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() getInvoices?: () => Promise<InvoicesResponse>;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() getClientInvoiceReport?: (invoiceId: string) => Promise<string>;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() getClientInvoiceReportName?: (invoiceResponse: InvoiceResponse) => string;
protected invoices: InvoiceResponse[] = [];

View File

@@ -2,6 +2,8 @@ import { Component } from "@angular/core";
import { CreditCardIcon } from "@bitwarden/assets/svg";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-no-invoices",
template: `<bit-no-items [icon]="icon">

View File

@@ -10,6 +10,8 @@ import { BillingApiServiceAbstraction } from "@bitwarden/common/billing/abstract
import { InvoiceResponse } from "@bitwarden/common/billing/models/response/invoices.response";
import { BillingNotificationService } from "@bitwarden/web-vault/app/billing/services/billing-notification.service";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "./provider-billing-history.component.html",
standalone: false,

View File

@@ -59,6 +59,8 @@ const BANK_ACCOUNT_VERIFIED_COMMAND = new CommandDefinition<{
adminId: string;
}>("providerBankAccountVerified");
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "./provider-payment-details.component.html",
imports: [

View File

@@ -17,6 +17,8 @@ import { KeyService } from "@bitwarden/key-management";
import { BillingNotificationService } from "@bitwarden/web-vault/app/billing/services/billing-notification.service";
import { BaseAcceptComponent } from "@bitwarden/web-vault/app/common/base.accept.component";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
templateUrl: "./setup-business-unit.component.html",
standalone: false,

View File

@@ -23,12 +23,16 @@ type ComponentData = {
};
};
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-provider-subscription-status",
templateUrl: "provider-subscription-status.component.html",
standalone: false,
})
export class ProviderSubscriptionStatusComponent {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input({ required: true }) subscription: ProviderSubscriptionResponse;
constructor(

View File

@@ -11,6 +11,8 @@ import {
} from "@bitwarden/common/billing/models/response/provider-subscription-response";
import { BillingNotificationService } from "@bitwarden/web-vault/app/billing/services/billing-notification.service";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-provider-subscription",
templateUrl: "./provider-subscription.component.html",