From e418a623b57e55fc4ad6cb798fbefe13a6281c52 Mon Sep 17 00:00:00 2001 From: rr-bw <102181210+rr-bw@users.noreply.github.com> Date: Tue, 13 Jan 2026 14:22:22 -0800 Subject: [PATCH] [PM-27086] rename flag variable name for clarity --- .../set-initial-password.component.ts | 11 +++++++---- .../input-password/input-password.component.ts | 6 +++--- .../angular/input-password/password-input-result.ts | 2 +- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/libs/angular/src/auth/password-management/set-initial-password/set-initial-password.component.ts b/libs/angular/src/auth/password-management/set-initial-password/set-initial-password.component.ts index 80b6f63c6ec..dfd8029e1b0 100644 --- a/libs/angular/src/auth/password-management/set-initial-password/set-initial-password.component.ts +++ b/libs/angular/src/auth/password-management/set-initial-password/set-initial-password.component.ts @@ -208,11 +208,14 @@ export class SetInitialPasswordComponent implements OnInit { // } // KM flag OFF, Auth flag ON - if (passwordInputResult.newApisFlagEnabled && !passwordInputResult.newMasterKey) { + if ( + passwordInputResult.newApisWithInputPasswordFlagEnabled && + !passwordInputResult.newMasterKey + ) { /** - * If the newApisFlag is enabled, it means the InputPasswordComponent will not emit a - * newMasterKey, newServerMasterKeyHash, and newLocalMasterKeyHash. So we must create - * them here and add them late to the PasswordInputResult before calling setInitialPassword(). + * If the newApisWithInputPasswordFlagEnabled is enabled, it means the InputPasswordComponent + * will not emit a newMasterKey, newServerMasterKeyHash, and newLocalMasterKeyHash. So we must + * create them here and add them late to the PasswordInputResult before calling setInitialPassword(). */ const newMasterKey = await this.keyService.makeMasterKey( diff --git a/libs/auth/src/angular/input-password/input-password.component.ts b/libs/auth/src/angular/input-password/input-password.component.ts index 2247e4bc46e..e6d1688d716 100644 --- a/libs/auth/src/angular/input-password/input-password.component.ts +++ b/libs/auth/src/angular/input-password/input-password.component.ts @@ -364,18 +364,18 @@ export class InputPasswordComponent implements OnInit { return; } - const newApisFlagEnabled = await this.configService.getFeatureFlag( + const newApisWithInputPasswordFlagEnabled = await this.configService.getFeatureFlag( FeatureFlag.PM27086_UpdateAuthenticationApisForInputPassword, ); - if (newApisFlagEnabled) { + if (newApisWithInputPasswordFlagEnabled) { // 4. Build a PasswordInputResult object const passwordInputResult: PasswordInputResult = { newPassword, kdfConfig: this.kdfConfig, salt, newPasswordHint, - newApisFlagEnabled, // To be removed in PM-28143 + newApisWithInputPasswordFlagEnabled, // To be removed in PM-28143 }; if ( diff --git a/libs/auth/src/angular/input-password/password-input-result.ts b/libs/auth/src/angular/input-password/password-input-result.ts index bba56cc278e..9394f1b3aad 100644 --- a/libs/auth/src/angular/input-password/password-input-result.ts +++ b/libs/auth/src/angular/input-password/password-input-result.ts @@ -16,7 +16,7 @@ export interface PasswordInputResult { * * To be removed in PM-28143 */ - newApisFlagEnabled?: boolean; + newApisWithInputPasswordFlagEnabled?: boolean; // The deprecated properties below will be removed in PM-28143: https://bitwarden.atlassian.net/browse/PM-28143