From e5f06adb27c9a3ca5c48f75568c3bd19ca40d5cb Mon Sep 17 00:00:00 2001 From: Cesar Gonzalez Date: Fri, 22 Mar 2024 15:27:14 -0500 Subject: [PATCH] [PM-5189] Resolving issues that exist for when a page element is scrolled --- .../browser/src/autofill/background/overlay.background.ts | 8 +++++++- .../autofill/services/autofill-overlay-content.service.ts | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/apps/browser/src/autofill/background/overlay.background.ts b/apps/browser/src/autofill/background/overlay.background.ts index f8432e33a48..1a0068d6419 100644 --- a/apps/browser/src/autofill/background/overlay.background.ts +++ b/apps/browser/src/autofill/background/overlay.background.ts @@ -600,7 +600,13 @@ class OverlayBackground implements OverlayBackgroundInterface { sender: chrome.runtime.MessageSender, ) { const display = isOverlayHidden ? "none" : "block"; - const styles = setTransparentOverlay ? { display, opacity: 0 } : { display }; + let styles: { display: string; opacity?: number } = { display }; + + if (typeof setTransparentOverlay !== "undefined") { + const opacity = setTransparentOverlay ? 0 : 1; + styles = { ...styles, opacity }; + } + const portMessage = { command: "updateOverlayHidden", styles }; void BrowserApi.tabSendMessage( diff --git a/apps/browser/src/autofill/services/autofill-overlay-content.service.ts b/apps/browser/src/autofill/services/autofill-overlay-content.service.ts index ccc99f029a7..2d96c4d3236 100644 --- a/apps/browser/src/autofill/services/autofill-overlay-content.service.ts +++ b/apps/browser/src/autofill/services/autofill-overlay-content.service.ts @@ -749,7 +749,7 @@ class AutofillOverlayContentService implements AutofillOverlayContentServiceInte if ( this.focusedFieldData.focusedFieldRects?.top > 0 && - this.focusedFieldData.focusedFieldRects?.top < window.innerHeight + this.focusedFieldData.focusedFieldRects?.top < window.innerHeight + window.scrollY ) { return; }