From e64714c8d54d7be75b913a25d35056b4c3911c09 Mon Sep 17 00:00:00 2001
From: Kyle Spearrin <kyle.spearrin@gmail.com>
Date: Thu, 19 Oct 2017 09:58:31 -0400
Subject: [PATCH] open popup when noop item clicked

---
 src/background.js | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/background.js b/src/background.js
index 3c2b9256183..2c8808cde83 100644
--- a/src/background.js
+++ b/src/background.js
@@ -198,15 +198,14 @@ var bg_isBackground = true,
                     bg_passwordGenerationService.addHistory(password);
                 });
             }
-            else if (info.menuItemId === 'autofill_noop') {
-                if (bg_utilsService.isFirefox() && chrome.browserAction.openPopup) {
-                    chrome.browserAction.openPopup();
-                }
-            }
             else if (info.parentMenuItemId === 'autofill' || info.parentMenuItemId === 'copy-username' ||
                 info.parentMenuItemId === 'copy-password') {
                 var id = info.menuItemId.split('_')[1];
                 if (id === 'noop') {
+                    if (chrome.browserAction.openPopup) {
+                        chrome.browserAction.openPopup();
+                    }
+
                     return;
                 }