bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 16:53:34 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Refactoring implementation

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-05-02 17:24:18 -05:00
parent 8ae427c60d
commit e82766c3f5
5 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/browser/src/autofill/background/abstractions/overlay.background.ts
View File

@@ -109,8 +109,8 @@ type OverlayBackgroundExtensionMessageHandlers = {
checkIsFieldCurrentlyFocused: () => boolean; checkIsFieldCurrentlyFocused: () => boolean;
updateIsFieldCurrentlyFilling: ({ message }: BackgroundMessageParam) => void; updateIsFieldCurrentlyFilling: ({ message }: BackgroundMessageParam) => void;
checkIsFieldCurrentlyFilling: () => boolean; checkIsFieldCurrentlyFilling: () => boolean;
checkIsInlineMenuButtonVisible: ({ sender }: BackgroundSenderParam) => void; checkIsAutofillInlineMenuButtonVisible: ({ sender }: BackgroundSenderParam) => void;
checkIsInlineMenuListVisible: ({ sender }: BackgroundSenderParam) => void; checkIsAutofillInlineMenuListVisible: ({ sender }: BackgroundSenderParam) => void;
checkIsOverlayLoginCiphersPopulated: ({ sender }: BackgroundSenderParam) => void; checkIsOverlayLoginCiphersPopulated: ({ sender }: BackgroundSenderParam) => void;
updateSubFrameData: ({ message, sender }: BackgroundOnMessageHandlerParams) => void; updateSubFrameData: ({ message, sender }: BackgroundOnMessageHandlerParams) => void;
rebuildSubFrameOffsets: ({ sender }: BackgroundSenderParam) => void; rebuildSubFrameOffsets: ({ sender }: BackgroundSenderParam) => void;

14
apps/browser/src/autofill/background/overlay.background.ts
View File

@@ -80,8 +80,10 @@ class OverlayBackground implements OverlayBackgroundInterface {
checkIsFieldCurrentlyFocused: () => this.checkIsFieldCurrentlyFocused(), checkIsFieldCurrentlyFocused: () => this.checkIsFieldCurrentlyFocused(),
updateIsFieldCurrentlyFilling: ({ message }) => this.updateIsFieldCurrentlyFilling(message), updateIsFieldCurrentlyFilling: ({ message }) => this.updateIsFieldCurrentlyFilling(message),
checkIsFieldCurrentlyFilling: () => this.checkIsFieldCurrentlyFilling(), checkIsFieldCurrentlyFilling: () => this.checkIsFieldCurrentlyFilling(),
checkIsInlineMenuButtonVisible: ({ sender }) => this.checkIsInlineMenuButtonVisible(sender), checkIsAutofillInlineMenuButtonVisible: ({ sender }) =>
checkIsInlineMenuListVisible: ({ sender }) => this.checkIsInlineMenuListVisible(sender), this.checkIsAutofillInlineMenuButtonVisible(sender),
checkIsAutofillInlineMenuListVisible: ({ sender }) =>
this.checkIsAutofillInlineMenuListVisible(sender),
checkIsOverlayLoginCiphersPopulated: ({ sender }) => checkIsOverlayLoginCiphersPopulated: ({ sender }) =>
this.checkIsOverlayLoginCiphersPopulated(sender), this.checkIsOverlayLoginCiphersPopulated(sender),
updateSubFrameData: ({ message, sender }) => this.updateSubFrameData(message, sender), updateSubFrameData: ({ message, sender }) => this.updateSubFrameData(message, sender),
@@ -873,18 +875,18 @@ class OverlayBackground implements OverlayBackgroundInterface {
return this.isFieldCurrentlyFilling; return this.isFieldCurrentlyFilling;
} }
private async checkIsInlineMenuButtonVisible(sender: chrome.runtime.MessageSender) { private async checkIsAutofillInlineMenuButtonVisible(sender: chrome.runtime.MessageSender) {
return await BrowserApi.tabSendMessage( return await BrowserApi.tabSendMessage(
sender.tab, sender.tab,
{ command: "checkIsInlineMenuButtonVisible" }, { command: "checkIsAutofillInlineMenuButtonVisible" },
{ frameId: 0 }, { frameId: 0 },
); );
} }
private async checkIsInlineMenuListVisible(sender: chrome.runtime.MessageSender) { private async checkIsAutofillInlineMenuListVisible(sender: chrome.runtime.MessageSender) {
return await BrowserApi.tabSendMessage( return await BrowserApi.tabSendMessage(
sender.tab, sender.tab,
{ command: "checkIsInlineMenuListVisible" }, { command: "checkIsAutofillInlineMenuListVisible" },
{ frameId: 0 }, { frameId: 0 },
); );
} }

4
apps/browser/src/autofill/overlay/abstractions/autofill-overlay-inline-menu-elements.ts
View File

@@ -5,8 +5,8 @@ export type InlineMenuExtensionMessageHandlers = {
closeInlineMenu: ({ message }: AutofillExtensionMessageParam) => void; closeInlineMenu: ({ message }: AutofillExtensionMessageParam) => void;
appendInlineMenuElementsToDom: ({ message }: AutofillExtensionMessageParam) => Promise<void>; appendInlineMenuElementsToDom: ({ message }: AutofillExtensionMessageParam) => Promise<void>;
toggleInlineMenuHidden: ({ message }: AutofillExtensionMessageParam) => void; toggleInlineMenuHidden: ({ message }: AutofillExtensionMessageParam) => void;
checkIsInlineMenuButtonVisible: () => boolean; checkIsAutofillInlineMenuButtonVisible: () => boolean;
checkIsInlineMenuListVisible: () => boolean; checkIsAutofillInlineMenuListVisible: () => boolean;
}; };
export interface AutofillOverlayInlineMenuElements { export interface AutofillOverlayInlineMenuElements {

4
apps/browser/src/autofill/overlay/content/autofill-overlay-inline-menu-elements.ts
View File

@@ -39,8 +39,8 @@ export class AutofillOverlayInlineMenuElements implements InlineMenuElementsInte
appendInlineMenuElementsToDom: ({ message }) => this.appendInlineMenuElements(message), appendInlineMenuElementsToDom: ({ message }) => this.appendInlineMenuElements(message),
toggleInlineMenuHidden: ({ message }) => toggleInlineMenuHidden: ({ message }) =>
this.toggleInlineMenuHidden(message.isInlineMenuHidden), this.toggleInlineMenuHidden(message.isInlineMenuHidden),
checkIsInlineMenuButtonVisible: () => this.isInlineMenuButtonVisible(), checkIsAutofillInlineMenuButtonVisible: () => this.isInlineMenuButtonVisible(),
checkIsInlineMenuListVisible: () => this.isInlineMenuListVisible(), checkIsAutofillInlineMenuListVisible: () => this.isInlineMenuListVisible(),
}; };
constructor() { constructor() {

4
apps/browser/src/autofill/services/autofill-overlay-content.service.ts
View File

@@ -1002,11 +1002,11 @@ class AutofillOverlayContentService implements AutofillOverlayContentServiceInte
} }
private async isInlineMenuButtonVisible() { private async isInlineMenuButtonVisible() {
return (await this.sendExtensionMessage("checkIsInlineMenuButtonVisible")) === true; return (await this.sendExtensionMessage("checkIsAutofillInlineMenuButtonVisible")) === true;
} }
private async isInlineMenuListVisible() { private async isInlineMenuListVisible() {
return (await this.sendExtensionMessage("checkIsInlineMenuListVisible")) === true; return (await this.sendExtensionMessage("checkIsAutofillInlineMenuListVisible")) === true;
} }
private async isInlineMenuCiphersPopulated() { private async isInlineMenuCiphersPopulated() {