From eadf3ded8295d8bb2635bb73a1d0a28b6c15e4aa Mon Sep 17 00:00:00 2001 From: Patrick Pimentel Date: Thu, 22 Jan 2026 16:19:53 -0500 Subject: [PATCH] fix(register): [PM-27085] Account Register Uses New Data Types - Removed unnecessary part of the payload. --- .../registration/web-registration-finish.service.spec.ts | 4 ++-- .../default-registration-finish.service.spec.ts | 4 ++-- .../default-registration-finish.service.ts | 1 - .../models/request/registration/register-finish-v2.request.ts | 2 -- libs/common/src/enums/feature-flag.enum.ts | 1 + 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/apps/web/src/app/auth/core/services/registration/web-registration-finish.service.spec.ts b/apps/web/src/app/auth/core/services/registration/web-registration-finish.service.spec.ts index 9b6c26e0869..9fa3df5d5fd 100644 --- a/apps/web/src/app/auth/core/services/registration/web-registration-finish.service.spec.ts +++ b/apps/web/src/app/auth/core/services/registration/web-registration-finish.service.spec.ts @@ -400,7 +400,6 @@ describe("WebRegistrationFinishService", () => { expect.objectContaining({ email, emailVerificationToken: emailVerificationToken, - masterPasswordHash: passwordInputResult.newServerMasterKeyHash, masterPasswordHint: passwordInputResult.newPasswordHint, userSymmetricKey: userKeyEncString.encryptedString, userAsymmetricKeys: { @@ -420,7 +419,8 @@ describe("WebRegistrationFinishService", () => { ).toBeDefined(); expect((registerCall as RegisterFinishV2Request).masterPasswordUnlock).toBeDefined(); - // Verify old API fields are NOT present + // Verify old API fields are NOT present (including masterPasswordHash which is in masterPasswordAuthentication) + expect((registerCall as any).masterPasswordHash).toBeUndefined(); expect((registerCall as any).kdf).toBeUndefined(); expect((registerCall as any).kdfIterations).toBeUndefined(); }); diff --git a/libs/auth/src/angular/registration/registration-finish/default-registration-finish.service.spec.ts b/libs/auth/src/angular/registration/registration-finish/default-registration-finish.service.spec.ts index 3cefc8613de..2e5734bd4f8 100644 --- a/libs/auth/src/angular/registration/registration-finish/default-registration-finish.service.spec.ts +++ b/libs/auth/src/angular/registration/registration-finish/default-registration-finish.service.spec.ts @@ -192,7 +192,6 @@ describe("DefaultRegistrationFinishService", () => { expect.objectContaining({ email, emailVerificationToken: emailVerificationToken, - masterPasswordHash: passwordInputResult.newServerMasterKeyHash, masterPasswordHint: passwordInputResult.newPasswordHint, userSymmetricKey: userKeyEncString.encryptedString, userAsymmetricKeys: { @@ -212,7 +211,8 @@ describe("DefaultRegistrationFinishService", () => { ).toBeDefined(); expect((registerCall as RegisterFinishV2Request).masterPasswordUnlock).toBeDefined(); - // Verify old API fields are NOT present + // Verify old API fields are NOT present (including masterPasswordHash which is in masterPasswordAuthentication) + expect((registerCall as any).masterPasswordHash).toBeUndefined(); expect((registerCall as any).kdf).toBeUndefined(); expect((registerCall as any).kdfIterations).toBeUndefined(); }); diff --git a/libs/auth/src/angular/registration/registration-finish/default-registration-finish.service.ts b/libs/auth/src/angular/registration/registration-finish/default-registration-finish.service.ts index edd03f525db..25fce66197e 100644 --- a/libs/auth/src/angular/registration/registration-finish/default-registration-finish.service.ts +++ b/libs/auth/src/angular/registration/registration-finish/default-registration-finish.service.ts @@ -113,7 +113,6 @@ export class DefaultRegistrationFinishService implements RegistrationFinishServi const registerFinishRequest = new RegisterFinishV2Request( email, - passwordInputResult.newServerMasterKeyHash, passwordInputResult.newPasswordHint, encryptedUserKey, userAsymmetricKeysRequest, diff --git a/libs/common/src/auth/models/request/registration/register-finish-v2.request.ts b/libs/common/src/auth/models/request/registration/register-finish-v2.request.ts index cab57023b71..dc079a1a392 100644 --- a/libs/common/src/auth/models/request/registration/register-finish-v2.request.ts +++ b/libs/common/src/auth/models/request/registration/register-finish-v2.request.ts @@ -8,8 +8,6 @@ import { KeysRequest } from "../../../../models/request/keys.request"; export class RegisterFinishV2Request { constructor( public email: string, - - public masterPasswordHash: string, public masterPasswordHint: string, public userSymmetricKey: EncryptedString, diff --git a/libs/common/src/enums/feature-flag.enum.ts b/libs/common/src/enums/feature-flag.enum.ts index 4dd91e5c948..d0a6edd736d 100644 --- a/libs/common/src/enums/feature-flag.enum.ts +++ b/libs/common/src/enums/feature-flag.enum.ts @@ -135,6 +135,7 @@ export const DefaultFeatureFlagValue = { /* Auth */ [FeatureFlag.PM23801_PrefetchPasswordPrelogin]: FALSE, + [FeatureFlag.PM27044_UpdateRegistrationApis]: FALSE, /* Billing */ [FeatureFlag.TrialPaymentOptional]: FALSE,