bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 00:33:44 +00:00
Code Issues Releases Wiki Activity

[PM-8869] Fix broken autofill cache invalidation features on Safari (#9643)

Browse Source 
* [PM-8869] Autofill features broken on Safari

* [PM-8869] Autofill features broken on Safari
This commit is contained in:
Cesar Gonzalez
2024-06-14 10:26:41 -05:00
committed by GitHub
parent 9ef8404b7b
commit eb96f7dbfb
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/browser/src/autofill/services/collect-autofill-content.service.ts
View File

@@ -21,6 +21,7 @@ import {
nodeIsFormElement, nodeIsFormElement,
nodeIsInputElement, nodeIsInputElement,
sendExtensionMessage, sendExtensionMessage,
requestIdleCallbackPolyfill,
} from "../utils"; } from "../utils";
import { AutofillOverlayContentService } from "./abstractions/autofill-overlay-content.service"; import { AutofillOverlayContentService } from "./abstractions/autofill-overlay-content.service";
@@ -1057,7 +1058,7 @@ class CollectAutofillContentService implements CollectAutofillContentServiceInte
} }
if (!this.mutationsQueue.length) { if (!this.mutationsQueue.length) {
globalThis.requestIdleCallback(this.processMutations, { timeout: 500 }); requestIdleCallbackPolyfill(this.processMutations, { timeout: 500 });
} }
this.mutationsQueue.push(mutations); this.mutationsQueue.push(mutations);
}; };
@@ -1194,7 +1195,7 @@ class CollectAutofillContentService implements CollectAutofillContentServiceInte
continue; continue;
} }
globalThis.requestIdleCallback( requestIdleCallbackPolyfill(
// We are setting this item to a -1 index because we do not know its position in the DOM. // We are setting this item to a -1 index because we do not know its position in the DOM.
// This value should be updated with the next call to collect page details. // This value should be updated with the next call to collect page details.
() => void this.buildAutofillFieldItem(node as ElementWithOpId<FormFieldElement>, -1), () => void this.buildAutofillFieldItem(node as ElementWithOpId<FormFieldElement>, -1),

14
apps/browser/src/autofill/utils/index.ts
View File

@@ -1,6 +1,20 @@
import { AutofillPort } from "../enums/autofill-port.enums"; import { AutofillPort } from "../enums/autofill-port.enums";
import { FillableFormFieldElement, FormFieldElement } from "../types"; import { FillableFormFieldElement, FormFieldElement } from "../types";
/**
* Polyfills the requestIdleCallback API with a setTimeout fallback.
*
* @param callback - The callback function to run when the browser is idle.
* @param options - The options to pass to the requestIdleCallback function.
*/
export function requestIdleCallbackPolyfill(callback: () => void, options?: Record<string, any>) {
if ("requestIdleCallback" in globalThis) {
return globalThis.requestIdleCallback(() => callback(), options);
}
return globalThis.setTimeout(() => callback(), 1);
}
/** /**
* Generates a random string of characters that formatted as a custom element name. * Generates a random string of characters that formatted as a custom element name.
*/ */