From ebdde5925c6a041a3342e47b48045c9ad7a94e27 Mon Sep 17 00:00:00 2001
From: Kyle Spearrin <kyle.spearrin@gmail.com>
Date: Thu, 19 Apr 2018 09:02:25 -0400
Subject: [PATCH] slice instead of pop folders

---
 src/popup/settings/folders.component.ts | 7 +++++--
 src/popup/vault/groupings.component.ts  | 4 ++--
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/popup/settings/folders.component.ts b/src/popup/settings/folders.component.ts
index 54465b33c82..fc3cbf2708e 100644
--- a/src/popup/settings/folders.component.ts
+++ b/src/popup/settings/folders.component.ts
@@ -15,11 +15,14 @@ import { FolderService } from 'jslib/abstractions/folder.service';
 export class FoldersComponent implements OnInit {
     folders: FolderView[];
 
-    constructor(private folderService: FolderService, private router: Router) {
-    }
+    constructor(private folderService: FolderService, private router: Router) { }
 
     async ngOnInit() {
         this.folders = await this.folderService.getAllDecrypted();
+        // Remove "No Folder"
+        if (this.folders.length > 0) {
+            this.folders = this.folders.slice(0, this.folders.length - 1);
+        }
     }
 
     folderSelected(folder: FolderView) {
diff --git a/src/popup/vault/groupings.component.ts b/src/popup/vault/groupings.component.ts
index 77de2dc9937..c6d552b1968 100644
--- a/src/popup/vault/groupings.component.ts
+++ b/src/popup/vault/groupings.component.ts
@@ -137,9 +137,9 @@ export class GroupingsComponent extends BaseGroupingsComponent implements OnInit
     async load() {
         await super.load(false);
         await this.loadCiphers();
-        if (this.showNoFolderCiphers) {
+        if (this.showNoFolderCiphers && this.folders.length > 0) {
             // Remove "No Folder" from folder listing
-            this.folders.pop();
+            this.folders = this.folders.slice(0, this.folders.length - 1);
         }
 
         super.loaded = true;