From eca060d7e6c18b6599bfce20b058a2cde8c514a7 Mon Sep 17 00:00:00 2001
From: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
Date: Tue, 8 Aug 2023 12:08:39 -0500
Subject: [PATCH] [SM-240] Add max length limit on SM strings (#5823)

* Add max length limit on SM strings

* remove HTML attributes

* remove from project
---
 .../projects/dialog/project-dialog.component.html         | 2 +-
 .../projects/dialog/project-dialog.component.ts           | 2 +-
 .../secrets/dialog/secret-dialog.component.html           | 2 +-
 .../secrets/dialog/secret-dialog.component.ts             | 8 ++++----
 .../dialog/service-account-dialog.component.html          | 2 +-
 .../dialog/service-account-dialog.component.ts            | 2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/bitwarden_license/bit-web/src/app/secrets-manager/projects/dialog/project-dialog.component.html b/bitwarden_license/bit-web/src/app/secrets-manager/projects/dialog/project-dialog.component.html
index 34082cd4d60..b56f7d45121 100644
--- a/bitwarden_license/bit-web/src/app/secrets-manager/projects/dialog/project-dialog.component.html
+++ b/bitwarden_license/bit-web/src/app/secrets-manager/projects/dialog/project-dialog.component.html
@@ -7,7 +7,7 @@
       </div>
       <bit-form-field *ngIf="!loading">
         <bit-label>{{ "projectName" | i18n }}</bit-label>
-        <input appAutofocus formControlName="name" maxlength="1000" bitInput />
+        <input appAutofocus formControlName="name" bitInput />
       </bit-form-field>
     </span>
     <ng-container bitDialogFooter>
diff --git a/bitwarden_license/bit-web/src/app/secrets-manager/projects/dialog/project-dialog.component.ts b/bitwarden_license/bit-web/src/app/secrets-manager/projects/dialog/project-dialog.component.ts
index 42ec8ef02f6..a6a3c958d09 100644
--- a/bitwarden_license/bit-web/src/app/secrets-manager/projects/dialog/project-dialog.component.ts
+++ b/bitwarden_license/bit-web/src/app/secrets-manager/projects/dialog/project-dialog.component.ts
@@ -27,7 +27,7 @@ export interface ProjectOperation {
 export class ProjectDialogComponent implements OnInit {
   protected formGroup = new FormGroup({
     name: new FormControl("", {
-      validators: [Validators.required, BitValidators.trimValidator],
+      validators: [Validators.required, Validators.maxLength(500), BitValidators.trimValidator],
       updateOn: "submit",
     }),
   });
diff --git a/bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-dialog.component.html b/bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-dialog.component.html
index d190a7f91be..62692511e23 100644
--- a/bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-dialog.component.html
+++ b/bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-dialog.component.html
@@ -41,7 +41,7 @@
 
       <bit-form-field *ngIf="addNewProject == true">
         <bit-label>{{ "projectName" | i18n }}</bit-label>
-        <input formControlName="newProjectName" maxlength="1000" bitInput />
+        <input formControlName="newProjectName" bitInput />
       </bit-form-field>
     </div>
     <ng-container bitDialogFooter>
diff --git a/bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-dialog.component.ts b/bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-dialog.component.ts
index 4bf9bd6f768..1c376739970 100644
--- a/bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-dialog.component.ts
+++ b/bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-dialog.component.ts
@@ -38,17 +38,17 @@ export interface SecretOperation {
 export class SecretDialogComponent implements OnInit {
   protected formGroup = new FormGroup({
     name: new FormControl("", {
-      validators: [Validators.required, BitValidators.trimValidator],
+      validators: [Validators.required, Validators.maxLength(500), BitValidators.trimValidator],
       updateOn: "submit",
     }),
-    value: new FormControl("", [Validators.required]),
+    value: new FormControl("", [Validators.required, Validators.maxLength(3500)]),
     notes: new FormControl("", {
-      validators: [BitValidators.trimValidator],
+      validators: [Validators.maxLength(7000), BitValidators.trimValidator],
       updateOn: "submit",
     }),
     project: new FormControl("", [Validators.required]),
     newProjectName: new FormControl("", {
-      validators: [BitValidators.trimValidator],
+      validators: [Validators.maxLength(500), BitValidators.trimValidator],
       updateOn: "submit",
     }),
   });
diff --git a/bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/dialog/service-account-dialog.component.html b/bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/dialog/service-account-dialog.component.html
index dcd68aa6deb..5f7260025cf 100644
--- a/bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/dialog/service-account-dialog.component.html
+++ b/bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/dialog/service-account-dialog.component.html
@@ -8,7 +8,7 @@
       <div *ngIf="!loading">
         <bit-form-field>
           <bit-label>{{ "serviceAccountName" | i18n }}</bit-label>
-          <input appAutofocus formControlName="name" maxlength="1000" bitInput />
+          <input appAutofocus formControlName="name" bitInput />
         </bit-form-field>
       </div>
     </div>
diff --git a/bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/dialog/service-account-dialog.component.ts b/bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/dialog/service-account-dialog.component.ts
index 68efb9e475d..1f42537f956 100644
--- a/bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/dialog/service-account-dialog.component.ts
+++ b/bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/dialog/service-account-dialog.component.ts
@@ -27,7 +27,7 @@ export class ServiceAccountDialogComponent {
   protected formGroup = new FormGroup(
     {
       name: new FormControl("", {
-        validators: [Validators.required, BitValidators.trimValidator],
+        validators: [Validators.required, Validators.maxLength(500), BitValidators.trimValidator],
         updateOn: "submit",
       }),
     },