From ee8845f637e1332c08e368a8a72111440d9b258d Mon Sep 17 00:00:00 2001 From: Jimmy Vo Date: Tue, 17 Dec 2024 11:37:00 -0500 Subject: [PATCH] Remove null and undefined checks --- .../org-seat-limit-reached.validator.spec.ts | 30 ++++++++----------- .../org-seat-limit-reached.validator.ts | 4 --- 2 files changed, 13 insertions(+), 21 deletions(-) diff --git a/apps/web/src/app/admin-console/organizations/members/components/member-dialog/validators/org-seat-limit-reached.validator.spec.ts b/apps/web/src/app/admin-console/organizations/members/components/member-dialog/validators/org-seat-limit-reached.validator.spec.ts index c975ae5ee5a..a97623d7a38 100644 --- a/apps/web/src/app/admin-console/organizations/members/components/member-dialog/validators/org-seat-limit-reached.validator.spec.ts +++ b/apps/web/src/app/admin-console/organizations/members/components/member-dialog/validators/org-seat-limit-reached.validator.spec.ts @@ -172,27 +172,23 @@ describe("orgSeatLimitReachedValidator", () => { describe("isFixedSeatPlan", () => { test.each([ - [ProductTierType.Free, true], - [ProductTierType.Families, true], - [ProductTierType.TeamsStarter, true], - [ProductTierType.Enterprise, false], - [null, false], - [undefined, false], - ])("should return %s for %s", (input, expected) => { - expect(isFixedSeatPlan(input as ProductTierType)).toBe(expected); + [true, ProductTierType.Free], + [true, ProductTierType.Families], + [true, ProductTierType.TeamsStarter], + [false, ProductTierType.Enterprise], + ])("should return %s for %s", (expected, input) => { + expect(isFixedSeatPlan(input)).toBe(expected); }); }); describe("isDynamicSeatPlan", () => { test.each([ - [ProductTierType.Enterprise, true], - [ProductTierType.Teams, true], - [ProductTierType.Free, false], - [ProductTierType.Families, false], - [ProductTierType.TeamsStarter, false], - [null, false], - [undefined, false], - ])("should return %s for %s", (input, expected) => { - expect(isDynamicSeatPlan(input as ProductTierType)).toBe(expected); + [true, ProductTierType.Enterprise], + [true, ProductTierType.Teams], + [false, ProductTierType.Free], + [false, ProductTierType.Families], + [false, ProductTierType.TeamsStarter], + ])("should return %s for %s", (expected, input) => { + expect(isDynamicSeatPlan(input)).toBe(expected); }); }); diff --git a/apps/web/src/app/admin-console/organizations/members/components/member-dialog/validators/org-seat-limit-reached.validator.ts b/apps/web/src/app/admin-console/organizations/members/components/member-dialog/validators/org-seat-limit-reached.validator.ts index 5b94f591df6..1990bf7e32f 100644 --- a/apps/web/src/app/admin-console/organizations/members/components/member-dialog/validators/org-seat-limit-reached.validator.ts +++ b/apps/web/src/app/admin-console/organizations/members/components/member-dialog/validators/org-seat-limit-reached.validator.ts @@ -39,10 +39,6 @@ export function orgSeatLimitReachedValidator( } export function isDynamicSeatPlan(productTierType: ProductTierType): boolean { - if (!productTierType) { - return false; - } - return !isFixedSeatPlan(productTierType); }