From ef299f398a82e255fad2c940989ed3a12e6ab15a Mon Sep 17 00:00:00 2001 From: Nik Gilmore Date: Fri, 16 Jan 2026 15:12:17 -0800 Subject: [PATCH] Fix type issues --- libs/common/src/vault/services/cipher-sdk.service.spec.ts | 2 +- libs/common/src/vault/services/cipher-sdk.service.ts | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libs/common/src/vault/services/cipher-sdk.service.spec.ts b/libs/common/src/vault/services/cipher-sdk.service.spec.ts index e6c4b547e86..8e1a5b3747e 100644 --- a/libs/common/src/vault/services/cipher-sdk.service.spec.ts +++ b/libs/common/src/vault/services/cipher-sdk.service.spec.ts @@ -210,7 +210,7 @@ describe("DefaultCipherSdkService", () => { id: expect.anything(), name: cipherView.name, }), - undefined, + new CipherView().toSdkCipherView(), ); expect(result).toBeInstanceOf(CipherView); expect(result.name).toBe(cipherView.name); diff --git a/libs/common/src/vault/services/cipher-sdk.service.ts b/libs/common/src/vault/services/cipher-sdk.service.ts index e4ba3383716..06f5d3eb961 100644 --- a/libs/common/src/vault/services/cipher-sdk.service.ts +++ b/libs/common/src/vault/services/cipher-sdk.service.ts @@ -63,7 +63,10 @@ export class DefaultCipherSdkService implements CipherSdkService { .vault() .ciphers() .admin() - .edit(sdkUpdateRequest, originalCipherView?.toSdkCipherView()); + .edit( + sdkUpdateRequest, + originalCipherView?.toSdkCipherView() || new CipherView().toSdkCipherView(), + ); } else { result = await ref.value.vault().ciphers().edit(sdkUpdateRequest); }