[PM-5189] Fixing an issue where the inline menu can render elements as hidden when collecting page details

apps/browser/src/autofill/content/autofill-init.ts

@@ -63,7 +63,7 @@ class AutofillInit implements AutofillInitInterface {
       );
     }
 
-    this.domElementVisibilityService = new DomElementVisibilityService();
+    this.domElementVisibilityService = new DomElementVisibilityService(this.inlineMenuElements);
     this.collectAutofillContentService = new CollectAutofillContentService(
       this.domElementVisibilityService,
       this.autofillOverlayContentService,

apps/browser/src/autofill/overlay/abstractions/inline-menu-elements.ts

@@ -11,5 +11,6 @@ export type InlineMenuExtensionMessageHandlers = {
 
 export interface InlineMenuElements {
   extensionMessageHandlers: InlineMenuExtensionMessageHandlers;
-  destroy: () => void;
+  isElementInlineMenu(element: HTMLElement): boolean;
+  destroy(): void;
 }

apps/browser/src/autofill/overlay/content/inline-menu-elements.ts

@@ -52,6 +52,10 @@ export class InlineMenuElements implements InlineMenuElementsInterface {
     return this._extensionMessageHandlers;
   }
 
+  isElementInlineMenu(element: HTMLElement) {
+    return element === this.buttonElement || element === this.listElement;
+  }
+
   /**
    * Sends a message that facilitates hiding the overlay elements.
    *
@@ -133,7 +137,6 @@ export class InlineMenuElements implements InlineMenuElementsInterface {
    * Updates the position of the overlay button.
    */
   private async updateButtonPosition(): Promise<void> {
-    return new Promise((resolve) => {
     if (!this.buttonElement) {
       this.createButton();
       this.updateCustomElementDefaultStyles(this.buttonElement);
@@ -143,16 +146,12 @@ export class InlineMenuElements implements InlineMenuElementsInterface {
       this.appendOverlayElementToBody(this.buttonElement);
       this.isButtonVisible = true;
     }
-
-      resolve();
-    });
   }
 
   /**
    * Updates the position of the overlay list.
    */
   private async updateListPosition(): Promise<void> {
-    return new Promise((resolve) => {
     if (!this.listElement) {
       this.createList();
       this.updateCustomElementDefaultStyles(this.listElement);
@@ -162,9 +161,6 @@ export class InlineMenuElements implements InlineMenuElementsInterface {
       this.appendOverlayElementToBody(this.listElement);
       this.isListVisible = true;
     }
-
-      resolve();
-    });
   }
 
   /**

apps/browser/src/autofill/services/dom-element-visibility.service.ts

@@ -1,3 +1,4 @@
+import { InlineMenuElements } from "../overlay/abstractions/inline-menu-elements";
 import { FillableFormFieldElement, FormFieldElement } from "../types";
 
 import { DomElementVisibilityService as domElementVisibilityServiceInterface } from "./abstractions/dom-element-visibility.service";
@@ -5,6 +6,8 @@ import { DomElementVisibilityService as domElementVisibilityServiceInterface } f
 class DomElementVisibilityService implements domElementVisibilityServiceInterface {
   private cachedComputedStyle: CSSStyleDeclaration | null = null;
 
+  constructor(private inlineMenuElements?: InlineMenuElements) {}
+
   /**
    * Checks if a form field is viewable. This is done by checking if the element is within the
    * viewport bounds, not hidden by CSS, and not hidden behind another element.
@@ -187,6 +190,10 @@ class DomElementVisibilityService implements domElementVisibilityServiceInterfac
       return true;
     }
 
+    if (this.inlineMenuElements?.isElementInlineMenu(elementAtCenterPoint as HTMLElement)) {
+      return true;
+    }
+
     const targetElementLabelsSet = new Set((targetElement as FillableFormFieldElement).labels);
     if (targetElementLabelsSet.has(elementAtCenterPoint as HTMLLabelElement)) {
       return true;