1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 14:23:32 +00:00

[PM-10651] Use bitLink instead of icon button and add a11y title (#10483)

This commit is contained in:
Shane Melton
2024-08-13 10:15:14 -07:00
committed by GitHub
parent 6651f930aa
commit f017edb088
4 changed files with 13 additions and 3 deletions

View File

@@ -690,6 +690,9 @@
"totpHelperWithCapture": { "totpHelperWithCapture": {
"message": "Bitwarden can store and fill 2-step verification codes. Select the camera icon to take a screenshot of this website's authenticator QR code, or copy and paste the key into this field." "message": "Bitwarden can store and fill 2-step verification codes. Select the camera icon to take a screenshot of this website's authenticator QR code, or copy and paste the key into this field."
}, },
"learnMoreAboutAuthenticators": {
"message": "Learn more about authenticators"
},
"copyTOTP": { "copyTOTP": {
"message": "Copy Authenticator key (TOTP)" "message": "Copy Authenticator key (TOTP)"
}, },

View File

@@ -212,6 +212,9 @@
"totpHelperWithCapture": { "totpHelperWithCapture": {
"message": "Bitwarden can store and fill 2-step verification codes. Select the camera icon to take a screenshot of this website's authenticator QR code, or copy and paste the key into this field." "message": "Bitwarden can store and fill 2-step verification codes. Select the camera icon to take a screenshot of this website's authenticator QR code, or copy and paste the key into this field."
}, },
"learnMoreAboutAuthenticators": {
"message": "Learn more about authenticators"
},
"folder": { "folder": {
"message": "Folder" "message": "Folder"
}, },

View File

@@ -88,11 +88,13 @@
<bit-label> <bit-label>
{{ "authenticatorKey" | i18n }} {{ "authenticatorKey" | i18n }}
<button <button
bitIconButton="bwi-question-circle" bitLink
type="button" type="button"
size="small"
[bitPopoverTriggerFor]="totpPopover" [bitPopoverTriggerFor]="totpPopover"
></button> [appA11yTitle]="'learnMoreAboutAuthenticators' | i18n"
>
<i class="bwi bwi-sm bwi-question-circle" aria-hidden="true"></i>
</button>
<bit-popover #totpPopover [title]="'totpHelperTitle' | i18n"> <bit-popover #totpPopover [title]="'totpHelperTitle' | i18n">
<p>{{ (canCaptureTotp ? "totpHelperWithCapture" : "totpHelper") | i18n }}</p> <p>{{ (canCaptureTotp ? "totpHelperWithCapture" : "totpHelper") | i18n }}</p>
</bit-popover> </bit-popover>

View File

@@ -14,6 +14,7 @@ import {
CardComponent, CardComponent,
FormFieldModule, FormFieldModule,
IconButtonModule, IconButtonModule,
LinkModule,
PopoverModule, PopoverModule,
SectionComponent, SectionComponent,
SectionHeaderComponent, SectionHeaderComponent,
@@ -43,6 +44,7 @@ import { AutofillOptionsComponent } from "../autofill-options/autofill-options.c
NgIf, NgIf,
PopoverModule, PopoverModule,
AutofillOptionsComponent, AutofillOptionsComponent,
LinkModule,
], ],
}) })
export class LoginDetailsSectionComponent implements OnInit { export class LoginDetailsSectionComponent implements OnInit {