Remove empty catch blocks, and update tslint rule (#513)

electron/src/biometric.windows.main.ts

@@ -6,6 +6,7 @@ import { WindowMain } from './window.main';
 
 import { BiometricMain } from 'jslib-common/abstractions/biometric.main';
 import { I18nService } from 'jslib-common/abstractions/i18n.service';
+import { LogService } from 'jslib-common/abstractions/log.service';
 import { StorageService } from 'jslib-common/abstractions/storage.service';
 import { ConstantsService } from 'jslib-common/services/constants.service';
 
@@ -14,7 +15,8 @@ export default class BiometricWindowsMain implements BiometricMain {
 
     private windowsSecurityCredentialsUiModule: any;
 
-    constructor(private storageService: StorageService, private i18nservice: I18nService, private windowMain: WindowMain) { }
+    constructor(private storageService: StorageService, private i18nservice: I18nService, private windowMain: WindowMain,
+        private logService: LogService) { }
 
     async init() {
         this.windowsSecurityCredentialsUiModule = this.getWindowsSecurityCredentialsUiModule();
@@ -125,8 +127,9 @@ export default class BiometricWindowsMain implements BiometricMain {
         try {
             const version = require('os').release();
             return Number.parseInt(version.split('.')[0], 10);
+        } catch {
+            this.logService.error('Unable to resolve windows major version number');
         }
-        catch { }
         return -1;
     }
 }

electron/src/window.main.ts

@@ -1,13 +1,21 @@
-import { app, BrowserWindow, screen } from 'electron';
-import { ElectronConstants } from './electronConstants';
-
+import {
+    app,
+    BrowserWindow,
+    screen,
+} from 'electron';
 import * as path from 'path';
 import * as url from 'url';
 
-import { isDev, isMacAppStore, isSnapStore } from './utils';
-
+import { LogService } from 'jslib-common/abstractions/log.service';
 import { StorageService } from 'jslib-common/abstractions/storage.service';
 
+import { ElectronConstants } from './electronConstants';
+import {
+    isDev,
+    isMacAppStore,
+    isSnapStore,
+} from './utils';
+
 const WindowEventHandlingDelay = 100;
 const Keys = {
     mainWindowSize: 'mainWindowSize',
@@ -21,8 +29,8 @@ export class WindowMain {
     private windowStates: { [key: string]: any; } = {};
     private enableAlwaysOnTop: boolean = false;
 
-    constructor(private storageService: StorageService, private hideTitleBar = false,
-        private defaultWidth = 950, private defaultHeight = 600,
+    constructor(private storageService: StorageService, private logService: LogService,
+        private hideTitleBar = false, private defaultWidth = 950, private defaultHeight = 600,
         private argvCallback: (argv: string[]) => void = null,
         private createWindowCallback: (win: BrowserWindow) => void) { }
 
@@ -224,7 +232,9 @@ export class WindowMain {
             }
 
             await this.storageService.save(configKey, this.windowStates[configKey]);
-        } catch (e) { }
+        } catch (e) {
+            this.logService.error(e);
+        }
     }
 
     private async getWindowState(configKey: string, defaultWidth: number, defaultHeight: number) {