bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 16:53:34 +00:00
Code Issues Releases Wiki Activity

[EC-598] feat: show new cipher being added

Browse Source
This commit is contained in:
Andreas Coroiu
2023-01-05 14:30:00 +01:00
parent 6c7548c7ec
commit f0b8d32ee6
7 changed files with 80 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/common/src/abstractions/fido2/fido2-user-interface.service.abstraction.ts
View File

@@ -1,5 +1,9 @@
export interface NewCredentialParams {
name: string;
}
export abstract class Fido2UserInterfaceService {
verifyUser: () => Promise<boolean>;
verifyPresence: () => Promise<boolean>;
confirmNewCredential: () => Promise<boolean>;
confirmNewCredential: (params: NewCredentialParams) => Promise<boolean>;
}

35
libs/common/src/services/fido2/fido2.service.ts
View File

@@ -42,7 +42,9 @@ export class Fido2Service implements Fido2ServiceAbstraction {
async createCredential(
params: CredentialRegistrationParams
): Promise<CredentialRegistrationResult> {
const presence = await this.fido2UserInterfaceService.confirmNewCredential();
const presence = await this.fido2UserInterfaceService.confirmNewCredential({
name: params.origin,
});
// eslint-disable-next-line no-console
console.log("Fido2Service.createCredential", params);
@@ -123,14 +125,11 @@ export class Fido2Service implements Fido2ServiceAbstraction {
credential = await this.getCredentialByRp(params.rpId);
}
console.log("Found credential: ", credential);
if (credential === undefined) {
throw new NoCredentialFoundError();
}
if (credential.origin !== params.origin) {
console.error(`${params.origin} tried to use credential created by ${credential.origin}`);
throw new OriginMismatchError();
}
@@ -203,8 +202,6 @@ export class Fido2Service implements Fido2ServiceAbstraction {
view.fido2Key.rpId = credential.rpId;
view.fido2Key.userHandle = Fido2Utils.bufferToString(credential.userHandle);
console.log("saving credential", { view, credential });
const cipher = await this.cipherService.encrypt(view);
await this.cipherService.createWithServer(cipher);
@@ -237,22 +234,16 @@ interface AuthDataParams {
async function mapCipherViewToBitCredential(cipherView: CipherView): Promise<BitCredential> {
const keyBuffer = Fido2Utils.stringToBuffer(cipherView.fido2Key.key);
let privateKey;
try {
privateKey = await crypto.subtle.importKey(
"pkcs8",
keyBuffer,
{
name: "ECDSA",
namedCurve: "P-256",
},
true,
KeyUsages
);
} catch (err) {
console.log("Error importing key", { err });
throw err;
}
const privateKey = await crypto.subtle.importKey(
"pkcs8",
keyBuffer,
{
name: "ECDSA",
namedCurve: "P-256",
},
true,
KeyUsages
);
return {
credentialId: new CredentialId(cipherView.id),