From f22736bb648039529676571759a5fd4a1c2fec57 Mon Sep 17 00:00:00 2001
From: Jared <TheWolfBadger@gmail.com>
Date: Mon, 9 Feb 2026 13:50:20 -0500
Subject: [PATCH] [PM-25627] convert policy dialogs to drawer (#18534)

* Enhance policy edit dialogs by updating dialog size to large for improved layout and switching to openDrawer method for better user experience.

* Enhance policy edit dialogs by adding policy status badges to indicate if a policy is enabled, improving user visibility and experience.

* Update dialog component styles to enhance drawer behavior by changing height to full screen and adding sticky footer for improved layout and user experience.

* Refactor policy display layout by wrapping buttons and badges in a flex container for improved alignment and spacing.

* Refactor password policy forms in admin console for improved layout

- Simplified the structure of form fields in `master-password.component.html` and `password-generator.component.html` by removing unnecessary div wrappers.
- Updated the label for the password type policy override in `messages.json` for clarity.

* Update dialog size in policy edit component for consistency

- Changed the dialog size from 'large' to 'default' in `policy-edit-dialog.component.html` to align with design standards.

* refactor(dialog): update dialog component styles for drawer layout

- Adjusted height class for drawer dialogs from 'tw-h-screen' to 'tw-h-full' for better layout management.
- Removed sticky positioning for footer in drawer mode to improve visual consistency.

* refactor(dialog): enhance form layout for policy edit dialogs

- Added classes for full height and flex column layout to the form elements in policy edit dialogs for improved visual consistency and usability.
---
 .../policies/policies.component.html          |  14 ++-
 .../master-password.component.html            |  41 +++----
 .../password-generator.component.html         | 108 ++++++++----------
 .../policy-edit-dialog.component.html         |  12 +-
 .../policies/policy-edit-dialog.component.ts  |   9 +-
 ...-confirm-edit-policy-dialog.component.html |   9 +-
 ...to-confirm-edit-policy-dialog.component.ts |   5 +-
 ...wnership-edit-policy-dialog.component.html |  11 +-
 ...-ownership-edit-policy-dialog.component.ts |   2 +-
 apps/web/src/locales/en/messages.json         |   4 +-
 10 files changed, 115 insertions(+), 100 deletions(-)

diff --git a/apps/web/src/app/admin-console/organizations/policies/policies.component.html b/apps/web/src/app/admin-console/organizations/policies/policies.component.html
index 902c7e79d55..64fb4794037 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policies.component.html
+++ b/apps/web/src/app/admin-console/organizations/policies/policies.component.html
@@ -19,12 +19,14 @@
           @if (p.display$(organization, configService) | async) {
             <tr bitRow>
               <td bitCell ngPreserveWhitespaces>
-                <button type="button" bitLink (click)="edit(p, organizationId)">
-                  {{ p.name | i18n }}
-                </button>
-                @if (policiesEnabledMap.get(p.type)) {
-                  <span bitBadge variant="success">{{ "on" | i18n }}</span>
-                }
+                <div class="tw-flex tw-items-center tw-gap-2">
+                  <button type="button" bitLink (click)="edit(p, organizationId)">
+                    {{ p.name | i18n }}
+                  </button>
+                  @if (policiesEnabledMap.get(p.type)) {
+                    <span bitBadge variant="success">{{ "on" | i18n }}</span>
+                  }
+                </div>
                 <small class="tw-text-muted tw-block">{{ p.description | i18n }}</small>
               </td>
             </tr>
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/master-password.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/master-password.component.html
index f979c143a3a..2267bd5888e 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/master-password.component.html
+++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/master-password.component.html
@@ -13,29 +13,24 @@
     <bit-label>{{ "enforceOnLoginDesc" | i18n }}</bit-label>
   </bit-form-control>
 
-  <div class="tw-flex tw-space-x-4">
-    <bit-form-field class="tw-flex-auto">
-      <bit-label>{{ "minComplexityScore" | i18n }}</bit-label>
-      <bit-select formControlName="minComplexity" id="minComplexity">
-        <bit-option
-          *ngFor="let o of passwordScores"
-          [value]="o.value"
-          [label]="o.name"
-        ></bit-option>
-      </bit-select>
-    </bit-form-field>
-    <bit-form-field class="tw-flex-auto">
-      <bit-label>{{ "minLength" | i18n }}</bit-label>
-      <input
-        bitInput
-        type="number"
-        formControlName="minLength"
-        id="minLength"
-        [min]="MinPasswordLength"
-        [max]="MaxPasswordLength"
-      />
-    </bit-form-field>
-  </div>
+  <bit-form-field>
+    <bit-label>{{ "minComplexityScore" | i18n }}</bit-label>
+    <bit-select formControlName="minComplexity" id="minComplexity">
+      <bit-option *ngFor="let o of passwordScores" [value]="o.value" [label]="o.name"></bit-option>
+    </bit-select>
+  </bit-form-field>
+
+  <bit-form-field>
+    <bit-label>{{ "minLength" | i18n }}</bit-label>
+    <input
+      bitInput
+      type="number"
+      formControlName="minLength"
+      id="minLength"
+      [min]="MinPasswordLength"
+      [max]="MaxPasswordLength"
+    />
+  </bit-form-field>
 
   <bit-form-control class="!tw-mb-2">
     <input type="checkbox" bitCheckbox formControlName="requireUpper" id="requireUpper" />
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/password-generator.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/password-generator.component.html
index 1300acee471..372ad3609c0 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/password-generator.component.html
+++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-definitions/password-generator.component.html
@@ -4,56 +4,50 @@
     <bit-label>{{ "turnOn" | i18n }}</bit-label>
   </bit-form-control>
 
-  <div class="tw-grid tw-grid-cols-12 tw-gap-4">
-    <bit-form-field class="tw-col-span-6 tw-mb-0">
-      <bit-label>{{ "overridePasswordTypePolicy" | i18n }}</bit-label>
-      <bit-select formControlName="overridePasswordType" id="overrideType">
-        <bit-option
-          *ngFor="let o of overridePasswordTypeOptions"
-          [value]="o.value"
-          [label]="o.name"
-        ></bit-option>
-      </bit-select>
-    </bit-form-field>
-  </div>
+  <bit-form-field>
+    <bit-label>{{ "passwordTypePolicyOverride" | i18n }}</bit-label>
+    <bit-select formControlName="overridePasswordType" id="overrideType">
+      <bit-option
+        *ngFor="let o of overridePasswordTypeOptions"
+        [value]="o.value"
+        [label]="o.name"
+      ></bit-option>
+    </bit-select>
+  </bit-form-field>
 
   <!-- password-specific policies -->
   <div *ngIf="showPasswordPolicies$ | async">
     <h3 bitTypography="h3" class="tw-mt-4">{{ "password" | i18n }}</h3>
-    <div class="tw-grid tw-grid-cols-12 tw-gap-4">
-      <bit-form-field class="tw-col-span-6">
-        <bit-label>{{ "minLength" | i18n }}</bit-label>
-        <input
-          bitInput
-          type="number"
-          [min]="minLengthMin"
-          [max]="minLengthMax"
-          formControlName="minLength"
-        />
-      </bit-form-field>
-    </div>
-    <div class="tw-grid tw-grid-cols-12 tw-gap-4">
-      <bit-form-field class="tw-col-span-6">
-        <bit-label>{{ "minNumbers" | i18n }}</bit-label>
-        <input
-          bitInput
-          type="number"
-          [min]="minNumbersMin"
-          [max]="minNumbersMax"
-          formControlName="minNumbers"
-        />
-      </bit-form-field>
-      <bit-form-field class="tw-col-span-6">
-        <bit-label>{{ "minSpecial" | i18n }}</bit-label>
-        <input
-          bitInput
-          type="number"
-          [min]="minSpecialMin"
-          [max]="minSpecialMax"
-          formControlName="minSpecial"
-        />
-      </bit-form-field>
-    </div>
+    <bit-form-field>
+      <bit-label>{{ "minLength" | i18n }}</bit-label>
+      <input
+        bitInput
+        type="number"
+        [min]="minLengthMin"
+        [max]="minLengthMax"
+        formControlName="minLength"
+      />
+    </bit-form-field>
+    <bit-form-field>
+      <bit-label>{{ "minNumbers" | i18n }}</bit-label>
+      <input
+        bitInput
+        type="number"
+        [min]="minNumbersMin"
+        [max]="minNumbersMax"
+        formControlName="minNumbers"
+      />
+    </bit-form-field>
+    <bit-form-field>
+      <bit-label>{{ "minSpecial" | i18n }}</bit-label>
+      <input
+        bitInput
+        type="number"
+        [min]="minSpecialMin"
+        [max]="minSpecialMax"
+        formControlName="minSpecial"
+      />
+    </bit-form-field>
     <bit-form-control>
       <input type="checkbox" bitCheckbox formControlName="useUpper" id="useUpper" />
       <bit-label>{{ "uppercaseLabel" | i18n }}</bit-label>
@@ -79,18 +73,16 @@
   <!-- passphrase-specific policies -->
   <div *ngIf="showPassphrasePolicies$ | async">
     <h3 bitTypography="h3" class="tw-mt-4">{{ "passphrase" | i18n }}</h3>
-    <div class="tw-grid tw-grid-cols-12 tw-gap-4">
-      <bit-form-field class="tw-col-span-6">
-        <bit-label>{{ "minimumNumberOfWords" | i18n }}</bit-label>
-        <input
-          bitInput
-          type="number"
-          [min]="minNumberWordsMin"
-          [max]="minNumberWordsMax"
-          formControlName="minNumberWords"
-        />
-      </bit-form-field>
-    </div>
+    <bit-form-field>
+      <bit-label>{{ "minimumNumberOfWords" | i18n }}</bit-label>
+      <input
+        bitInput
+        type="number"
+        [min]="minNumberWordsMin"
+        [max]="minNumberWordsMax"
+        formControlName="minNumberWords"
+      />
+    </bit-form-field>
     <bit-form-control>
       <input type="checkbox" bitCheckbox formControlName="capitalize" id="capitalize" />
       <bit-label>{{ "capitalize" | i18n }}</bit-label>
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.html
index 6573801ad25..6981802e8e9 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.html
+++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.html
@@ -1,5 +1,13 @@
-<form [formGroup]="formGroup" [bitSubmit]="submit">
-  <bit-dialog [loading]="loading" [title]="'editPolicy' | i18n" [subtitle]="policy.name | i18n">
+<form [formGroup]="formGroup" [bitSubmit]="submit" class="tw-h-full tw-flex tw-flex-col">
+  <bit-dialog dialogSize="default" [loading]="loading">
+    <ng-container bitDialogTitle>
+      <span class="tw-flex tw-items-center tw-gap-2">
+        {{ policy.name | i18n }}
+        @if (isPolicyEnabled) {
+          <span bitBadge variant="success">{{ "on" | i18n }}</span>
+        }
+      </span>
+    </ng-container>
     <ng-container bitDialogContent>
       <div *ngIf="loading">
         <i
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.ts b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.ts
index f1b3d04cc7a..b2f601d4e8b 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.ts
+++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialog.component.ts
@@ -81,6 +81,10 @@ export class PolicyEditDialogComponent implements AfterViewInit {
     return this.data.policy;
   }
 
+  get isPolicyEnabled(): boolean {
+    return this.policyComponent?.policyResponse?.enabled ?? false;
+  }
+
   /**
    * Type guard to check if the policy component has the buildVNextRequest method.
    */
@@ -196,6 +200,9 @@ export class PolicyEditDialogComponent implements AfterViewInit {
     );
   }
   static open = (dialogService: DialogService, config: DialogConfig<PolicyEditDialogData>) => {
-    return dialogService.open<PolicyEditDialogResult>(PolicyEditDialogComponent, config);
+    return dialogService.openDrawer<PolicyEditDialogResult, PolicyEditDialogData>(
+      PolicyEditDialogComponent,
+      config,
+    );
   };
 }
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.html
index 4d1db65034d..fd0867a5cd5 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.html
+++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.html
@@ -1,5 +1,5 @@
-<form [formGroup]="formGroup" [bitSubmit]="submit">
-  <bit-dialog [loading]="loading">
+<form [formGroup]="formGroup" [bitSubmit]="submit" class="tw-h-full tw-flex tw-flex-col">
+  <bit-dialog dialogSize="large" [loading]="loading">
     <ng-container bitDialogTitle>
       @let title = (multiStepSubmit | async)[currentStep()]?.titleContent();
       @if (title) {
@@ -40,13 +40,16 @@
     @if (showBadge) {
       <span bitBadge variant="info" class="tw-w-[99px] tw-my-2"> {{ "availableNow" | i18n }}</span>
     }
-    <span>
+    <span class="tw-flex tw-items-center tw-gap-2">
       {{ (showBadge ? "autoConfirm" : "editPolicy") | i18n }}
       @if (!showBadge) {
         <span class="tw-text-muted tw-font-normal tw-text-sm">
           {{ policy.name | i18n }}
         </span>
       }
+      @if (isPolicyEnabled) {
+        <span bitBadge variant="success">{{ "on" | i18n }}</span>
+      }
     </span>
   </div>
 </ng-template>
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.ts b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.ts
index f0146225b8d..b5a92671054 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.ts
+++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/auto-confirm-edit-policy-dialog.component.ts
@@ -287,6 +287,9 @@ export class AutoConfirmPolicyDialogComponent
     dialogService: DialogService,
     config: DialogConfig<AutoConfirmPolicyDialogData>,
   ) => {
-    return dialogService.open<PolicyEditDialogResult>(AutoConfirmPolicyDialogComponent, config);
+    return dialogService.openDrawer<PolicyEditDialogResult, AutoConfirmPolicyDialogData>(
+      AutoConfirmPolicyDialogComponent,
+      config,
+    );
   };
 }
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.html
index 73691e94199..7b89f4d0acc 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.html
+++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.html
@@ -1,5 +1,5 @@
-<form [formGroup]="formGroup" [bitSubmit]="submit">
-  <bit-dialog [loading]="loading">
+<form [formGroup]="formGroup" [bitSubmit]="submit" class="tw-h-full tw-flex tw-flex-col">
+  <bit-dialog dialogSize="large" [loading]="loading">
     <ng-container bitDialogTitle>
       @let title = multiStepSubmit()[currentStep()]?.titleContent();
       @if (title) {
@@ -35,7 +35,12 @@
 </form>
 
 <ng-template #step0Title>
-  {{ policy.name | i18n }}
+  <span class="tw-flex tw-items-center tw-gap-2">
+    {{ policy.name | i18n }}
+    @if (isPolicyEnabled) {
+      <span bitBadge variant="success">{{ "on" | i18n }}</span>
+    }
+  </span>
 </ng-template>
 
 <ng-template #step1Title>
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.ts b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.ts
index 7869eab0063..c62be85287f 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.ts
+++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit-dialogs/organization-data-ownership-edit-policy-dialog.component.ts
@@ -216,7 +216,7 @@ export class OrganizationDataOwnershipPolicyDialogComponent
   };
 
   static open = (dialogService: DialogService, config: DialogConfig<PolicyEditDialogData>) => {
-    return dialogService.open<PolicyEditDialogResult>(
+    return dialogService.openDrawer<PolicyEditDialogResult, PolicyEditDialogData>(
       OrganizationDataOwnershipPolicyDialogComponent,
       config,
     );
diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json
index 97bb46029a7..042eec107d4 100644
--- a/apps/web/src/locales/en/messages.json
+++ b/apps/web/src/locales/en/messages.json
@@ -5394,8 +5394,8 @@
   "minimumNumberOfWords": {
     "message": "Minimum number of words"
   },
-  "overridePasswordTypePolicy": {
-    "message": "Password Type",
+  "passwordTypePolicyOverride": {
+    "message": "Password type",
     "description": "Name of the password generator policy that overrides the user's password/passphrase selection."
   },
   "userPreference": {