bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 13:23:34 +00:00
Code Issues Releases Wiki Activity

simplify updatedCipher (#14179)

Browse Source
This commit is contained in:
Anders Åberg
2025-04-09 20:23:44 +02:00
committed by GitHub
parent 411d195386
commit f3726e5ac2
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts
View File

@@ -95,8 +95,7 @@ export class DesktopFido2UserInterfaceSession implements Fido2UserInterfaceSessi
private confirmCredentialSubject = new Subject<boolean>(); private confirmCredentialSubject = new Subject<boolean>();
private createdCipher: Cipher = new Cipher(); private updatedCipher: CipherView;
private updatedCipher: CipherView = new CipherView();
private rpId = new BehaviorSubject<string>(""); private rpId = new BehaviorSubject<string>("");
private availableCipherIdsSubject = new BehaviorSubject<string[]>([""]); private availableCipherIdsSubject = new BehaviorSubject<string[]>([""]);
@@ -238,14 +237,14 @@ export class DesktopFido2UserInterfaceSession implements Fido2UserInterfaceSessi
return { cipherId: this.updatedCipher.id, userVerified: userVerification }; return { cipherId: this.updatedCipher.id, userVerified: userVerification };
} else { } else {
// Create the credential // Create the credential
await this.createCipher({ const createdCipher = await this.createCipher({
credentialName, credentialName,
userName, userName,
rpId, rpId,
userHandle, userHandle,
userVerification, userVerification,
}); });
return { cipherId: this.createdCipher.id, userVerified: userVerification }; return { cipherId: createdCipher.id, userVerified: userVerification };
} }
} finally { } finally {
// Make sure to clean up so the app is never stuck in modal mode? // Make sure to clean up so the app is never stuck in modal mode?
@@ -306,7 +305,6 @@ export class DesktopFido2UserInterfaceSession implements Fido2UserInterfaceSessi
try { try {
const createdCipher = await this.cipherService.createWithServer(encCipher); const createdCipher = await this.cipherService.createWithServer(encCipher);
this.createdCipher = createdCipher;
return createdCipher; return createdCipher;
} catch { } catch {