diff --git a/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts b/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts index 07d99fd19f1..582f8889daa 100644 --- a/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts +++ b/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts @@ -17,13 +17,12 @@ export class InlineMenuFieldQualificationService private autofillFieldKeywordsMap: WeakMap = new WeakMap(); private autocompleteDisabledValues = new Set(["off", "false"]); private newFieldKeywords = new Set(["new", "change", "neue", "ändern"]); - private useBasicInlineMenuFieldQualificationFlagSet = false; + private inlineMenuFieldQualificationFlagSet = false; constructor() { - void sendExtensionMessage("getUseBasicInlineMenuFieldQualificationFeatureFlag").then( - (getUseBasicInlineMenuFieldQualificationFlag) => - (this.useBasicInlineMenuFieldQualificationFlagSet = - !!getUseBasicInlineMenuFieldQualificationFlag?.result), + void sendExtensionMessage("getInlineMenuFieldQualificationFeatureFlag").then( + (getInlineMenuFieldQualificationFlag) => + (this.inlineMenuFieldQualificationFlagSet = !!getInlineMenuFieldQualificationFlag?.result), ); } @@ -34,7 +33,7 @@ export class InlineMenuFieldQualificationService * @param pageDetails - The details of the page that the field is on. */ isFieldForLoginForm(field: AutofillField, pageDetails: AutofillPageDetails): boolean { - if (this.useBasicInlineMenuFieldQualificationFlagSet) { + if (!this.inlineMenuFieldQualificationFlagSet) { return this.isFieldForLoginFormFallback(field); } diff --git a/apps/browser/src/background/runtime.background.ts b/apps/browser/src/background/runtime.background.ts index 3cdab2166c9..94e96e2dc89 100644 --- a/apps/browser/src/background/runtime.background.ts +++ b/apps/browser/src/background/runtime.background.ts @@ -69,7 +69,7 @@ export default class RuntimeBackground { const messagesWithResponse = [ "biometricUnlock", "getUseTreeWalkerApiForPageDetailsCollectionFeatureFlag", - "getUseBasicInlineMenuFieldQualificationFeatureFlag", + "getInlineMenuFieldQualificationFeatureFlag", ]; if (messagesWithResponse.includes(msg.command)) { @@ -187,10 +187,8 @@ export default class RuntimeBackground { FeatureFlag.UseTreeWalkerApiForPageDetailsCollection, ); } - case "getUseBasicInlineMenuFieldQualificationFeatureFlag": { - return await this.configService.getFeatureFlag( - FeatureFlag.UseBasicInlineMenuFieldQualification, - ); + case "getInlineMenuFieldQualificationFeatureFlag": { + return await this.configService.getFeatureFlag(FeatureFlag.InlineMenuFieldQualification); } } } diff --git a/libs/common/src/enums/feature-flag.enum.ts b/libs/common/src/enums/feature-flag.enum.ts index 537ceb8098e..552712f4d0a 100644 --- a/libs/common/src/enums/feature-flag.enum.ts +++ b/libs/common/src/enums/feature-flag.enum.ts @@ -18,7 +18,7 @@ export enum FeatureFlag { UseTreeWalkerApiForPageDetailsCollection = "use-tree-walker-api-for-page-details-collection", BulkDeviceApproval = "bulk-device-approval", EmailVerification = "email-verification", - UseBasicInlineMenuFieldQualification = "use-basic-inline-menu-field-qualification", + InlineMenuFieldQualification = "inline-menu-field-qualification", } export type AllowedFeatureFlagTypes = boolean | number | string; @@ -47,7 +47,7 @@ export const DefaultFeatureFlagValue = { [FeatureFlag.UseTreeWalkerApiForPageDetailsCollection]: FALSE, [FeatureFlag.BulkDeviceApproval]: FALSE, [FeatureFlag.EmailVerification]: FALSE, - [FeatureFlag.UseBasicInlineMenuFieldQualification]: FALSE, + [FeatureFlag.InlineMenuFieldQualification]: FALSE, } satisfies Record; export type DefaultFeatureFlagValueType = typeof DefaultFeatureFlagValue;