bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 08:13:42 +00:00
Code Issues Releases Wiki Activity

[EC-598] chore: rearrange tests

Browse Source
This commit is contained in:
Andreas Coroiu
2023-03-23 09:38:52 +01:00
parent 260bcc9f9e
commit f49822989c
1 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
libs/common/src/webauthn/services/fido2-authenticator.service.spec.ts
View File

@@ -152,7 +152,7 @@ describe("FidoAuthenticatorService", () => {
}); });
}); });
describe("when input passes all initial checks", () => { describe("creation of discoverable credential", () => {
/** Spec: show the items contained within the user and rp parameter structures to the user. */ /** Spec: show the items contained within the user and rp parameter structures to the user. */
it("should request confirmation from user", async () => { it("should request confirmation from user", async () => {
userInterface.confirmNewCredential.mockResolvedValue(true); userInterface.confirmNewCredential.mockResolvedValue(true);
@@ -166,20 +166,6 @@ describe("FidoAuthenticatorService", () => {
} as NewCredentialParams); } as NewCredentialParams);
}); });
/** Spec: If the user declines permission, return the CTAP2_ERR_OPERATION_DENIED error. */
it("should throw error if user denies creation request", async () => {
userInterface.confirmNewCredential.mockResolvedValue(false);
const params = await createCredentialParams();
const result = async () => await authenticator.makeCredential(params);
await expect(result).rejects.toThrowError(
Fido2AutenticatorErrorCode[Fido2AutenticatorErrorCode.CTAP2_ERR_OPERATION_DENIED]
);
});
});
describe("creation of discoverable credential", () => {
it("should save credential to vault if request confirmed by user", async () => { it("should save credential to vault if request confirmed by user", async () => {
const encryptedCipher = Symbol(); const encryptedCipher = Symbol();
userInterface.confirmNewCredential.mockResolvedValue(true); userInterface.confirmNewCredential.mockResolvedValue(true);
@@ -206,6 +192,18 @@ describe("FidoAuthenticatorService", () => {
); );
expect(cipherService.createWithServer).toHaveBeenCalledWith(encryptedCipher); expect(cipherService.createWithServer).toHaveBeenCalledWith(encryptedCipher);
}); });
/** Spec: If the user declines permission, return the CTAP2_ERR_OPERATION_DENIED error. */
it("should throw error if user denies creation request", async () => {
userInterface.confirmNewCredential.mockResolvedValue(false);
const params = await createCredentialParams();
const result = async () => await authenticator.makeCredential(params);
await expect(result).rejects.toThrowError(
Fido2AutenticatorErrorCode[Fido2AutenticatorErrorCode.CTAP2_ERR_OPERATION_DENIED]
);
});
}); });
}); });
}); });