From f5daf48c53ca78e200f05ca0133a75c2bce74226 Mon Sep 17 00:00:00 2001 From: Vicki League Date: Wed, 25 Jun 2025 17:02:55 -0400 Subject: [PATCH] tabs module improvements --- libs/components/src/tabs/tab-group/tab-body.component.ts | 4 ++-- libs/components/src/tabs/tab-group/tab.component.ts | 2 +- libs/components/src/tabs/tabs.stories.ts | 8 ++++++-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libs/components/src/tabs/tab-group/tab-body.component.ts b/libs/components/src/tabs/tab-group/tab-body.component.ts index 71863de3b3d..d4fb4c1b751 100644 --- a/libs/components/src/tabs/tab-group/tab-body.component.ts +++ b/libs/components/src/tabs/tab-group/tab-body.component.ts @@ -11,14 +11,14 @@ import { Component, effect, HostBinding, input, signal } from "@angular/core"; export class TabBodyComponent { private _firstRender = signal(false); - readonly content = input(undefined); + readonly content = input(); readonly preserveContent = input(false); @HostBinding("attr.hidden") get hidden() { return !this.active() || null; } - active = input(); + readonly active = input(); constructor() { effect(() => { diff --git a/libs/components/src/tabs/tab-group/tab.component.ts b/libs/components/src/tabs/tab-group/tab.component.ts index 950d779ee25..4261f9da5f9 100644 --- a/libs/components/src/tabs/tab-group/tab.component.ts +++ b/libs/components/src/tabs/tab-group/tab.component.ts @@ -32,7 +32,7 @@ export class TabComponent implements OnInit { * * @remarks See note 4 of https://www.w3.org/WAI/ARIA/apg/patterns/tabpanel/ */ - readonly contentTabIndex = input(undefined); + readonly contentTabIndex = input(); @ViewChild(TemplateRef, { static: true }) implicitContent: TemplateRef; @ContentChild(TabLabelDirective) templateLabel: TabLabelDirective; diff --git a/libs/components/src/tabs/tabs.stories.ts b/libs/components/src/tabs/tabs.stories.ts index 5879dd2a14e..0fe88c57a16 100644 --- a/libs/components/src/tabs/tabs.stories.ts +++ b/libs/components/src/tabs/tabs.stories.ts @@ -44,14 +44,18 @@ export default { component: TabGroupComponent, decorators: [ moduleMetadata({ - declarations: [ + imports: [ + CommonModule, + TabsModule, + ButtonModule, + FormFieldModule, + RouterModule, ActiveDummyComponent, ItemTwoDummyComponent, ItemThreeDummyComponent, ItemWithChildCounterDummyComponent, DisabledDummyComponent, ], - imports: [CommonModule, TabsModule, ButtonModule, FormFieldModule, RouterModule], }), applicationConfig({ providers: [