[PM-1399] Resolve eslint errors for button type - vault (#5274)

* Added button type to each button element related to the vault team

* Removed disable statement comment

* [PM-1399] Resolve eslint errors for button type - admin-console  (#5275)

* Added button type to each button element related to the admin console team

* Added button type to each button element related to the billing team

* Removed disable statement comment

* [PM-1399] Resolve eslint errors for button type - tools (#5284)

* Added button type to each button element related to the tools team

* Added button type to each button element related to the tools team

* Added button type to each button element related to the auth team (#5295)

apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html

@@ -1,5 +1,3 @@
-<!-- Please remove this disable statement when editing this file! -->
-<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <div class="page-header">
   <h1>{{ "emergencyAccess" | i18n }}</h1>
 </div>
@@ -85,6 +83,7 @@
         </button>
         <bit-menu #trustedContactOptions>
           <button
+            type="button"
             bitMenuItem
             *ngIf="c.status === emergencyAccessStatusType.Invited"
             (click)="reinvite(c)"
@@ -93,6 +92,7 @@
             {{ "resendInvitation" | i18n }}
           </button>
           <button
+            type="button"
             bitMenuItem
             *ngIf="c.status === emergencyAccessStatusType.Accepted"
             (click)="confirm(c)"
@@ -101,6 +101,7 @@
             {{ "confirm" | i18n }}
           </button>
           <button
+            type="button"
             bitMenuItem
             *ngIf="c.status === emergencyAccessStatusType.RecoveryInitiated"
             (click)="approve(c)"
@@ -109,6 +110,7 @@
             {{ "approve" | i18n }}
           </button>
           <button
+            type="button"
             bitMenuItem
             *ngIf="
               c.status === emergencyAccessStatusType.RecoveryInitiated ||
@@ -119,7 +121,7 @@
             <i class="bwi bwi-fw bwi-close" aria-hidden="true"></i>
             {{ "reject" | i18n }}
           </button>
-          <button bitMenuItem (click)="remove(c)">
+          <button type="button" bitMenuItem (click)="remove(c)">
             <i class="bwi bwi-fw bwi-close" aria-hidden="true"></i>
             {{ "remove" | i18n }}
           </button>
@@ -198,6 +200,7 @@
         </button>
         <bit-menu #grantedContactOptions>
           <button
+            type="button"
             bitMenuItem
             *ngIf="c.status === emergencyAccessStatusType.Confirmed"
             (click)="requestAccess(c)"
@@ -206,6 +209,7 @@
             {{ "requestAccess" | i18n }}
           </button>
           <button
+            type="button"
             bitMenuItem
             *ngIf="
               c.status === emergencyAccessStatusType.RecoveryApproved &&
@@ -217,6 +221,7 @@
             {{ "takeover" | i18n }}
           </button>
           <button
+            type="button"
             bitMenuItem
             *ngIf="
               c.status === emergencyAccessStatusType.RecoveryApproved &&
@@ -227,7 +232,7 @@
             <i class="bwi bwi-fw bwi-eye" aria-hidden="true"></i>
             {{ "view" | i18n }}
           </button>
-          <button bitMenuItem (click)="remove(c)">
+          <button type="button" bitMenuItem (click)="remove(c)">
             <i class="bwi bwi-fw bwi-close" aria-hidden="true"></i>
             {{ "remove" | i18n }}
           </button>

apps/web/src/app/auth/settings/two-factor-setup.component.html

@@ -1,5 +1,3 @@
-<!-- Please remove this disable statement when editing this file! -->
-<!-- eslint-disable @angular-eslint/template/button-has-type -->
 <div [ngClass]="tabbedHeader ? 'tabbed-header' : 'page-header'">
   <h1 *ngIf="!organizationId">{{ "twoStepLogin" | i18n }}</h1>
   <h1 *ngIf="organizationId">{{ "twoStepLoginEnforcement" | i18n }}</h1>
@@ -16,7 +14,7 @@
 </ng-container>
 <bit-callout type="warning" *ngIf="!organizationId">
   <p>{{ "twoStepLoginRecoveryWarning" | i18n }}</p>
-  <button bitButton buttonType="secondary" (click)="recoveryCode()">
+  <button type="button" bitButton buttonType="secondary" (click)="recoveryCode()">
     {{ "viewRecoveryCode" | i18n }}
   </button>
 </bit-callout>
@@ -56,6 +54,7 @@
     </div>
     <div class="ml-auto">
       <button
+        type="button"
         bitButton
         buttonType="secondary"
         [disabled]="!canAccessPremium && p.premium"