From f901553dd12ca08287c09be711051f38dad8144e Mon Sep 17 00:00:00 2001 From: Miles Blackwood Date: Wed, 30 Apr 2025 14:42:28 -0400 Subject: [PATCH] Ensure security task is pending. --- .../background/overlay-notifications.background.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/browser/src/autofill/background/overlay-notifications.background.ts b/apps/browser/src/autofill/background/overlay-notifications.background.ts index 7b146d90dcc..83ea7040a00 100644 --- a/apps/browser/src/autofill/background/overlay-notifications.background.ts +++ b/apps/browser/src/autofill/background/overlay-notifications.background.ts @@ -9,7 +9,7 @@ import { LogService } from "@bitwarden/common/platform/abstractions/log.service" import { UserId } from "@bitwarden/common/types/guid"; import { CipherService } from "@bitwarden/common/vault/abstractions/cipher.service"; import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view"; -import { SecurityTask, TaskService } from "@bitwarden/common/vault/tasks"; +import { SecurityTask, SecurityTaskStatus, TaskService } from "@bitwarden/common/vault/tasks"; import { BrowserApi } from "../../platform/browser/browser-api"; import { generateDomainMatchPatterns, isInvalidResponseStatusCode } from "../utils"; @@ -514,7 +514,11 @@ export class OverlayNotificationsBackground implements OverlayNotificationsBackg const cipherIds: CipherView["id"][] = ciphers.map((c) => c.id); const securityTask = - tasks.length > 0 && tasks.find((task) => cipherIds.indexOf(task.cipherId) > -1); + tasks.length > 0 && + tasks.find( + (task) => + task.status && SecurityTaskStatus.Pending && cipherIds.indexOf(task.cipherId) > -1, + ); const cipher = ciphers.find((cipher) => cipher.id === securityTask.cipherId);