mirror of
https://github.com/bitwarden/browser
synced 2026-01-04 01:23:57 +00:00
address review comments
This commit is contained in:
@@ -22,7 +22,6 @@ struct CheckBrowserInstalledResponse {
|
||||
#[derive(Debug, Deserialize)]
|
||||
#[serde(rename_all = "camelCase", tag = "type")]
|
||||
enum CommandResult<T> {
|
||||
// rename = "camelCase" was a review suggestion with breaking changes
|
||||
Success { value: T },
|
||||
Error { error: String },
|
||||
}
|
||||
@@ -180,9 +179,7 @@ async fn is_browser_installed(browser_name: &str) -> Result<bool> {
|
||||
.map(|(_, id)| *id);
|
||||
|
||||
let Some(bundle_id) = bundle_id else {
|
||||
return Ok(true); // ok_or(true) was a review suggestion with breaking changes
|
||||
// Avoid ok_or(true): serializes Result as {"Ok": "..."} instead of string
|
||||
// value
|
||||
return Ok(true);
|
||||
};
|
||||
|
||||
let input = CommandInput {
|
||||
|
||||
Reference in New Issue
Block a user