bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-19 00:43:25 +00:00
Code Issues Releases Wiki Activity

address review comments

Browse Source
This commit is contained in:
John Harrington
2025-12-16 09:05:14 -07:00
parent 3899314734
commit fb860cd975
5 changed files with 24 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/desktop/src/app/tools/import/chromium-importer.service.ts
View File

@@ -12,11 +12,7 @@ export class ChromiumImporterService {
// Used on Mac OS App Store builds to request permissions to browser entries outside the sandbox
ipcMain.handle("chromium_importer.requestBrowserAccess", async (event, browser: string) => {
if (chromium_importer.requestBrowserAccess) {
return await chromium_importer.requestBrowserAccess(browser, isMacAppStore());
}
// requestBrowserAccess not found, returning with no-op
return;
return await chromium_importer.requestBrowserAccess(browser, isMacAppStore());
});
ipcMain.handle("chromium_importer.getAvailableProfiles", async (event, browser: string) => {

24
apps/desktop/src/app/tools/import/import-desktop.component.html
View File

@@ -1,21 +1,13 @@
<bit-dialog #dialog dialogSize="large" background="alt">
<bit-dialog #dialog [loading]="loading" dialogSize="large" background="alt">
<span bitDialogTitle>{{ "import" | i18n }}</span>
<ng-container bitDialogContent>
<div class="tw-relative">
<tools-import
(formLoading)="this.loading = $event"
(formDisabled)="this.disabled = $event"
(onSuccessfulImport)="this.onSuccessfulImport($event)"
[onImportFromBrowser]="this.onImportFromBrowser"
[onLoadProfilesFromBrowser]="this.onLoadProfilesFromBrowser"
[class.tw-invisible]="loading"
></tools-import>
@if (loading) {
<div class="tw-absolute tw-inset-0 tw-flex tw-items-center tw-justify-center">
<bit-spinner></bit-spinner>
</div>
}
</div>
<tools-import
(formLoading)="this.loading = $event"
(formDisabled)="this.disabled = $event"
(onSuccessfulImport)="this.onSuccessfulImport($event)"
[onImportFromBrowser]="this.onImportFromBrowser"
[onLoadProfilesFromBrowser]="this.onLoadProfilesFromBrowser"
></tools-import>
</ng-container>
<ng-container bitDialogFooter>
<button

9
apps/desktop/src/app/tools/import/import-desktop.component.ts
View File

@@ -3,13 +3,7 @@ import { Component } from "@angular/core";
import { JslibModule } from "@bitwarden/angular/jslib.module";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
import {
DialogRef,
AsyncActionsModule,
ButtonModule,
DialogModule,
SpinnerComponent,
} from "@bitwarden/components";
import { DialogRef, AsyncActionsModule, ButtonModule, DialogModule } from "@bitwarden/components";
import type { chromium_importer } from "@bitwarden/desktop-napi";
import { ImportMetadataServiceAbstraction } from "@bitwarden/importer-core";
import {
@@ -32,7 +26,6 @@ import { DesktopImportMetadataService } from "./desktop-import-metadata.service"
AsyncActionsModule,
ButtonModule,
ImportComponent,
SpinnerComponent,
],
providers: [
...ImporterProviders,