bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 07:43:35 +00:00
Code Issues Releases Wiki Activity

[PM-4678] [Defect] Passkey browser fallback broken on iCloud (#6783)

Browse Source 
* [PM-4678] fix: add cross-origin frame handling

* [PM-4678] feat: force window and tab focus
This commit is contained in:
Andreas Coroiu
2023-11-06 17:14:48 +01:00
committed by GitHub
parent 200189c895
commit ffd08a6d6d
2 changed files with 38 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
apps/browser/src/background/runtime.background.ts
View File

@@ -312,12 +312,36 @@ export default class RuntimeBackground {
case "checkFido2FeatureEnabled":
return await this.main.fido2ClientService.isFido2FeatureEnabled();
case "fido2RegisterCredentialRequest":
return await this.abortManager.runWithAbortController(msg.requestId, (abortController) =>
this.main.fido2ClientService.createCredential(msg.data, sender.tab, abortController)
return await this.abortManager.runWithAbortController(
msg.requestId,
async (abortController) => {
try {
return await this.main.fido2ClientService.createCredential(
msg.data,
sender.tab,
abortController
);
} finally {
await BrowserApi.focusTab(sender.tab.id);
await BrowserApi.focusWindow(sender.tab.windowId);
}
}
);
case "fido2GetCredentialRequest":
return await this.abortManager.runWithAbortController(msg.requestId, (abortController) =>
this.main.fido2ClientService.assertCredential(msg.data, sender.tab, abortController)
return await this.abortManager.runWithAbortController(
msg.requestId,
async (abortController) => {
try {
return await this.main.fido2ClientService.assertCredential(
msg.data,
sender.tab,
abortController
);
} finally {
await BrowserApi.focusTab(sender.tab.id);
await BrowserApi.focusWindow(sender.tab.windowId);
}
}
);
}
}