1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-04 02:33:33 +00:00
Commit Graph

5640 Commits

Author SHA1 Message Date
Hinton
27ca2037aa Merge branch 'chromium-import-abe' into chromium-conflicts 2025-10-28 14:12:13 +01:00
Hinton
85c21c9e0c Merge branch 'main' of github.com:bitwarden/clients into chromium-import-abe
# Conflicts:
#	apps/desktop/desktop_native/Cargo.lock
#	apps/desktop/desktop_native/bitwarden_chromium_importer/src/lib.rs
#	apps/desktop/desktop_native/chromium_importer/Cargo.toml
#	apps/desktop/desktop_native/chromium_importer/README.md
#	apps/desktop/desktop_native/chromium_importer/src/chromium/platform/abe.rs
#	apps/desktop/desktop_native/chromium_importer/src/chromium/platform/abe_config.rs
#	apps/desktop/desktop_native/chromium_importer/src/chromium/platform/bin/bitwarden_chromium_import_helper.rs
2025-10-28 14:10:57 +01:00
Dmitry Yakimenko
c619b2607d Don't loop forever, but retry a few times 2025-10-28 13:42:21 +01:00
Dmitry Yakimenko
db39bb1dcc Address PR change requests. Mainly small cleanup and renaming. 2025-10-28 13:29:05 +01:00
Dmitry Yakimenko
3e26ace418 Remove sensitive info from debug! and wrap debug! in a new macro that is controlled by a compile time const to make sure nothing sensitive is dumped in release 2025-10-25 23:43:56 +02:00
Dmitry Yakimenko
b6fec3b17e Fix and remove some TODOs 2025-10-25 23:14:51 +02:00
Dmitry Yakimenko
129531a320 Disable logging, oops... 2025-10-25 19:35:45 +02:00
Dmitry Yakimenko
6fddb44dc2 Fix clippy warnings 2025-10-25 19:34:14 +02:00
Dmitry Yakimenko
953468268a Remove configure_windows_crypto_service 2025-10-25 19:26:59 +02:00
Dmitry Yakimenko
889e02543c Add bitwarden_chromium_import_helper.exe to the electron build scripts 2025-10-25 18:13:45 +02:00
Dmitry Yakimenko
ca21df5f8e Rename admin.exe to bitwarden_chromium_import_helper.exe 2025-10-25 18:11:31 +02:00
Dmitry Yakimenko
b9ca1ae57d Rework SYSTEM process discovery to use sysinfo, iterate through multiple processes 2025-10-25 17:52:10 +02:00
Dmitry Yakimenko
20b6c5a680 Look for admin.exe in runtime, don't need to confiture windows crypto service anymore 2025-10-24 22:54:10 +02:00
Dmitry Yakimenko
4968cae17a Fix admin.exe to run again, some tokio weirdness 2025-10-24 22:53:01 +02:00
Dmitry Yakimenko
535c21a0e5 Use services.exe instead of lsass.exe and winlogon.exe to elevate to SYSTEM 2025-10-23 22:16:30 +02:00
adudek-bw
a730cfe3ca Merge branch 'main' into chromium-import-abe 2025-10-23 08:51:22 -04:00
Bernd Schoolmann
7f86f2d0ac [PM-26340] Implement encrypted memory store (#16659)
* Extract windows biometrics v2 changes

Co-authored-by: Bernd Schoolmann <mail@quexten.com>

* Address some code review feedback

* cargo fmt

* rely on zeroizing allocator

* Handle TDE edge cases

* Update windows default

* Make windows rust code async and fix restoring focus freezes

* fix formatting

* cleanup native logging

* Add unit test coverage

* Add missing logic to edge case for PIN disable.

* Address code review feedback

* fix test

* code review changes

* fix clippy warning

* Swap to unimplemented on each method

* Implement encrypted memory store

* Make dpapi secure key container pub(super)

* Add comments on sync and send

* Clean up comments

* Clean up

* Fix build

* Add logging and update codeowners

* Run cargo fmt

* Clean up doc

* fix unit tests

* Update apps/desktop/desktop_native/core/src/secure_memory/secure_key/mod.rs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Handle tampering with re-key and log

* Add docs

* Fix windows build

* Prevent rust flycheck log from being commited to git

* Undo feature flag change

* Add env var override and docs

* Add deps to km owership

---------

Co-authored-by: Thomas Avery <tavery@bitwarden.com>
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2025-10-23 14:04:25 +02:00
Bernd Schoolmann
7e7107f165 [PM-27221] Update legacy kdf state on master password unlock sync (#16966)
* Update legacy kdf state on master password unlock sync

* Fix cli build

* Fix

* Fix build

* Fix cli

* Fix browser
2025-10-23 11:38:10 +02:00
Oscar Hinton
29dccd6352 Auth - Prefer signal & change detection (#16950) 2025-10-22 21:28:47 -04:00
Nik Gilmore
740fe0787f [PM-26974] Add reprompt check when deleting ciphers in browser extension (#16907)
* Add reprompt check when deleting ciphers in browser extension

* RE-use existing remprompt check function.
2025-10-22 16:18:53 -07:00
Kyle Denney
7804aa118c [PM-27206] fix: redirect from premium page if user has premium (#16990) 2025-10-22 17:45:51 -05:00
Brandon Treston
67ba1b83ea [PM-26369] [PM-26362] Implement Auto Confirm Policy and Multi Step Dialog Workflow (#16831)
* implement multi step dialog for auto confirm

* wip

* implement extension messgae for auto confirm

* expand layout logic for header and footer, implement function to open extension

* add back missing test

* refactor test

* clean up

* clean up

* clean up

* fix policy step increment

* clean up

* Ac/pm 26369 add auto confirm policy to client domain models (#16830)

* refactor BasePoliicyEditDefinition

* fix circular dep

* wip

* wip

* fix policy submission and refreshing

* add svg, copy, and finish layout

* clean up

* cleanup

* cleanup, fix SVG

* design review changes

* fix copy

* fix padding

* address organization plan feature FIXME

* fix test

* remove placeholder URL

* prevent duplicate messages
2025-10-22 16:11:33 -04:00
Oscar Hinton
2147f74ae8 Autofill - Prefer signal & change detection (#16943) 2025-10-22 22:06:05 +02:00
Maciej Zieniuk
8154613462 [PM-23995] Updated change kdf component for Forced update KDF settings (#16516)
* move change-kdf into KM ownership

* Change kdf component update for Forced KDF update

* correct validators load on init

* incorrect feature flag observable check

* unit test coverage

* unit test coverage

* remove Close button, wrong icon

* change to `pm-23995-no-logout-on-kdf-change` feature flag

* updated unit tests

* revert bad merge

Signed-off-by: Maciej Zieniuk <mzieniuk@bitwarden.com>

* updated wording, TS strict enabled, use form controls, updated tests

* use localisation for button label

* small margin in confirmation dialog

* simpler I18nService mock

---------

Signed-off-by: Maciej Zieniuk <mzieniuk@bitwarden.com>
2025-10-22 20:29:36 +02:00
adudek-bw
a301b93ed7 Merge branch 'main' into chromium-import-abe 2025-10-22 13:13:53 -04:00
Jason Ng
0340a881ae [PM-20040] all tasks complete banner (#16033)
* saved WIP

* created at risk password callout service to hold state for callout data. wip

* update at-risk-password-callout to use states for tracking showing and dismissing success banner

* adding spec file for new serive

* update styles to match figma

* minor wording changes

* fix undefined lint error in at risk password callout

* moved service to libs

* added another route guard so when user clears all at risk items they are directed back to the vault page

* small cleanup in at risk callout component and at risk pw guard

* clean up code in at risk password callout component

* update state to memory

* refactor for readability at risk password callout component

* move state update logic from component to at risk password callout service

* fix: bypass router cache on back() in popout

* Revert "fix: bypass router cache on back() in popout"

This reverts commit 23f9312434.

* refactor updatePendingTasksState call

* refactor at risk password callout component and service. remove signals, implement logic through observables. Completed value for tasks utilized.

* clean up completedTasks in at risk password callout service

* add updated state value to prevent banner among diff clients

* move hasInteracted call to page component to avoid looping

* remove excess call in service

* update icon null logic in banner component

* update the callout to use a new banner

* fix classes

* updating banners in at risk password callout component

* anchor tag

* move at-risk callout to above nudges

* update `showCompletedTasksBanner$` variable naming

---------

Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
Co-authored-by: Nick Krantz <nick@livefront.com>
2025-10-22 11:37:58 -05:00
Nick Krantz
2179cb6848 prompt for master password first before confirming archive (#16892) 2025-10-22 08:43:03 -05:00
Nick Krantz
7418f67874 [PM-24929] Clear route history cache for add/edit cipher views on tab change (#16755)
* clear route history cache for add/edit cipher views on tab change

* remove duplicate words
2025-10-22 08:36:31 -05:00
Dmitry Yakimenko
7c35a363f4 A bunch of clippy warnings fixed on Windows 2025-10-22 13:51:08 +02:00
Dmitry Yakimenko
7b692f0e57 Move all admin.exe code into an inline module and hide it behind cfg windows to fix clippy warning 2025-10-22 13:07:13 +02:00
Addison Beck
453feb362f build(nx): fix serve browser (#16972) 2025-10-22 06:21:25 -04:00
Dmitry Yakimenko
76ac318bcb Remove unnecessary clippy config attr and stale comments 2025-10-22 11:08:38 +02:00
Dmitry Yakimenko
60b08dbf1b Merge remote-tracking branch 'upstream/main' into chromium-import-abe 2025-10-21 23:09:13 +02:00
Alex Morask
5b2682ff21 [PM-26356] Remove client-side pre-consolidated billing code (#16707)
* Remove legacy provider files

* Removing index files to make file re-org easier

* Move manage-clients.component and associated API invocation to AC

* Move add-existing-organization-dialog.component to AC

* Move manage-client-name-dialog.component and associated API call to AC

* Move misc clients files to AC

* Move create-client-dialog.component and associated API call to AC

* Move manage-client-subscription-dialog.component to AC

* Update provider-layout.component

* Cleanup

* Fix linting
2025-10-21 14:15:29 -05:00
Maciej Zieniuk
63cdae92be [PM-2348] Close popup window before process reload (#16795)
* Close popup window before process reload

* unit test coverage
2025-10-21 19:06:55 +02:00
Oscar Hinton
65da23feaa UIF - Prefer signal & change detection (#16940) 2025-10-21 18:52:40 +02:00
Kyle Denney
1794803deb [PM-24032] upgrade nav button updates (#16933)
* [PM-24032] upgrade nav button post-upgrade action

* fixing broken stories

* added component tests

* new behavior for the nav button when self hosted

* fix stories
2025-10-21 11:18:15 -05:00
Bernd Schoolmann
5a307633bb [PM-26778] Make VaultTimeoutService use LogoutService (#16820)
* Make vaulttimeoutservice use logoutservice

* Fix browser build

* Fix mv3 build

* Fix lint
2025-10-21 10:24:52 -05:00
Alex
a5dd42396c [PM-27024] password progress card at risk detection (#16955)
* [PM-27024] Fix password change progress card to track only critical apps and detect new at-risk passwords
- Filter at-risk password count to critical applications only
- Update state logic to transition back to assign tasks when new at-risk passwords detected
- Only create security tasks for critical applications with at-risk passwords
- Show 'X new passwords at-risk' message when tasks exist and new at-risk passwords appear

* spec
2025-10-21 08:02:44 -07:00
cyprain-okeke
f1340c67da [PM-27050] Fix : Cannot upload self-hosted license on new Premium page (#16919)
* Fix the isselfhost bug

* Resolve the self-host issue
2025-10-21 15:46:15 +01:00
neuronull
4c347d09ac Fix biometric v2 windows unit test clippy lint (#16961) 2025-10-21 08:22:09 -06:00
Oscar Hinton
f23f3f87bd Tools - Prefer signal & change detection (#16941) 2025-10-21 15:49:22 +02:00
Oscar Hinton
6abaaa7b13 KM - Prefer signal & change detection (#16945) 2025-10-21 15:49:05 +02:00
adudek-bw
8c2493a3cc String fix 2025-10-21 09:48:41 -04:00
Oscar Hinton
532546ea7d Autofill - Prefer signal & change detection (#16942) 2025-10-21 15:48:31 +02:00
neuronull
8370f43aae [BEEEP] Add println clippy lints for desktop_native. (#16761)
* [BEEEP] Add println clippy lints for `desktop_native`.

* remaining stray printlns
2025-10-21 07:38:39 -06:00
adudek-bw
2bb00b93ec Clippy fix 2025-10-21 09:22:39 -04:00
Jeffrey Holland
a15d6867f9 Prefer autofilling login forms over registration forms (#16811) 2025-10-21 10:35:05 +02:00
Daniel James Smith
bbfdb60c34 [PM-26731] Add feature flag for chromium importers with ABE (#16926)
* Add missing browser to SUPPORTED_BROWSERS in windows.rs

These were previously removed due to needing ABE support

* Add feature flag for chromium importer with ABE

* Fix tests for windows

* Run cargo fmt

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-10-21 10:10:47 +02:00
Dmitry Yakimenko
7477c61f00 Disable one clippy warning on Linux/macOS as it makes no sense on these platforms 2025-10-21 09:13:12 +02:00