1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-10 13:40:06 +00:00
Commit Graph

4230 Commits

Author SHA1 Message Date
Zihad
00a150a91a [PM-18413] Fix SSH agent initial prompt issues (#13468)
* fix: set `needs_unlock` default value to true on unix

closes #13323

* fix: ssh prompt not appearing right after unlocking vault

---------

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Colton Hurst <colton@coltonhurst.com>
(cherry picked from commit 0c61a44d33)
2025-03-03 14:29:06 -05:00
Jared Snider
cbbb7b453b fix(LoginComp + LoginStrategies): [Auth/PM-18654] Refreshed UI - Desktop TDE JIT provisioned user creation errors with missing org SSO id (#13619)
* PM-18654 - State Service & Login Strategy Refactor - move env seeding into login strategy so that new accounts always load w/ the correct environment

* PM-18654 - SSO Comp - just use user id from auth result

* PM-18654 - Config Service - (1) don't allow cascading calls to the renewConfig by using a private promise (2) Replace shareReplay with share configured with manual timer

* PM-18654 - LoginComponents - detail issue and possible fix

* PM-18654 - DesktopLoginV1Comp - use correct destroy hook

* PM-18654 - LoginComp - clean up no longer correct comment

* PM-18654 - New Device Verification Component - Remove unused PasswordLoginStrategy dependency

* PM-18654 - Browser Home Component - fix qParam logic

* PM-18654 - DefaultConfigService - revert changes as they aren't necessary to fix the bug.

* PM-18654 - DefaultConfigService - remove commented code

* PM-18654 - LoginStrategy - add comment

* PM-18654 - Fix login strat tests
2025-03-03 12:12:01 -05:00
Todd Martin
6a112d240f [PM-18617] Revert Firefox back to build Mv2 (#13620)
* Revert changes to build Mv3 on Firefox.

* Revert script changes.

(cherry picked from commit a4ff5436bf)
2025-02-28 10:20:06 -05:00
Maciej Zieniuk
5e81dc4446 [PM-18680] biometric's no client key half provided for user (#13609)
* biometric's no client key half provided for user

Biometric's client key half can be optional (null) when the password is not required on start of the application

* improved unit test coverage

* ipc setClientKeyHalf can be null

(cherry picked from commit c80019e919)
2025-02-28 13:07:22 +00:00
Daniel James Smith
d91514a81d Added permission check for organizational unsecure website (#13611)
Only display the cipher's name if the user running the report does not have permissions to view/edit the cipher

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
(cherry picked from commit eaeea195e4)
2025-02-27 20:57:48 +01:00
Daniel James Smith
04e82f0b13 [PM-18706] Added permission check for organizational inactive 2fa report (#13610)
* Added permission check for organizational inactive 2fa report

Only display the cipher's name if the user running the report does not have permissions to view/edit the cipher

* Add appropiate access modifiers to newly added members/methods

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
(cherry picked from commit 407368b3ea)
2025-02-27 20:57:41 +01:00
Todd Martin
beebc1b83b Remove checks of device verification flags on client (#13604)
(cherry picked from commit 319a4dd1cc)
2025-02-27 13:23:47 -05:00
Jared Snider
5cdaf695d3 Auth/PM-5712 - Extension & Desktop Account Switcher - Fix incorrect env showing when adding new accounts (#13362)
* PM-5712 - Refactor env service to require user id instead of having global and active user state fallbacks per working session with Justin.

* PM-5712 - AccountSwitcherService tests - fix tests and add env assertions.

(cherry picked from commit 44d50a70c2)
2025-02-25 17:59:24 -05:00
José Pereira
22ec9ff5de [PM-10105] Release arm64 binaries for macOS (#10273)
* ci(mac): add step to build and release macos arm64 binary

* ci(mac): add step to build and release macos arm64 binary

* fix: add target_suffix to build & package command

(cherry picked from commit 76fb5d46bb)
2025-02-25 16:55:48 -05:00
Ike
a01ba8c568 feat(newDeviceVerification) : add handling for requires new device verification auth response (#13568)
(cherry picked from commit e9f23cd4c3)
2025-02-25 14:49:04 -05:00
Todd Martin
3747ece8e4 [PM-18549] Do not clear route or view persistence on tab change (#13523)
* Do not clear route or view persistence on tab change

* Renamed method

(cherry picked from commit acdcf69722)
2025-02-24 10:46:43 -05:00
Github Actions
df9ce88398 Bumped client version(s) 2025-02-24 12:35:43 +00:00
Github Actions
155368a783 Bumped client version(s) 2025-02-24 12:34:46 +00:00
bw-ghapp[bot]
5f390e6151 Autosync the updated translations (#13531)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-02-24 09:05:17 +00:00
Jared Snider
c4a230e80b PM-9417 - PasswordStrengthComp - A11y improvement - add screen reader announcement for all usages of password strength. (#13515) 2025-02-24 09:55:18 +01:00
bw-ghapp[bot]
99e2b9e394 Autosync the updated translations (#13530)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-02-24 09:38:45 +01:00
bw-ghapp[bot]
e570be0505 Autosync the updated translations (#13532)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-02-24 09:14:29 +01:00
Jonas Hendrickx
fb191b1121 [PM-17223] Update comma to period after "Invalid input provided" text (#13455) 2025-02-22 07:51:15 +01:00
Justin Baur
f1af23dc1f Fix Vault Loading (#13484) 2025-02-21 19:01:49 -05:00
✨ Audrey ✨
b4bfacf6e3 [PM-16792] [PM-16822] Encapsulate encryptor and state provision within UserStateSubject (#13195) 2025-02-21 17:00:51 -06:00
Todd Martin
077e0f89cc [PM-17751] Store SSO email in state on web client (#13295)
* Moved saving of SSO email outside of browser/desktop code

* Clarified comments.

* Tests

* Refactored login component services to manage state

* Fixed input on login component

* Fixed tests

* Linting

* Moved web setting in state into web override

* updated tests

* Fixed typing.

* Fixed type safety issues.

* Added comments and renamed for clarity.

* Removed method parameters that weren't used

* Added clarifying comments

* Added more comments.

* Removed test that is not necessary on base

* Test cleanup

* More comments.

* Linting

* Fixed test.

* Fixed base URL

* Fixed typechecking.

* Type checking

* Moved setting of email state to default service

* Added comments.

* Consolidated SSO URL formatting

* Updated comment

* Fixed reference.

* Fixed missing parameter.

* Initialized service.

* Added comments

* Added initialization of new service

* Made email optional due to CLI.

* Fixed comment on handleSsoClick.

* Added SSO email persistence to v1 component.

---------

Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2025-02-21 17:09:50 -05:00
Maciej Zieniuk
78202e14ae [PM-15882] Remove unlock with PIN policy (#13352)
* Remove policy with PIN in Web Vault

* Remove policy with PIN in Browser Extension

* Remove policy with PIN in Desktop

* Remove policy with PIN in Desktop

* unit tests coverage

* unit tests coverage

* unit tests coverage

* private access method error

* private access method error

* private access method error

* PM-18498: Unlock Options Padding Off When PIN Is Removed

* PM-18498: Unlock Options Padding Off When PIN Is Removed
2025-02-21 22:16:13 +01:00
cyprain-okeke
92ec2ca85e [PM-17591]Remove feature flag "Refactor self hosting license uploader" (#13330)
* Remove the Refactor self hosting license uploader flag

* Remove the changes when is flag is off
2025-02-21 21:36:57 +01:00
Jimmy Vo
f345992f80 [PM-17449] Enable managed users to update their email addresses. (#13495) 2025-02-21 15:15:06 -05:00
Jonathan Prusik
2e96405f15 [PM-18219] Normalize blocked domain checks to a common util (#13416)
* normalize blocked domain checks to common util

* do not use currentTabIsOnBlocklist$ in showCurrentTabIsBlockedBanner$ resolution

* update additional vault popup autofill service cases to use isUrlInList

* cleanup and use Utils get hostname instead of tldts directly
2025-02-21 13:15:02 -05:00
Jordan Aasen
0bc7813b1c [PM-18132] - Update the Appearance settings page to include click to fill setting (#13460)
* Update the Appearance settings page to include click to fill setting

* fix tests

* fix tests

* add tests

* new customization options callout

* use classes instead of inline styling

* revert changes to index and tw-theme

* remove shared module

* Revert "remove shared module"

This reverts commit 0b68aaae23.

* Revert "revert changes to index and tw-theme"

This reverts commit 4a05f0ca20.

* Revert "use classes instead of inline styling"

This reverts commit 0e441c4284.

* Revert "new customization options callout"

This reverts commit f3054c9b27.

* remove unused code

* disable margin on autofill suggestion
2025-02-21 08:57:06 -08:00
renovate[bot]
413f638b9d [deps] Autofill: Update tldts to v6.1.77 (#13226)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-02-21 11:24:25 -05:00
Oscar Hinton
9228df4e28 Remove unused CSS from browser (#13453)
Cleanup browser CSS by removing unused rules. There are probably more unused CSS rules but it's not trivial to audit and we will probably remove them as part of the auth redesign.
2025-02-21 16:56:05 +01:00
tangowithfoxtrot
b86e587507 Fix falling back to data.json when keyring is available (#12760)
* fix: fallback to data.json on Linux

* fix: make keyring prompt more consistent for reads+writes, but less assertive when we delete credentials

* fix: explicitly ignore unused return value
2025-02-21 07:44:24 -08:00
Oscar Hinton
1587f84a5c [PM-17494] Minimum effort removal of bootstrap from filters (#12995)
Minimum effort migration of the filters to not depend on bootstrap. This migrates the card to tailwind but keeps most of the custom css as it's not strictly required to be migrated.
2025-02-21 08:52:01 -05:00
cd-bitwarden
1d04227884 [PM-12985] - Updating reports to use new modal for view/edit cipher (#12383)
* Updating reports to use new modal for view/edit cipher

* updating the location of the DefaultCipherFormCOnfigService

* Test fixes

* test fixes

* Adding back useful code and trying to fix inactive-two-factor-report.component.spec.ts issue

* suggested changes

* trying to fix tests

* test fix

* fixing reports

* Fix import path

* Remove unnecessary change

* Revert "Remove unnecessary change"

This reverts commit 9a19dc99ed.

* PM-16995- Provide missing CipherFormConfigService

* after merge fixes

* more fixes

* WIP

* wip: fix for exposed passwords

* WIP

* fixing tests

* removing uneeded change

* lint fixes

* lint fix

* fixing admin console permissions

* merge fix

---------

Co-authored-by: --global <>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
2025-02-21 14:45:30 +01:00
bw-ghapp[bot]
05f25f305c Autosync the updated translations (#13501)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-02-21 14:05:38 +01:00
bw-ghapp[bot]
fd3cc90df8 Autosync the updated translations (#13500)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-02-21 14:02:03 +01:00
bw-ghapp[bot]
f0ce87708c Autosync the updated translations (#13502)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-02-21 08:56:55 +01:00
Jonathan Prusik
a19c860a14 [PM-18287] Bugfix - Vault autofill suggestions view hangs on load when the current tab is on the blocked domains list (#13496)
* Fix vault autofill suggestions view hanging on load when the current tab is on the blocked domains list

Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com>

* fix broken tests

* use blockedInteractionsUris$ observable instead of currentTabIsOnBlocklist$ in _currentPageDetails$

---------

Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com>
2025-02-20 18:44:18 -05:00
Jordan Aasen
63927d6ba1 [PM-17094] - Vault and Collection filters pop in after Vault content causing content to shift (#13165)
* add loading state service for vault list filters and apply to vault

* remove call to delay and requestAnimationFrame

* use shareReplay

* update loading state to also check for filters

* remove reassignment

* add sharereplay to vault list filters.
2025-02-20 14:18:43 -08:00
Patrick-Pimentel-Bitwarden
598139d739 fix(recovery-code-login): [PM-18474] Fix for Recovery Code Login (#13497)
* fix(recovery-code-login): [PM-18474] Fix for Recovery Code Login - Fixed the recovery code login to work with the new device verification notice flow.

* test(recovery-code-login): [PM-18474] Fix for Recovery Code Login - Tests added.
2025-02-20 16:45:19 -05:00
Vicki League
657902cdcc [CL-349] Allow @apply styles to be used in CL css (#13414) 2025-02-20 12:56:22 -05:00
Maciej Zieniuk
3924bc9c84 [PM-14445] TS strict for Key Management, Keys and Lock component (#13121)
* PM-14445: TS strict for Key Management Biometrics

* formatting

* callbacks not null expectations

* state nullability expectations updates

* unit tests fix

* secure channel naming, explicit null check on messageId

* KM-14445: TS strict for Key Management, Keys and Lock component

* conflicts resolution, new strict check failures

* null simplifications

* migrate legacy encryption when no active user throw error instead of hiding it

* throw instead of return
2025-02-20 18:45:37 +01:00
albertboyd5
ca41ecba29 [PM-16171] Simplelogin alias generation only generate random words instead the domain name (#13024)
* Exposes URI property from the cipher form.
* Updates credential generator to accept the URI using a `website` attribute

---------

Co-authored-by:  Audrey  <audrey@audreyality.com>
2025-02-20 11:33:40 -05:00
nickcan0120
d5764a2b5e [PM-17913] fix: zh-TW registerLocaleData missing extra error (#13210)
* fix: zh-TW registerLocaleData missing extra error

* Delete the code before adjustment

Modify naming method
2025-02-20 17:32:12 +01:00
Daniel Riera
2fef775bee pm-18084 Connect new notification bar experience buttons (#13339)
* pm-18084 -initial structure and functions implemented

* update stories to match new args

* change handleSave name

* include new login button for save

* fix stories
2025-02-20 10:23:04 -05:00
Patrick-Pimentel-Bitwarden
4a344582a9 fix(recovery-code-login): [PM-15534] Fix for Recovery Code Login - Fixed the recovery code login flow. (#13488) 2025-02-20 08:47:51 -05:00
Jordan Aasen
1fdb88da63 add missing i18n keys (#13489)
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-02-20 09:51:29 +00:00
Oscar Hinton
aa2b0a9fe8 Add a copy button to browser ext about dialog (#13465)
Add a copy button to browser extension about dialog for quickly copying the version number now that we have 3 different values we'd like to collect.
2025-02-20 09:48:31 +01:00
Thomas Rittson
2425cda4d7 [PM-18356] Reconcile ownership of import export and reporting (#13439)
* Move AC import, export and reporting to Tools ownership
2025-02-20 12:06:43 +10:00
Shane Melton
1bcfcc7dec [PM-17656] Update the org vault filter whenever policies update (#13280) 2025-02-19 16:14:43 -08:00
Miles Blackwood
33e1a6e917 [PM-17819] Replicate ReactiveForms and bit-* component changes to Blocked Domains from Excluded Domains update [PM-13808]. (#13180) 2025-02-19 17:17:00 -05:00
Miles Blackwood
23ef1b1688 PM-13808 - Use new <bit-form-field> component in Excluded domains settings. (#13111)
* Use new <bit-form-field> component in Excluded domains settings.

Changing to new <bit-form-field> component necessitates modifying form to use ReactiveForms conventions. To handle this change, the deletable/uneditable domain state and new form control state are managed separately, including clearing the form state on save. Fields which compute vaules from the former state should now compute both values (see domain count); [formGroup], formArrayName, formControlName all necessary directives/properties on form and children.

* Disables margin; Removes OnInit in favor of protected member (fixes lint, and type checks).

* Ensure excludedDomain-based IDs are offset by the fieldsEditThreshold for form controls existing outside of stored values.

* Remove unnecessary chaining.
2025-02-19 17:11:40 -05:00
Miles Blackwood
3997a75741 Add learnMoreAboutBlockedDomains translation key and append to desc. (#13358)
* Add learnMoreAboutBlockedDomains translation key and append to desc.

* Update apps/browser/src/autofill/popup/settings/blocked-domains.component.html

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

* Prettier lint fix anchor multiple lines.

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
2025-02-19 17:07:47 -05:00