1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-24 04:04:24 +00:00
Commit Graph

1442 Commits

Author SHA1 Message Date
Oscar Hinton
8f74eaea1c Remove standalone true from auth (#15035)
Remove standalone: true from every instance since it's the default as of Angular 19.
2025-06-04 09:22:37 -04:00
Maciej Zieniuk
ce3ce17010 [PM-21147] User key transferred over ipc within desktop app without its prototype (#15047)
* user key transferred over ipc within desktop app without its prototype.

`UserKey` object was transferred over IPC as regular `Object` type and not recreated as `SymmetricCryptoKey` type, losing its original functions and properties. As a result `inner` method did not exist and user key silently failed during decryption of encrypted client key halves during biometric unlock.

* ipc biometrics serializable user key type

* use encrypt service directly for decryption

* moving electron key service to KM

* log error when unlock via biometrics fails with exception in lock component

* bring back tech debt comment

* lock component logging prefix
2025-06-03 22:12:11 +02:00
Oscar Hinton
95856bf3cf [CL-714] Remove standalone true from tools (#15039)
Remove standalone: true from every instance since it's the default as of Angular 19.
2025-06-03 09:55:58 +02:00
Bernd Schoolmann
23ec6bacc9 [PM-20225] Prevent legacy users without userkey from logging in (#14267)
* Prevent legacy users without userkey from logging in

* Remove further web-migration code for legacy users

* Add i18n for legacy user error message

* Update comment

* Remove migrate legacy component

* Remove i18n messages

* Remove migrate legacy encryption reference
2025-06-02 23:56:29 +02:00
Addison Beck
26caeb3083 Implement and extend tsconfig.base across projects (#14554)
* Implement and extend tsconfig.base across projects

* fixup! Merge remote-tracking branch 'origin/main' into rename-tsconfig

* fix: import tsconfig.base from components

* fix: skip typechecking node modules

* fixing tests

* fix the tests for real

* undo accidentally change
2025-06-02 20:38:17 +00:00
Oscar Hinton
f3ff1e98ec Remove standalone true from vault (#15040)
Remove standalone: true from every instance since it's the default as of Angular 19.
2025-06-02 13:22:57 -07:00
Oscar Hinton
26fb7effd3 Remove standalone true from platform and UIF (#15032)
Remove standalone: true from every instance since it's the default as of Angular 19.
2025-06-02 20:03:04 +02:00
Oscar Hinton
2fbc4c1578 [CL-525] Upgrade angular to v19 (#14815)
Upgrade Angular to v19 using the update guide.

- Add `standalone: false` to any missed component in stories or tests.
- Update jest.config to follow the new best practices.
2025-06-02 13:13:31 -04:00
bw-ghapp[bot]
960f6938f4 Autosync the updated translations (#15024)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-06-02 08:59:32 +00:00
bw-ghapp[bot]
da9aa07e4b Autosync the updated translations (#14996)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-05-30 10:08:28 +02:00
Daniel James Smith
0f6d4a92d7 Migrate libs/tools/card to be owned by DIRT (#14987)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-05-30 07:37:08 +00:00
Github Actions
bb9006e6e4 Bumped Desktop client to 2025.5.1 2025-05-29 19:15:34 +00:00
Bernd Schoolmann
8966b4fb50 Fix flatpak autostart disabling (#14920) 2025-05-29 20:48:03 +02:00
Bernd Schoolmann
798acc7cba [PM-21884] Fix DuckDuckGo integration when SDK is enabled for decrypt (#14884)
* Fix ddg integration when sdk is enabled for decryption

* Fix comments
2025-05-29 15:17:04 +02:00
renovate[bot]
4bf1a3b670 [deps] Platform: Update Rust crate bytes to v1.10.1 (#14922)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-28 07:16:46 -07:00
Jordan Aasen
677a435cad prevent showing ssh key when cipher changes in desktop view (#14913) 2025-05-27 10:05:58 -07:00
✨ Audrey ✨
97a591e738 [PM-16793] port credential generator service to providers (#14071)
* introduce extension service
* deprecate legacy forwarder types
* eliminate repeat algorithm emissions
* extend logging to preference management
* align forwarder ids with vendor ids
* fix duplicate policy emissions; debugging required logger enhancements

-----

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-05-27 09:51:14 -04:00
Oscar Hinton
745ab21946 Remove unused imports in browser and desktop (#14875)
Removes unused imports from browser and desktop. These were missed in #14795.
2025-05-26 08:38:02 -04:00
Bernd Schoolmann
04ed114e0e [BEEEP/PM-8492] Add autostart for flatpak (#12016)
* Add autostart for flatpak via ashpd

* Fix clippy errors

* Cargo fmt

* Fix clippy
2025-05-26 00:30:52 +02:00
Nick Krantz
217014a30e add nudge related translations to desktop and web message files (#14905) 2025-05-23 13:30:07 -05:00
Addison Beck
56a3b14583 Introduce eslint errors for risky/circular imports (#14804)
* first draft at an idea dependency graph

* ignore existing errors

* remove conflicting rule regarding internal platform logic in libs

* review: allow components to import from platform
2025-05-23 08:01:25 -04:00
bw-ghapp[bot]
eb3e14b022 Autosync the updated translations (#14891)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-05-23 12:29:05 +02:00
Thomas Avery
bd29397fd8 [PM-21611] Require userId on KeyService clear methods (#14788) 2025-05-22 13:55:26 -05:00
Jordan Aasen
57911f210b [PM-21896] - prevent double reprompt for copy password in desktop cipher form (#14883)
* prevent double reprompt for copy password in desktop cipher form

* adjust name

* fix input name
2025-05-22 10:20:33 -07:00
Nick Krantz
f52e4e27a0 [PM-12770] Assign to Collections Hint (#14529)
* allow use of common spec in lib/vault tests

* pass readonly collections to the assign collection component

- The assign to collections component filters them out already.
-They're also needed to display copy within the component

* add hint to assign to collections component when there are read only collections assigned to a cipher already

* add readonly hint to desktop

* only show collection hint for collections that are assigned to the provided ciphers

* consider admin/owner edit everything permission when assigning to collections

* fix icon in test
2025-05-22 11:09:33 -05:00
renovate[bot]
2e4b310137 [deps] Platform: Pin dependencies (#14446)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-21 11:04:35 +02:00
renovate[bot]
bc56bc8e37 [deps]: Lock file maintenance (#13866)
* [deps]: Lock file maintenance

* add override for parse5 version to 7.2.1 (7.3.0 has breaking ts changes)

* manual rebuild of package-lock

* fix test event listeners persistence

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Prusik <jprusik@classynemesis.com>
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2025-05-21 09:29:14 +02:00
Bernd Schoolmann
d93f547cfb [PM-21001] Move platform code to new encrypt service interface (#14544)
* Move platform code to new encrypt service interface

* Fix tests

* Fix tests

* Fix cli build
2025-05-20 19:45:40 +02:00
Maciej Zieniuk
239556b55f [PM-18017] Show key connector domain in remove password page (#14695)
* Passed in userId on RemovePasswordComponent.

* Added userId on other references to KeyConnectorService methods

* remove password component refactor, test coverage, enabled strict

* explicit user id provided to key connector service

* redirect to / instead when user not logged in or not managing organization

* key connector service explicit user id

* key connector service no longer requires account service

* key connector service missing null type

* cli convert to key connector unit tests

* remove unnecessary SyncService

* error toast not showing on ErrorResponse

* bad import due to merge conflict

* bad import due to merge conflict

* missing loading in remove password component for browser extension

* error handling in remove password component

* organization observable race condition in key-connector

* usesKeyConnector always returns boolean

* unit test coverage

* key connector reactive

* reactive key connector service

* introducing convertAccountRequired$

* cli build fix

* moving message sending side effect to sync

* key connector service unit tests

* fix unit tests

* move key connector components to KM team ownership

* new unit tests in wrong place

* key connector domain shown in remove password component

* type safety improvements

* convert to key connector command localization

* key connector domain in convert to key connector command

* convert to key connector command unit tests with prompt assert

* organization name placement change in the remove password component

* unit test update

* key connector url required to be provided when migrating user

* unit tests in wrong place after KM code ownership move

* infinite page reload

* failing unit tests

* failing unit tests

---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
2025-05-19 08:58:51 -04:00
Maciej Zieniuk
e73f902aee [PM-18576] Fix missing user id on remove password (#13777)
* Passed in userId on RemovePasswordComponent.

* Added userId on other references to KeyConnectorService methods

* remove password component refactor, test coverage, enabled strict

* explicit user id provided to key connector service

* redirect to / instead when user not logged in or not managing organization

* key connector service explicit user id

* key connector service no longer requires account service

* key connector service missing null type

* cli convert to key connector unit tests

* remove unnecessary SyncService

* error toast not showing on ErrorResponse

* bad import due to merge conflict

* bad import due to merge conflict

* missing loading in remove password component for browser extension

* error handling in remove password component

* organization observable race condition in key-connector

* usesKeyConnector always returns boolean

* unit test coverage

* key connector reactive

* reactive key connector service

* introducing convertAccountRequired$

* cli build fix

* moving message sending side effect to sync

* key connector service unit tests

* fix unit tests

* unit tests in wrong place after KM code ownership move

* infinite page reload

* failing unit tests

* failing unit tests

---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
2025-05-19 08:51:46 +02:00
Daniel García
a02c230e4d Pin rust toolchain (#14817)
* Pin rust toolchain

* Always install targets in build script

* Delete installed toolchains
2025-05-17 22:17:36 +02:00
bw-ghapp[bot]
0ec7ab4704 Autosync the updated translations (#14834)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-05-17 19:04:06 +00:00
Colton Hurst
c0ef307e99 PM-21174: Revert 8de42ca (#14735)
Merging at the request of QA
2025-05-16 15:16:22 -04:00
Todd Martin
aad04f5621 [PM-20119] Increase default desktop window height (#14231)
* Increase default height to 730 pixels.

* Increased height to 745 to handle Windows spacing

* Updated to 790 pixels to support Login with Device on Windows
2025-05-16 15:09:03 -04:00
bw-ghapp[bot]
1c4ce2a9e6 Autosync the updated translations (#14812)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-05-16 16:35:21 +02:00
tangowithfoxtrot
5beafb876c fix: clear clipboard on close (#14731) 2025-05-16 06:24:08 -07:00
renovate[bot]
ad7c20febc [deps]: Update Rust crate thiserror to v2 (#13865)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-15 13:53:17 -07:00
cd-bitwarden
d57050f1da [PM-18767] Using new dialog for adding/editing name of folder in Desktop (#14049)
* Using new dialog for adding/editing name of folder in Desktop

* removing unecessary changes

* removing the template for AppFolderAddEdit

* Fixing the issue where it doesn't know the nested folder info

* lint fixes and removing uneeded param

* removing uneeded messages.json entry

* Updating the vault-v2 file to use the new folder dialog component

* Fixing the merge commit
2025-05-15 16:50:49 -04:00
renovate[bot]
de03e3ef25 [deps]: Update Rust crate tokio to v1.45.0 (#14506)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-15 13:22:54 -07:00
Jordan Aasen
b30faeb62b [PM-21554] - Creating a new item while editing edits the item (#14770)
* fix adding new cipher while editing a cipher

* don't set updatedCipherView if the cached cipher has an id and the new one doesn't

* fix cipher form config
2025-05-15 10:09:51 -07:00
Oscar Hinton
ac49e594c1 Add standalone false to all non migrated (#14797)
Adds standalone: false to all components since Angular is changing the default to true and we'd rather not have the angular PR change 300+ files.
2025-05-15 10:44:07 -04:00
Daniel García
0b65861cb1 [PM-8297][PM-955] Improve updater behavior (#14732)
* [PM-8297] Improve updater behavior

* Remove logs

* Unused args

* Test version number

* Revert "Test version number"

This reverts commit 39ef057662.
2025-05-15 13:28:04 +02:00
Y
5b864e4a73 [PM-20588] Fixed app description (#14395)
* Update electron-builder.json

* Update according to change given by trmartin4

https://github.com/bitwarden/clients/pull/14395#issuecomment-2836796307
2025-05-14 21:31:44 -04:00
renovate[bot]
6e5a1f184e [deps] Platform: Update Rust crate widestring to v1.2.0 (#14488)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-14 09:30:51 -07:00
renovate[bot]
b611fdfb62 [deps] Platform: Update Rust crate windows-registry to v0.5.1 (#14489)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-14 08:52:14 -07:00
SmithThe4th
ad3121f535 [PM-12423] Migrate Cipher Decryption to Use SDK (#14206)
* Created mappings for client domain object to SDK

* Add abstract decrypt observable

* Added todo for future consideration

* Added implementation to cipher service

* Added adapter and unit tests

* Created cipher encryption abstraction and service

* Register cipher encryption service

* Added tests for the cipher encryption service

* changed signature

* Updated feature flag name

* added new function to be used for decrypting ciphers

* Added new encryptedKey field

* added new function to be used for decrypting ciphers

* Manually set fields

* Added encrypted key in attachment view

* Fixed test

* Updated references to use decrypt with feature flag

* Added dependency

* updated package.json

* lint fix

* fixed tests

* Fixed small mapping issues

* Fixed test

* Added function to decrypt fido2 key value

* Added function to decrypt fido2 key value and updated test

* updated to use sdk function without prociding the key

* updated localdata sdk type change

* decrypt attachment content using sdk

* Fixed dependency issues

* updated package.json

* Refactored service to handle getting decrypted buffer using the legacy and sdk implementations

* updated services and component to use refactored version

* Updated decryptCiphersWithSdk to use decryptManyLegacy for batch decryption, ensuring the SDK is only called once per batch

* Fixed merge conflicts

* Fixed merge conflicts

* Fixed merge conflicts

* Fixed lint issues

* Moved getDecryptedAttachmentBuffer to cipher service

* Moved getDecryptedAttachmentBuffer to cipher service

* ensure CipherView properties are null instead of undefined

* Fixed test

* ensure AttachmentView properties are null instead of undefined

* Linked ticket in comment

* removed unused orgKey
2025-05-14 07:30:01 -07:00
Patrick-Pimentel-Bitwarden
0b0397c3f0 fix(enums-eslint): Enum Rule for ESLint (#14650)
* fix(enums-eslint): Enum Rule for ESLint - Added enums in the warnings for eslint.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error in both places for enums.

* fix(enums-eslint): Enum Rule for ESLint - Added new eslint plugin for warning on enums.

* fix(enums-eslint): Enum Rule for ESLint - Changed based on suggestion.

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* refactor(browser-platform-utils): Remove Deprecation and Fix Code - Changed usages of firefox to private and moved the usages to the preferred public method and removed the deprecations.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error and added disable rules for all other places.

* fix(enums-eslint): Enum Rule for ESLint - Undid other changes by accident
2025-05-13 10:07:38 -04:00
renovate[bot]
89b9ba21ca [deps] Platform: Update Rust crate arboard to v3.5.0 (#14484)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-12 07:15:06 -07:00
renovate[bot]
57ed1e7285 [deps] Platform: Update @types/node to v22.15.3 (#14723)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-12 10:09:40 -04:00
Bernd Schoolmann
aca8ab8e40 [PM-21001] Move autofill code to new encrypt service interface (#14548)
* Move autofill code to new encrypt service interface

* Fix test runner
2025-05-12 15:31:03 +02:00