1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 15:53:27 +00:00
Commit Graph

2154 Commits

Author SHA1 Message Date
bw-ghapp[bot]
949e9b14ab Autosync the updated translations (#14997)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-05-30 09:14:36 +02:00
Jordan Aasen
eed288d797 [PM-21724] - add safari and firefox to list of potential browser vendors (#14857)
* add safari and firefox to list of potential browser vendors

* use browserClientVendorExtended

* handle unknown browser client vendor
2025-05-29 13:01:07 -07:00
SmithThe4th
50143a4b88 pushes search text to a subject (#14880)
use distinctUntilChanged to prevent duplicate filtering operations

Run filtering outside angular zone to prevent change detection issues
2025-05-27 13:50:39 -07:00
Patrick-Pimentel-Bitwarden
cb770f5cd3 refactor(browser-platform-utils): Remove Deprecation and Fix Code (#14709)
* refactor(browser-platform-utils): Remove Deprecation and Fix Code - Changed usages of firefox to private and moved the usages to the preferred public method and removed the deprecations.

* fix(browser-platform-utils): Remove Deprecation and Fix Code - Tiny changes.

* test(browser-platform-utils): Remove Deprecation and Fix Code - Fixed up test
2025-05-27 16:01:07 -04:00
Daniel Riera
88bc762521 PM-16645 (#14649) 2025-05-27 14:51:40 -04:00
Oscar Hinton
5423ab3268 [PM-21934] Upgrade to eslint 9 (#14754)
Upgrades to Eslint v9. Since this is a major version there were breaking changes, but since we've previously migrated to flat configs in #12806 those were minimal.
2025-05-27 13:13:15 -04:00
Daniel James Smith
b2d38249ba Remove class user-select: The copy button contains all the information and is the preferred method (#14944)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-05-27 16:14:36 +02:00
✨ Audrey ✨
97a591e738 [PM-16793] port credential generator service to providers (#14071)
* introduce extension service
* deprecate legacy forwarder types
* eliminate repeat algorithm emissions
* extend logging to preference management
* align forwarder ids with vendor ids
* fix duplicate policy emissions; debugging required logger enhancements

-----

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-05-27 09:51:14 -04:00
Oscar Hinton
745ab21946 Remove unused imports in browser and desktop (#14875)
Removes unused imports from browser and desktop. These were missed in #14795.
2025-05-26 08:38:02 -04:00
rr-bw
23f4af6984 fix(account-switcher-icons) [Auth/PM-21086] Update icon size to tw-text-lg (#14858)
Decreases size of icons on the Account Switcher page
2025-05-23 12:14:30 -07:00
Daniel Riera
c6af80f3eb PM-21651 [For Automation Purposes] add test IDs to notification bar (#14863)
* PM-21651 [For Automation Purposes] Please add IDs to some of the main components

* option items

* dynamic test id

* mitigate feedback

* clean up logic
2025-05-23 11:48:23 -04:00
Addison Beck
56a3b14583 Introduce eslint errors for risky/circular imports (#14804)
* first draft at an idea dependency graph

* ignore existing errors

* remove conflicting rule regarding internal platform logic in libs

* review: allow components to import from platform
2025-05-23 08:01:25 -04:00
bw-ghapp[bot]
5702a17772 Autosync the updated translations (#14892)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-05-23 11:57:58 +02:00
Thomas Avery
bd29397fd8 [PM-21611] Require userId on KeyService clear methods (#14788) 2025-05-22 13:55:26 -05:00
Jonathan Prusik
753e7af380 [PM-21882] Lit Components Cleanup (#14872)
* rename item row component to cipher item row

* move CipherItem into CipherItemRow instead of passing a generic children prop

* remove redundant embedded stories

* add mock data to dropdown button story
2025-05-22 12:29:15 -04:00
Nick Krantz
f52e4e27a0 [PM-12770] Assign to Collections Hint (#14529)
* allow use of common spec in lib/vault tests

* pass readonly collections to the assign collection component

- The assign to collections component filters them out already.
-They're also needed to display copy within the component

* add hint to assign to collections component when there are read only collections assigned to a cipher already

* add readonly hint to desktop

* only show collection hint for collections that are assigned to the provided ciphers

* consider admin/owner edit everything permission when assigning to collections

* fix icon in test
2025-05-22 11:09:33 -05:00
Nick Krantz
27884d9ffe fix SpotlightComponent import (#14868) 2025-05-21 13:43:10 -05:00
Jason Ng
fd10a26df9 [PM-18804] generator nudges (#14705)
* added generator spotlight to credential generator component

* moved generator spotlight to browser component and add as slot in libs. update copy for send

* added an aria label for the generator nudge body content

* new copy and styles for browser send will be behind feature flag

* update featureflag call to observable in send-v2

* changed how nudge text is made in credential generator

* added new observable to vault nudges to return specific boolean. Update naming of vault types. update observable calls in credential-generator and send-v2

* update send-v2 and credential generator to use new renamed nudges

* update to create nudge generator spotlight component. using this inside the credential generator for nudge spotlight

* fix imports for Nudge related code

* add libs/angular to storybook

---------

Co-authored-by: Nick Krantz <nick@livefront.com>
2025-05-21 12:46:02 -05:00
Nick Krantz
1c4d851046 [PM-21005] Clear Add/Edit form cache when browser loses focus (#14634) 2025-05-21 08:00:49 -05:00
renovate[bot]
bc56bc8e37 [deps]: Lock file maintenance (#13866)
* [deps]: Lock file maintenance

* add override for parse5 version to 7.2.1 (7.3.0 has breaking ts changes)

* manual rebuild of package-lock

* fix test event listeners persistence

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Prusik <jprusik@classynemesis.com>
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2025-05-21 09:29:14 +02:00
Jordan Aasen
94815085ed set default values for navButtons$ observable (#14859) 2025-05-20 13:36:10 -07:00
Jordan Aasen
7641dab0f0 [PM-18801] - account security nudge (#14771)
* account security nudge

* fix messages.json

* fix tests

* fix logic for account security item

* fix tests

* adjust account security nudge work to updated nudge service

* fix account security nudge

* remove unused code. do not show account security badge

* include ff and safari in link html

* fix import

* Revert "include ff and safari in link html"

This reverts commit cd12a36274.
2025-05-20 12:19:34 -07:00
Bernd Schoolmann
d93f547cfb [PM-21001] Move platform code to new encrypt service interface (#14544)
* Move platform code to new encrypt service interface

* Fix tests

* Fix tests

* Fix cli build
2025-05-20 19:45:40 +02:00
Daniel Riera
23506b0bc1 PM-19100 finalize a11y UX concerns title appendage (#14831)
* PM-19100

* move getheader to bar

* remove const

* revert flag value

* move into use component block

* include confirmtation container, clean up resolvedtype

* make header optional to account for undefined

* update stories to behave as expectec and use appropriate functions

* Update apps/browser/src/autofill/notification/bar.ts

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
2025-05-20 15:06:03 +00:00
Nick Krantz
83c4438efe Refactor: Move NudgesService to libs/angular/vault (#14843)
* move NudgesService to libs/angular/vault to avoid circular dependencies

* remove fix for spotlight component in storybook
2025-05-19 15:21:14 -05:00
Maciej Zieniuk
239556b55f [PM-18017] Show key connector domain in remove password page (#14695)
* Passed in userId on RemovePasswordComponent.

* Added userId on other references to KeyConnectorService methods

* remove password component refactor, test coverage, enabled strict

* explicit user id provided to key connector service

* redirect to / instead when user not logged in or not managing organization

* key connector service explicit user id

* key connector service no longer requires account service

* key connector service missing null type

* cli convert to key connector unit tests

* remove unnecessary SyncService

* error toast not showing on ErrorResponse

* bad import due to merge conflict

* bad import due to merge conflict

* missing loading in remove password component for browser extension

* error handling in remove password component

* organization observable race condition in key-connector

* usesKeyConnector always returns boolean

* unit test coverage

* key connector reactive

* reactive key connector service

* introducing convertAccountRequired$

* cli build fix

* moving message sending side effect to sync

* key connector service unit tests

* fix unit tests

* move key connector components to KM team ownership

* new unit tests in wrong place

* key connector domain shown in remove password component

* type safety improvements

* convert to key connector command localization

* key connector domain in convert to key connector command

* convert to key connector command unit tests with prompt assert

* organization name placement change in the remove password component

* unit test update

* key connector url required to be provided when migrating user

* unit tests in wrong place after KM code ownership move

* infinite page reload

* failing unit tests

* failing unit tests

---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
2025-05-19 08:58:51 -04:00
Github Actions
a82eb8c22b Bumped client version(s) 2025-05-19 10:40:05 +00:00
Maciej Zieniuk
e73f902aee [PM-18576] Fix missing user id on remove password (#13777)
* Passed in userId on RemovePasswordComponent.

* Added userId on other references to KeyConnectorService methods

* remove password component refactor, test coverage, enabled strict

* explicit user id provided to key connector service

* redirect to / instead when user not logged in or not managing organization

* key connector service explicit user id

* key connector service no longer requires account service

* key connector service missing null type

* cli convert to key connector unit tests

* remove unnecessary SyncService

* error toast not showing on ErrorResponse

* bad import due to merge conflict

* bad import due to merge conflict

* missing loading in remove password component for browser extension

* error handling in remove password component

* organization observable race condition in key-connector

* usesKeyConnector always returns boolean

* unit test coverage

* key connector reactive

* reactive key connector service

* introducing convertAccountRequired$

* cli build fix

* moving message sending side effect to sync

* key connector service unit tests

* fix unit tests

* unit tests in wrong place after KM code ownership move

* infinite page reload

* failing unit tests

* failing unit tests

---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
2025-05-19 08:51:46 +02:00
bw-ghapp[bot]
dc776de2eb Autosync the updated translations (#14833)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-05-17 19:04:29 +00:00
Jonathan Prusik
b4b452f5d1 do not show irrelevant success information in the notification confirmation in an error case (#14825) 2025-05-16 14:34:08 -04:00
bw-ghapp[bot]
c343f5282e Autosync the updated translations (#14813)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-05-16 20:04:47 +02:00
Anders Åberg
d16a5cb73e Revert "PM-21553: Added support for credential.toJSON() (#14734)" (#14819)
This reverts commit df8d184889.
2025-05-16 13:30:47 -04:00
Daniel Riera
32727e23db PM-21688 finalize a11y UX concerns misc (#14805)
* PM-21688 finalize a11y UX concerns misc

* add Close to close button for SR, handle error new item SR

* fix hover state for badge

* dynamic update button

* fix types

* Update apps/browser/src/autofill/content/components/lit-stories/mock-data.ts

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

* handle undefined

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
2025-05-16 16:51:11 +00:00
Miles Blackwood
3b26713b3a Replace fit-content with auto. (#14820) 2025-05-16 13:17:57 +00:00
Anders Åberg
df8d184889 PM-21553: Added support for credential.toJSON() (#14734)
* Added support for credential.toJSON()

* Changed to import type
2025-05-16 11:02:12 +02:00
Jonathan Prusik
14ced25561 [PM-21456] Notification bar does not appear when user is adding a new login when vault is locked (#14807)
* WiP if vault is locked, prompt to unlock and save with v3 notification

* add component handling for unlock notification type

* fix header component standalone mode

* fix header copy

* render unlock notification case on save with locked vault
2025-05-15 17:42:46 -04:00
sportshead
0d19432f14 fix(browser): use appCopyField instead of appCopyClick for singleCopiableLogin (#14692)
Fixes #14167

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2025-05-15 15:54:41 -04:00
Jason Ng
ee4c3cfd94 [PM-21663] nudge service name refactor (#14789)
* update names of vault nudge service and their corresponding files, convert components using showNudge$ to instead target spotlight and badges directly with new observables. Core logic for dismiss remains the same
2025-05-15 15:10:38 -04:00
Daniel Riera
82d0925f4e PM-21620 finalize a11y UX concerns for option selection (#14777)
* PM-21620 finalize a11y UX concerns for option selection

* SR should announce that the button has a menu popup collapsed and expanded when they open it

* support up and down keys -close menu when other menu expanded

* dynamic aria label

* type safety

* instanceOf to replace as Node for type

* default aria hidden prop that can be overridden

* update mock and make message more descriptive

* Update apps/browser/src/autofill/content/components/icons/collection-shared.ts

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
2025-05-15 13:32:05 -04:00
Oscar Hinton
ac49e594c1 Add standalone false to all non migrated (#14797)
Adds standalone: false to all components since Angular is changing the default to true and we'd rather not have the angular PR change 300+ files.
2025-05-15 10:44:07 -04:00
SmithThe4th
ad3121f535 [PM-12423] Migrate Cipher Decryption to Use SDK (#14206)
* Created mappings for client domain object to SDK

* Add abstract decrypt observable

* Added todo for future consideration

* Added implementation to cipher service

* Added adapter and unit tests

* Created cipher encryption abstraction and service

* Register cipher encryption service

* Added tests for the cipher encryption service

* changed signature

* Updated feature flag name

* added new function to be used for decrypting ciphers

* Added new encryptedKey field

* added new function to be used for decrypting ciphers

* Manually set fields

* Added encrypted key in attachment view

* Fixed test

* Updated references to use decrypt with feature flag

* Added dependency

* updated package.json

* lint fix

* fixed tests

* Fixed small mapping issues

* Fixed test

* Added function to decrypt fido2 key value

* Added function to decrypt fido2 key value and updated test

* updated to use sdk function without prociding the key

* updated localdata sdk type change

* decrypt attachment content using sdk

* Fixed dependency issues

* updated package.json

* Refactored service to handle getting decrypted buffer using the legacy and sdk implementations

* updated services and component to use refactored version

* Updated decryptCiphersWithSdk to use decryptManyLegacy for batch decryption, ensuring the SDK is only called once per batch

* Fixed merge conflicts

* Fixed merge conflicts

* Fixed merge conflicts

* Fixed lint issues

* Moved getDecryptedAttachmentBuffer to cipher service

* Moved getDecryptedAttachmentBuffer to cipher service

* ensure CipherView properties are null instead of undefined

* Fixed test

* ensure AttachmentView properties are null instead of undefined

* Linked ticket in comment

* removed unused orgKey
2025-05-14 07:30:01 -07:00
Vincent Salucci
3e0cc7ca7f [PM-18627] Remove customization settings popover (#14713)
* chore: remove customization popover strings, refs PM-18627

* chore: delete new settings callout ts/html component, refs PM-18627

* chore: remove new customization code from vault-v2 component, refs PM-18627:
:q

* chore: delete vault-page service, refs PM-18627

* chore: add state migration to remove data, refs PM-18627
2025-05-14 09:26:47 -05:00
Jason Ng
d68574fc40 [PM-21395] Vault Nudges Bugs (#14737)
* updates to empty vault and has items nudges
2025-05-13 16:49:41 -04:00
Daniel Riera
393926beec PM-21605 Remove Login text from error notification (#14767) 2025-05-13 20:10:33 +00:00
Daniel Riera
d50db0d0dd [PM-21441] Defect - Notification bar sometimes gets cut off in fill dev (#14764)
* PM-21441

* revert default value
2025-05-13 20:08:43 +00:00
Vicki League
b3df8a6c13 [PM-17091][PM-17043] Support system zoom in browser extension (#14435) 2025-05-13 14:16:18 -04:00
Jason Ng
1f72dd7710 PM-21286 add aria label to nudge settings badge (#14750) 2025-05-13 11:30:36 -04:00
SmithThe4th
0750ff38f5 Route to vault page when user doesn't have access (#14633) 2025-05-13 11:21:07 -04:00
Patrick-Pimentel-Bitwarden
0b0397c3f0 fix(enums-eslint): Enum Rule for ESLint (#14650)
* fix(enums-eslint): Enum Rule for ESLint - Added enums in the warnings for eslint.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error in both places for enums.

* fix(enums-eslint): Enum Rule for ESLint - Added new eslint plugin for warning on enums.

* fix(enums-eslint): Enum Rule for ESLint - Changed based on suggestion.

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* refactor(browser-platform-utils): Remove Deprecation and Fix Code - Changed usages of firefox to private and moved the usages to the preferred public method and removed the deprecations.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error and added disable rules for all other places.

* fix(enums-eslint): Enum Rule for ESLint - Undid other changes by accident
2025-05-13 10:07:38 -04:00
Daniel Riera
02cbc37ac5 PM-20397 Misc notification bar UI tweaks (#14558)
* PM-20637

* turncate save button
2025-05-12 21:23:06 +00:00