John Harrington
16a0aad849
adapt chromium_importer to match conventions established by autofill:
...
• eliminate extern c and unsafe rust from chromium_importer logic (still called in prior napi/lib.rs)
• use CommandInput / CommandResult JSON pattern to call objc methods
• remove usage of libc to cleanup memory and remove this dependency
2025-12-04 11:02:19 -07:00
John Harrington
84d588f6e9
Merge branch 'main' into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build
2025-12-03 13:22:44 -07:00
Bernd Schoolmann
1bfff49ef5
[PM-29122] Fix debug build causing slow unlock ( #17798 )
...
* Fix debug build causing slow unlock
* Cleanup
* Fix release mode build actually building debug
2025-12-03 19:10:10 +00:00
John Harrington
f773081802
clippy lints
2025-12-02 15:25:24 -07:00
John Harrington
dc9b05b620
eval Claude's comments and address legitimate findings
2025-12-02 15:19:22 -07:00
John Harrington
d8990488ff
fix lints on linux build
2025-12-02 14:30:42 -07:00
John Harrington
d0c0da37d6
fix unused variable outside of macos build
2025-12-02 10:28:13 -07:00
John Harrington
2ce203e459
fix clippy error
2025-12-02 10:13:16 -07:00
John Harrington
de0d8e2be4
fix cargo fmt
2025-12-02 10:05:34 -07:00
John Harrington
b58207e409
remove sandbox feature flag and refactor to use bool
2025-12-02 10:03:03 -07:00
John Harrington
618d1dc1cb
Merge branch 'main' into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build
2025-12-02 07:18:26 -07:00
renovate[bot]
79d518fcf7
[deps]: Update Rust crate mockall to v0.14.0 ( #17747 )
...
* [deps]: Update Rust crate mockall to v0.14.0
* fix test cases global expectations
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: neuronull <9162534+neuronull@users.noreply.github.com >
2025-12-01 11:47:32 -07:00
neuronull
30b89d1fc2
Bump Rust version to 1.87.0 ( #17641 )
...
* Bump Rust version to 1.87.0
* clippy
* clippy
* clippy
2025-12-01 08:42:12 -07:00
Bernd Schoolmann
b7287d4614
[PM-26570] Remove biometrics v1 ( #17629 )
...
* Remove biometrics v1
* Cargo fmt
* Fix windows build
* Apply prettier
* Remove proxy code
* Fix build
* Fix
* Fix tests
* Remove v2 flag
2025-12-01 10:16:36 +01:00
John Harrington
34c013ea4a
pass new bool value on other platforms
2025-11-29 19:22:21 -07:00
John Harrington
97223e6568
respond to review comments:
...
• replace usage of compile time flag with boolean for conditinal logic
• moved sandbox specific logic to contained module inside macos.rs
• remove redundant browser array from objc code and pass the target browser path as arg
2025-11-29 19:11:52 -07:00
John Harrington
be86360ad8
Merge branch 'main' into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build
2025-11-29 16:54:31 -07:00
renovate[bot]
d7dcdf2f03
[deps] Tools: Update Rust crate clap to v4.5.53 ( #17702 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-27 09:50:15 -06:00
John Harrington
9df4928664
rename references
2025-11-25 15:34:03 -07:00
John Harrington
3b329e2389
rename files to avoid uppercase letters
2025-11-25 15:30:01 -07:00
John Harrington
9719210a59
replace swift logic with objc
2025-11-25 15:19:45 -07:00
John Harrington
7e11c22779
Merge branch 'main' into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build
2025-11-25 07:57:16 -07:00
renovate[bot]
3a4eec38a1
[deps] Platform: Update Rust crate arboard to v3.6.1 ( #17547 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com >
2025-11-24 15:38:40 +00:00
John Harrington
f900acf0c5
re-run cargo fmt after fixing clippy lints
2025-11-21 13:37:01 -07:00
John Harrington
9fbf45e7a5
fix more clippy lints not caught locally
2025-11-21 13:29:58 -07:00
John Harrington
abf8991a90
remove unused dep
2025-11-21 12:57:15 -07:00
John Harrington
f14a6f4501
fix another clippy warning
2025-11-21 09:16:16 -07:00
John Harrington
46d24d33d9
cargo clippy
2025-11-21 08:56:20 -07:00
John Harrington
be9452530d
pass args directly in objc/build.rs
2025-11-21 08:40:37 -07:00
John Harrington
60eb309fba
avoid unwrap
2025-11-21 08:32:37 -07:00
John Harrington
61ace267f0
cargo fmt
2025-11-21 08:19:50 -07:00
John Harrington
f55e6992da
add dep to desktop_native cargo.toml
2025-11-21 08:14:51 -07:00
John Harrington
5fc55c86a0
Merge branch 'PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build' of github.com:bitwarden/clients into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build
...
merge conflict resolution
2025-11-21 08:13:34 -07:00
John Harrington
4be25d9290
remove additional debug output and revert popup-modal-style to match main
2025-11-21 08:12:34 -07:00
John Harrington
245171e999
Merge branch 'main' into PM-26250-Explore-options-to-enable-direct-importer-for-mac-app-store-build
2025-11-21 08:10:27 -07:00
John Harrington
83c01ba9bf
added docs and removed debug output
2025-11-21 07:56:10 -07:00
renovate[bot]
e9f67f4fd6
[deps]: Update Rust crate cc to v1.2.46 ( #17571 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com >
2025-11-21 13:57:31 +01:00
renovate[bot]
87e49c174c
[deps] Platform: Update Rust crate libc to v0.2.177 ( #17549 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com >
2025-11-21 13:56:54 +01:00
renovate[bot]
f6eb0f642e
[deps]: Update Rust crate clap to v4.5.51 ( #17572 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-21 11:52:51 +01:00
renovate[bot]
678e5193ca
[deps]: Update Rust crate async-trait to v0.1.89 ( #17570 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-21 11:32:36 +01:00
John Harrington
18064efc4f
add/improve comments and logging
2025-11-20 09:51:49 -07:00
John Harrington
61b26241ad
move sandbox code into macos.rs
2025-11-20 09:09:11 -07:00
John Harrington
aa42630410
chromium importer working in sandbox
2025-11-19 15:22:23 -07:00
neuronull
db16c201b8
Align Desktop Native's Rust CI checks with SDK ( #17261 )
...
* clean crate deps
* update lint workflow
* add rustfmt.toml
* apply rust fmt
* missed one
* fix lint of lint lol
* more deps platform fixes
* fix macos_provider
* some more deps clean
* more cleanup
* add --all-targets
* remove another unused dep
* generate index.d.ts
* fix whitespace
* fix split comment in biometric
* formatting comment in biometric_v2
* apply fmt
2025-11-19 15:07:57 +00:00
John Harrington
f40233fce4
initial sandbox implementation for mac app store builds
2025-11-18 16:20:12 -07:00
aj-bw
413a024e61
removal of freebsd build, upload, release and other references ( #17354 )
2025-11-17 16:33:12 -05:00
neuronull
a2abbd09bf
Desktop Native compile debug builds with debug log level ( #17357 )
...
* Desktop Native compile debug builds with debug log level
* typo in code comment
2025-11-17 09:14:50 -07:00
Daniel James Smith
9586057a32
[PM-26162] [Chromium importer] Add fallback name in case empty when loading browser profiles ( #16664 )
...
* Added a fallback to use a browser profile folder-name in case the name of the profile is empty
2025-11-13 13:14:45 -07:00
renovate[bot]
9c2da604b1
[deps] Platform: Update Rust crate typenum to v1.19.0 ( #16845 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com >
2025-11-13 18:37:18 +01:00
Oscar Hinton
ed53ef19d9
[PM-27897] Fix release before use in chromium importer ( #17276 )
...
We ran into some weird issues where the memory was corrupted on certain architectures. It turns out we free'd memory before using it.
This ensures we make a copy of the data before freeing it, and extracts a common function for both crates to use.
2025-11-10 14:15:15 +01:00
