1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 05:13:29 +00:00
Commit Graph

2655 Commits

Author SHA1 Message Date
Daniel James Smith
6b627502be [PM-18668] Create importer for xml files from Password Depot 17 (#14760)
* Create importer for xml file from Password Depot 17

- Create importer
- Create test data
- Create unit tests

* Add support for parsing credit cards

* Update comment on importer class

* Wire up the importer to be selectable in the UI

* Import and set favorites based on export file

* Refactor: Extract method for parsing login fields

* Parse comment on credit cards

* Add support for parsing identity records

* Add support for parsing rdp records

* Remove html decoding of password field

* Include setting credit card brand

* Create type to describe the different source item types

* Add support for SoftwareLicense item type

* Add support for teamviewer item type

* Add support for Putty item type

* Skip processing historical entries

* Add support for banking item type

* Add support for information item type

* Add support for certificate into login type

* Rename encrypted-file.xml to noop-encrypted-file due to a source type with the same name

* Add support for encrypted file item type

* Add support for document type

* Add mapping of source field types to bitwarden custom field types

* Remove duplicate code (copy-pasta mistake)

* Added missing docs

* Adding fallback to support MacOS Password Depot 17 xml files

Instead of a version node they have a dataformat node which contains the file format version

* Add support to parse export files from the MacOS client

* Skip creating a folder if it has no name

* Fix recognition and assignment to folders/collections

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-07-01 13:52:04 +00:00
rr-bw
5639668d3f feat:(set-initial-password): [Auth/PM-18457] Create SetInitialPasswordComponent (#14186)
Creates a `SetInitialPasswordComponent` to be used in scenarios where an existing and authed user must set an initial password.

Feature Flag: `PM16117_SetInitialPasswordRefactor`
2025-06-30 12:39:53 -07:00
Jason Ng
f9d0e6fe4a [CL-572] adding new colors for icons, update icon docs (#15367)
* adding new colors for icons, update icon docs, remove art from colors mdx
2025-06-30 15:10:01 -04:00
Addison Beck
782dc930ad refactor(storage-test-utils): cut a new library for storage test tools (#15259)
* refactor(platform): generate a storage-test-utils library

* refactor(storage-test-utils): move FakeStorageService out of common
2025-06-30 13:56:26 -04:00
Jared Snider
64eb9b56d7 feat(anon-layout): [Auth/PM-17737] AnonLayout - Consolidate and extend max width control (#15362)
* PM-17737 - feat(anon-layout-width) - consolidate width setting to control title, subtitle, and content together for a unified UX. Removes all titleAreaMaxWidth usages and the titleAreaMaxWidth property entirely.

* PM-17737 - AnonLayout - consolidate stories into playground (w/ the exception of default icon story b/c I can't figure how to omit the icon conditionally).

* PM-17737 - AnonLayoutStories - show secondary content by default

* PM-17737 - Per PR feedback, adjust maxWidthClass logic to remove string concatenation as it can result in tailwind classes not being compiled and available at run time.

* PM-17737 - Per PR feedback, refactor stories to use configuration to generate all the scenarios so we can still track them via snapshots

* PM-17737 - Fix anon layout mdx reference

* PM-17737 - Make AnonLayoutMaxWidths singular

* PM-17737 - When inside of a max width container, the icon container needs explicit width to be able to scale viewbox icons that don't have defined heights / widths
2025-06-30 13:47:31 -04:00
SmithThe4th
ea5224da25 Properly converted date strings during imports and provided default values (#15398) 2025-06-30 13:04:01 -04:00
SmithThe4th
62981a1bec Migrate vault filter service from active user state to single user state (#15089) 2025-06-30 13:02:18 -04:00
Vicki League
a2fd4a3779 [PM-16291] Prevent parent components from closing when esc key is pressed on select and menu (#15214) 2025-06-30 11:03:24 -04:00
Vicki League
04ddea5bf3 [CL-473] Adjust popup page max width and scroll containers (#14853) 2025-06-30 09:39:39 -04:00
rr-bw
031c9bc947 fix(auth-guard): [PM-22822] remove SsoNewJitProvisionedUser case (#15376) 2025-06-27 15:24:12 -07:00
Nick Krantz
700f54357c [PM-20041] Marking Task as complete (#14980)
* When saving a cipher, mark any associated security tasks as complete

* fix test error from encryption refactor

* hide security tasks that are associated with deleted ciphers (#15247)

* account for deleted ciphers for atRiskPasswordDescriptions
2025-06-27 16:04:51 -05:00
rr-bw
7500fe32bb fix(auth-guard): [PM-22822] fix infinite redirect loop (#15371) 2025-06-27 11:19:13 -07:00
Jared McCannon
64f8073fdf Removed feature flag for OptimizeNestedTraverseTypescript and vnext methods related to it. (#15314) 2025-06-27 13:13:21 -05:00
Nick Krantz
cb36b96855 [PM-22178] Add WebBrowserInteractionService (#15261)
* add `WebBrowserInteractionService` and check for the extension observable

* update checkForExtension to use observables rather than window timeouts

* add open extension to WebBrowserInteractionService

* add at-risk-passwords to `PopupPageUrls`

* refactor `PopupPageUrls` to `ExtensionPageUrls`

* add test for passing a page

* refactor `Default` to `Index`

* clean up complete/next issue using `race`

* refactor page to url

* continue listening for messages from the extension after subscribed

* mark risk passwords a deprecated

* remove takeUntilDestroyed

* add back `takeUntilDestroyed` for internal `messages`

* removed null filter - unneeded

* add tap to send message for extension installation

* add check for accepted urls to prevent any bad actors from opening the extension
2025-06-27 12:55:20 -05:00
Jordan Aasen
62750a06ec [PM-36] - [Tech Debt] Move SearchService to libs/common/vault (#15251)
* wip - migrate search service to vault

* fix import
2025-06-27 08:16:59 -07:00
SmithThe4th
bfb71a3405 [PM-22996] Failed to decrypt ciphers: TypeError: this.uriChecksum is null (#15355) 2025-06-27 09:59:38 -04:00
Vicki League
34a338930a [CL-613] Support non-card primary content in anon-layout (#15273) 2025-06-26 17:09:25 -04:00
Ike
7c9e95271d [PM -20329] browser auth approval client api service (#15161)
* feat: Create methods for calling GET auth-request/pending endpoint.

* feat: update banner service on web, and desktop vault

* test: updated banner test to use auth request services

* fix: DI fixes

* feat: add RequestDeviceId to AuthRequestResponse

* fix: add Browser Approvals feature flags to desktop vault and web vault banner service

* test: fix tests for feature flag
2025-06-26 11:13:06 -04:00
Daniel James Smith
28e799f2bb Removing unused feature flag "item-share" (#15327)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-06-26 08:17:15 -04:00
Andreas Coroiu
71d4f989b7 [PM-18042] Build request response structure (#15163)
* feat: add support for discover command

* feat: make client public to allow RPC

* feat: update SDK
2025-06-26 14:01:31 +02:00
Todd Martin
473ab3a1f7 feat(feature-flags): Add Device-Identifier header to unauthenticated requests
* Added header to unauthenticated requests

* Added comment
2025-06-26 07:27:50 -04:00
Justin Baur
7d2b97b1df [PM-22573] Don't call server on existing subscription (#15154)
* Don't put subscription to our server when it's existing

* Only update server when subscription-user associations change

---------

Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
2025-06-25 21:42:06 -04:00
Jordan Aasen
7403b38f39 [CL-715] - [Defect] SSH key Private Key field visibility should toggle to hidden when switching items to view in desktop (#15224)
* fix sshKey visibility

* add missing ngIf

* use two-way binding over explicit key
2025-06-25 11:45:42 -07:00
rr-bw
cf6b087491 docs(password-management): [PM-18573] Document Master Password Management Flows (#15248)
Adds documentation for our set/change password flows (master password management flows)
2025-06-25 09:32:47 -07:00
rr-bw
1df54c71be refactor(account-recovery): [PM-18721][PM-21272] Integrate InputPasswordComponent in AccountRecoveryDialogComponent (#14662)
Integrates the `InputPasswordComponent` within the new `AccountRecoveryDialogComponent`.

Feature flag: `PM16117_ChangeExistingPasswordRefactor`
2025-06-25 07:29:22 -07:00
rr-bw
1b441e8a0f fix(routing): [PM-22995] update routing and tests (#15320)
Updates routing in 2 components to account for feature flag: `PM16117_SetInitialPasswordRefactor`
2025-06-25 07:25:41 -07:00
rr-bw
4a06562f60 refactor(emergency-access-takeover): [PM-18721][PM-21271] Integrate InputPasswordComponent in EmergencyAccessTakeoverDialogComponent (#14636)
Integrates the `InputPasswordComponent` within the `EmergencyAccessTakeoverDialogComponent`

Feature Flag: `PM16117_ChangeExistingPasswordRefactor`
2025-06-24 09:41:20 -07:00
Brandon Treston
012ce25e49 add encrypted collection name to confirmUser request (#15156) 2025-06-24 09:34:48 -04:00
Brandon Treston
1c237a3753 [PM-20633] rename personal ownership (#15228)
* sensible renames

* renames

* clean up comments
2025-06-24 09:31:40 -04:00
Rui Tomé
fa23a905e0 [PM-22442] Refactor ApiService: Remove unused methods for collection user management (#15208) 2025-06-24 10:21:35 +01:00
Addison Beck
95841eb078 refactor(storage-core): move storage files out of @bitwarden/common (#15076)
* refactor(platform): generate @bitwarden/storage-core boilerplate

* refactor(storage-core): move storage files out of @bitwarden/common

* chore(naming): rename AbstractStorageService to StorageService
2025-06-23 16:00:54 -04:00
rr-bw
5bd4d1691e refactor(auth-guard): [PM-22822] Update AuthGuard to explicitly handle each forceSetPasswordReason (#15252)
Update the `authGuard` to explicitly handle each `ForceSetPasswordReason`
2025-06-23 11:45:27 -07:00
SmithThe4th
e291e2df0a [PM-21451] [Vault] [CLI] Changes to Enforce "Remove card item type policy" (#15187)
* Created new service to get restricted types for the CLI

* Created service for cli to get restricted types

* Utilized restriction service in commands

* Renamed function

* Refactored service and made it simpler to check when a cipher type is restricted or not

* Moved service to common so it can be utilized on the cli

* Refactored service to use restricted type service

* Removed userId passing from commands

* Exclude restrict types from export

* Added missing dependency

* Added missing dependency

* Added missing dependency

* Added service utils commit from desktop PR

* refactored to use reusable function

* updated reference

* updated reference

* Fixed merge conflicts

* Refactired services to use isCipherRestricted

* Refactored restricted item types service

* Updated services to use the reafctored item types service
2025-06-23 09:04:56 -07:00
Jordan Aasen
2e8c0de719 [PM-21452] - [Vault] Import Data - Add callout when "Remove Card Item Type Policy" is enabled. (#15195)
* add callout for remove card item type policy

* add comment

* add shareReplay

* remove shareReplay. fix type

* fix import

* remove subscription
2025-06-23 08:52:18 -07:00
SmithThe4th
e253e05c45 [PM-22516] Fix cipher key decryption to handle new error-based API instead of null returns (#15124)
* Replace null check in cipher key decryption

* Handle decryption error properly in user asymmetric key regeneration service
2025-06-23 09:11:52 -04:00
Nick Krantz
9e1ab2864c avoid aria-label for screen reader only text (#15119) 2025-06-20 15:57:33 -05:00
✨ Audrey ✨
8a8d02b7db encapsulate kludge property to fix invalid credential type error (#15225) 2025-06-20 09:44:38 -04:00
Addison Beck
662a973d62 fix(nx-plugin): remove extra / from tsconfig.spec template (#15258) 2025-06-19 16:38:00 -04:00
Jordan Aasen
3b830faf09 fix logic for restrictedTypeFilter (#15253) 2025-06-18 16:08:13 -07:00
Jordan Aasen
f9b31d2906 remove legacy attachment upload (#15237) 2025-06-18 15:27:34 -07:00
Shane Melton
e8f53fe9b7 [PM-22756] Send minimizeOnCopy message during copy on Desktop platform (#15232)
* [PM-22756] Send minimizeOnCopy message during copy on Desktop platform

* [PM-22756] Introduce optional CopyClickListener pattern

* [PM-22756] Introduce CopyService that wraps PlatformUtilsService.copyToClipboard to allow scoped implementations

* [PM-22756] Introduce DesktopVaultCopyService that sends the minimizeOnCopy message

* [PM-22756] Remove leftover onCopy method

* [PM-22756] Fix failing tests

* [PM-22756] Revert CopyService solution

* [PM-22756] Cleanup

* [PM-22756] Update test

* [PM-22756] Cleanup leftover test changes
2025-06-18 14:44:21 -07:00
Jordan Aasen
5fa153e743 [PM-20643] - [Vault] [Desktop] Front End Changes to Enforce "Remove card item type policy" (#15176)
* add restricted item types to legacy vault components

* filter out restricted item types from new menu item in desktop

* use CIPHER_MENU_ITEMS

* use CIPHER_MENU_ITEMS. move restricted cipher service to common

* use move restricted item types service to libs. re-use cipher menu items

* add shareReplay. change variable name

* move restricted filter to search service. remove unecessary import

* add reusable service method

* clean up spec

* add optional chain

* remove duplicate import

* move isCipherViewRestricted to service module

* fix logic

* fix logic

* remove extra space

---------

Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2025-06-18 12:13:38 -07:00
rr-bw
9e76448188 docs(redirect-guard): [BEEEP] Document redirectGuard (#15196) 2025-06-18 10:12:21 -07:00
SmithThe4th
02a63d4a38 [PM-22725] [Defect]Title and Username are removed when editing Identity items (#15221)
* map sdk identity type back to null when undefined

* refactored views to have consistent pattern with other fromSdk methods
2025-06-18 10:16:25 -04:00
Anders Åberg
2f47a90e79 Allow string 'true' instead of true (#14816) 2025-06-18 11:31:11 +02:00
Anders Åberg
b2b695a705 PM-21553: Added support for credential.toJSON() (#15028)
* Added support for credential.toJSON()

* Changed to import type
2025-06-18 11:31:00 +02:00
Jason Ng
71bc68444d [PM-22419] dismiss account nudge when biometric unlock is set (#15139)
* update account-security-nudge service to look at biomentricUnlockEnabled$ observable, add success toast for biometric unlock
2025-06-17 14:47:10 -04:00
Vicki League
df4aae2fb2 [CL-700] Move auth-owned layout components to UIF ownership (#15093) 2025-06-17 13:33:01 -04:00
Will Martin
b8a1856fc6 [CL-696] un-revert "various drawer improvements" + bug fix (#14887)
* Revert "Revert "[CL-622][CL-562][CL-621][CL-632] various drawer improvements …"

This reverts commit 4b32d1f9dd.

* fix virtual scroll: add .cdk-virtual-scrollable to scroll viewport target

* remove references to main el

* use directives instead of querySelector (#14950)

* remove references to main el

* wip

* banish querySelector to the shadow realm

* revert apps/ files

* Add virtual scrolling docs

Co-authored-by: Vicki League <vleague@bitwarden.com>

* add jsdoc

* run eslint

* fix skip links bug

* Update libs/components/src/layout/layout.component.ts

Co-authored-by: Vicki League <vleague@bitwarden.com>

* update tab handler

* only run on tab

* fix lint

* fix virtual scroll issue due to Angular 19 upgrade (#15193)

thanks Vicki

---------

Co-authored-by: Vicki League <vleague@bitwarden.com>
2025-06-17 11:05:14 -04:00
Bernd Schoolmann
1dd7eae466 Update sdk for breaking init change (#15212) 2025-06-17 12:59:35 +02:00