bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-08 20:50:28 +00:00
Code Issues Releases Wiki Activity
17,799 Commits 1,309 Branches 581 Tags
1bda7d44fb07832cb5d408564f53bbd730570d78
Commit Graph

1243 Commits

Author SHA1 Message Date
Maciej Zieniuk
1bda7d44fb unit test coverage 2025-03-25 09:07:52 +00:00
Maciej Zieniuk
3d088fcdc6 usesKeyConnector always returns boolean 2025-03-25 09:07:36 +00:00
Maciej Zieniuk
c2b103dc18 organization observable race condition in key-connector 2025-03-19 22:48:00 +00:00
Maciej Zieniuk
b829a08250 Merge branch 'main' into km/pm-18576/fix-missing-userid-on-remove-password 
# Conflicts:
#	libs/common/src/key-management/key-connector/services/key-connector.service.ts
 2025-03-18 17:59:31 +00:00
Todd Martin
4537642003 chore(2fa recovery code): [PM-18175] Remove feature flag and old recovery flow 2025-03-17 16:22:25 -04:00
Addison Beck
e8c4c570e9 fix: save indication of browser installation to storage (#13743) 2025-03-17 14:23:40 -04:00
Thomas Avery
a11536a424 [PM-17668] Move DeviceTrustService to KM ownership (#13194) 
* move DeviceTrustService to KM ownership

* update codecov
 2025-03-17 12:02:44 -05:00
Ike
2d4ffe6eb6 Revert "[PM-19209] Update New device verification error" (#13843) 
This reverts commit 31b1ee4f84.
 2025-03-14 13:05:57 -04:00
Alex Morask
2ecfac40b7 [PM-18794] Allow provider payment method (#13825) 
* Allow provider payment method

* Run prettier
 2025-03-14 11:33:21 -04:00
Brandon Treston
4d68952ef3 [PM-18089] Update cipher permissions model and consumers (#13606) 
* update cipher permissions model and consumers

* add new property to tests

* fix test, add property to toCipherData()

* add missing ConfigService

* fix story

* refactor

* fix error, cleanup

* revert refactor

* refactor

* remove uneeded test

* cleanup

* fix build error

* refactor

* clean up

* add tests

* move validation check to after featrue flagged logic

* iterate on feedback

* feedback
 2025-03-14 09:51:40 -04:00
Thomas Rittson
0c507f54f6 [PM-13323] Move remaining collection code to AC Team (#13731) 2025-03-13 17:18:47 -04:00
Ike
31b1ee4f84 [PM-19209] Update New device verification error 
fix : updating error string for new device response from server to match comparison.
 2025-03-13 14:48:16 -04:00
Shane Melton
4687120618 [PM-18946] Improve Vault loading experience (#13714) 
* [PM-18946] Refactor loading$ in vault-v2. Update icon-component, and build-cipher-icon
 2025-03-13 14:38:29 -04:00
Thomas Avery
81335978d8 [PM-17669] Move MasterPasswordService to KM (#13148) 
* Move MasterPasswordService to KM
 2025-03-13 13:29:27 -05:00
Daniel James Smith
26fb3220fe Introduce export-attachments feature-flag (#13827) 
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-03-13 16:52:36 +00:00
Maciej Zieniuk
53cd7e7a0d Merge branch 'main' into km/pm-18576/fix-missing-userid-on-remove-password 
# Conflicts:
#	libs/angular/src/auth/components/remove-password.component.ts
#	libs/common/src/key-management/key-connector/abstractions/key-connector.service.ts
#	libs/common/src/key-management/key-connector/services/key-connector.service.ts
 2025-03-13 16:27:58 +00:00
Thomas Avery
7e96b7a9a6 [PM-17670] Move KeyConnectorService to KM ownership (#13277) 
* Move KeyConnectorService to KM ownership

* Add to codecov

* Move key connector request models
 2025-03-13 09:46:01 -05:00
Maciej Zieniuk
c3a2b07839 Merge branch 'main' into km/pm-18576/fix-missing-userid-on-remove-password 2025-03-13 12:25:25 +00:00
Alec Rippberger
942b80e5d2 refactor(auth): [PM-9724] remove LoginViaAuthRequestComponentV1 and related functionality 
- Remove deprecated LoginViaAuthRequestComponentV1 component
- Clean up related ApiService functionality
- Remove orphaned translation messages
- Remove unused CSS styles

Jira PM-9724
 2025-03-12 16:40:05 -05:00
Vincent Salucci
ae47c12b0e chore: organize feature flags (#13809) 2025-03-12 15:34:04 -05:00
rr-bw
e268055dc1 feature(set-change-password): [Auth/PM-17648] Create MasterPasswordApiService (#13552) 
Creates a MasterPasswordApiService to house our API calls related to setting and changing a master password.
 2025-03-12 11:33:44 -07:00
Bernd Schoolmann
83de125ae9 [PM-15149] Remove ssh feature flag (#13506) 
* Remove ssh feature flag

* Remove isSshKeyENabled in type-filter.component
 2025-03-12 14:19:49 +01:00
Jason Ng
15fa3cf08d [PM-10613] End User Notification Service (#13721) 
* new end user notification service to retrieve and update notifications from API
 2025-03-12 08:02:18 +01:00
Daniel Riera
b988993a88 PM-18963 removed flag and updated relevant tests (#13767) 2025-03-11 16:06:03 -04:00
Conner Turnbull
00e822fb13 [PM-16937] Remove Billing Circular Dependency (#13085) 
* Remove circular dependency between billing services and components

* Removed `logService` from `billing-api.service.ts`

* Resolved failed test

* Removed @bitwarden/ui-common

* Added optional `title` parameter to `BillingNotificationService` functions

* Removed @bitwarden/platform from libs/common/tsconfig.json

* Update apps/web/src/app/billing/services/billing-notification.service.spec.ts

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Update apps/web/src/app/billing/services/billing-notification.service.spec.ts

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Resolved build errors

* Resolved issue where free trial banner wouldn't display if missing a payment method

---------

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
 2025-03-11 13:43:19 -04:00
Daniel James Smith
6188013b9d Introduce desktop-send-ui-refresh feature-flag (#13787) 
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-03-11 08:50:24 -05:00
Bernd Schoolmann
9683779dbf [PM-17984] Remove AES128CBC-HMAC encryption (#13304) 
* Remove AES128CBC-HMAC encryption

* Increase test coverage
 2025-03-11 14:20:02 +01:00
Maciej Zieniuk
5cd47ac907 [PM-18243] Improve type safety in decryption (#12885) 
* Improve decrypt failure logging

* Rename decryptcontext to decrypttrace

* Improve docs

* PM-16984: Improving type safety of decryption

* Improving type safety of decryption

---------

Co-authored-by: Bernd Schoolmann <mail@quexten.com>
 2025-03-11 14:06:44 +01:00
Maciej Zieniuk
d496863e8d key connector service missing null type 2025-03-11 07:30:57 +00:00
Maciej Zieniuk
b0d09c8b24 key connector service explicit user id 2025-03-10 23:46:13 +00:00
rr-bw
0568a09212 refactor(device-trust-toasts): [Auth/PM-11225] Refactor Toasts from Auth Services (#13665) 
Refactor toast calls out of auth services. Toasts are now triggered by an observable emission that gets picked up by an observable pipeline in a new `DeviceTrustToastService` (libs/angular). That observable pipeline is then subscribed by by consuming the `AppComponent` for each client.
 2025-03-10 12:17:46 -07:00
Bernd Schoolmann
01f6fd7ee3 [PM-16227] Move import to sdk and enable it in browser/web (#12479) 
* Move import to sdk and enable it in browser/web

* Add uncomitted files

* Update package lock

* Fix prettier formatting

* Fix build

* Rewrite import logic

* Update ssh import logic for cipher form component

* Fix build on browser

* Break early in retry logic

* Fix build

* Fix build

* Fix build errors

* Update paste icons and throw error on wrong import

* Fix tests

* Fix build for cli

* Undo change to jest config

* Undo change to feature flag enum

* Remove unneeded lifetime

* Fix browser build

* Refactor control flow

* Fix i18n key and improve import behavior

* Remove for loop limit

* Clean up tests

* Remove unused code

* Update libs/vault/src/cipher-form/components/sshkey-section/sshkey-section.component.ts

Co-authored-by: SmithThe4th <gsmith@bitwarden.com>

* Move import logic to service and add tests

* Fix linting

* Remove erroneous includes

* Attempt to fix storybook

* Fix storybook, explicitly implement ssh-import-prompt service abstraction

* Fix eslint

* Update libs/importer/src/importers/bitwarden/bitwarden-json-importer.ts

Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>

* Fix services module

* Remove ssh import sdk init code

* Add tests for errors

* Fix import

* Fix import

* Fix pkcs8 encrypted key not parsing

* Fix import button showing on web

---------

Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
 2025-03-10 18:41:47 +01:00
Oscar Hinton
a569dd9ad6 [PM-15892] [PM-12250]Remove nord and remnants from solarizedark (#13449) 
* Remove nord and remnants from solarizedark

* Update window reload color

* Remove extension-refresh feature flag from clients (#13450)

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>

* Remove usage of nord and solarized themes within DarkImageDirective

---------

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
 2025-03-10 15:33:55 +01:00
Thomas Rittson
ef72f513b1 eslint: report unused disable directives (#13463) 
Remove any unused disable directives and FIXMEs in our code
 2025-03-10 09:33:08 -04:00
Ike
c739a884b4 [PM-15015] Adding Request Country Name to auth requests approval dialog (#13718) 
* feat(pm-15015) : 
  - Adding `requestCountryName` to auth requests dialogs, and response models. 
  - Updated i18n messages.json in Web, Browser, and Desktop to include "Location" translation.
 2025-03-07 18:03:13 -05:00
SmithThe4th
e327816bc4 [PM-11941] Migrate TOTP Generator to use SDK (#12987) 
* Refactored totp service to use sdk

Fixed strict typescript issues

* Fixed dependency issues

* Returned object that contains code and period, removed get interval function

* removed dependencies

* Updated to use refactored totp service

* removed sdk service undefined check

* removed undefined as an input from the getCode function

* Made getcode$ an observable

* refactored to use getcodee$

* Filter out emmissions

* updated sdk version

* Fixed readability nit

* log error on overlay if totp response does not return a code

* fix(totpGeneration): [PM-11941] Totp countdown not working on clients

* Used optional chaining if totpresponse returns null or undefined
 2025-03-06 14:01:07 -05:00
Jason Ng
f65daf7284 [PM-12045] search service activeuserstate (#13035) 
* removing activeuserstate from search service
 2025-03-06 12:26:24 -05:00
✨ Audrey ✨
9761588a2a [PM-16790] introduce extension service (#13590) 2025-03-06 11:32:42 -05:00
Jonas Hendrickx
ed83b6a445 [PM-18163] Remove feature flag 'AC-1795_updated-subscription-status-section' (#13456) 2025-03-06 13:19:08 +01:00
Brandon Treston
6037c583eb remove feature flag (#13677) 2025-03-04 14:53:02 -05:00
✨ Audrey ✨
e10b5af9d3 [PM-16791] introduce generator profile provider (#13588) 2025-03-03 12:43:34 -05:00
Jared Snider
92f027af5e fix(LoginComp + LoginStrategies): [Auth/PM-18654] Refreshed UI - Desktop TDE JIT provisioned user creation errors with missing org SSO id (#13619) 
* PM-18654 - State Service & Login Strategy Refactor - move env seeding into login strategy so that new accounts always load w/ the correct environment

* PM-18654 - SSO Comp - just use user id from auth result

* PM-18654 - Config Service - (1) don't allow cascading calls to the renewConfig by using a private promise (2) Replace shareReplay with share configured with manual timer

* PM-18654 - LoginComponents - detail issue and possible fix

* PM-18654 - DesktopLoginV1Comp - use correct destroy hook

* PM-18654 - LoginComp - clean up no longer correct comment

* PM-18654 - New Device Verification Component - Remove unused PasswordLoginStrategy dependency

* PM-18654 - Browser Home Component - fix qParam logic

* PM-18654 - DefaultConfigService - revert changes as they aren't necessary to fix the bug.

* PM-18654 - DefaultConfigService - remove commented code

* PM-18654 - LoginStrategy - add comment

* PM-18654 - Fix login strat tests
 2025-03-03 12:09:35 -05:00
Shane Melton
5b215cf193 [PM-18707] Fix desktop live sync (#13624) 
* [PM-18707] Remove redundant cipherService subscription

* [PM-18707] Add artificial tick delay to cipherService to allow for ElectronStore storage service to fully save before continuing
 2025-03-03 08:33:48 -08:00
Oscar Hinton
a7a5a2771e Remove runOnlyPendingTimers (#13581) 2025-03-03 16:51:08 +01:00
Matt Gibson
40f7a0d73f Parse web push payload JSON (#13594) 2025-02-28 17:53:43 +00:00
Bernd Schoolmann
7ba8dd98e6 Validate parameters in encrypt service tests (#13630) 2025-02-28 17:15:06 +01:00
Jake Fink
43f5423e78 [PM-12606] Move Vault Timeout and Vault Timeout Settings to KM (#13405) 
* move vault timeout and vault timeout settings to km

* move browser vault timeout service to km

* fix cli import

* fix imports

* fix some relative imports

* use relative imports within common

* fix imports

* fix new imports

* Fix new imports

* fix spec imports
 2025-02-28 09:55:03 -05:00
Bernd Schoolmann
0ee2e0bf93 [PM-18697] Increase test coverage for encrypt service and symmetric crypto key (#13628) 
* Increase coverage for EncryptService and SymmetricCryptoKey

* Re-add missing test
 2025-02-28 14:20:31 +01:00
Todd Martin
319a4dd1cc Remove checks of device verification flags on client (#13604) 2025-02-27 13:17:47 -05:00
Todd Martin
ec488e4f84 [PM-18664] Prevent display of Auth Request notification on triggering device (#13597) 
* Send device identifier in header.

* Added null to apiUrl property for strict typing.

* Added null to apiUrl for strict typing.
 2025-02-27 10:00:52 -05:00