1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-07 12:13:45 +00:00
Commit Graph

4863 Commits

Author SHA1 Message Date
Bernd Schoolmann
209704637b Merge branch 'km/move-clientkeyhalf-to-platform-impl' into km/simplify-linux-biometrics 2025-06-11 14:12:22 +02:00
Bernd Schoolmann
2b1232ee06 Merge branch 'main' into km/move-clientkeyhalf-to-platform-impl 2025-06-11 14:06:06 +02:00
Bernd Schoolmann
38341c3cf6 Merge branch 'km/move-clientkeyhalf-to-platform-impl' into km/simplify-linux-biometrics 2025-06-11 13:55:45 +02:00
Bernd Schoolmann
eabffa24b4 Fix types 2025-06-11 13:40:39 +02:00
Bernd Schoolmann
1fe08bef55 Add tests 2025-06-11 13:38:46 +02:00
Bernd Schoolmann
9385e3043c Add tests 2025-06-11 13:36:00 +02:00
Bernd Schoolmann
f0f9098d2e Tests 2025-06-11 13:21:09 +02:00
Bernd Schoolmann
b88f3de4cf Fix tests 2025-06-11 13:16:03 +02:00
Thomas Avery
90b07728d7 [PM-22133] Require userID for clearStoredUserKey (#14973) 2025-06-10 17:28:50 -05:00
Jason Ng
3326877a67 [PM-21719] Remove Assign To Collections Modal When No Editable Collections (#15137)
* remove assign to collections option when user does not have editable collections
2025-06-10 18:03:17 -04:00
Bernd Schoolmann
291eb95c1a Simplify linux biometrics & drop libsecret dependency 2025-06-10 22:35:08 +02:00
Bernd Schoolmann
ed96477626 Cleanup 2025-06-10 22:11:00 +02:00
Oscar Hinton
fc03ed662e Remove standalone true from sm (#15043)
Remove standalone: true from every instance since it's the default as of Angular 19.
2025-06-10 14:05:17 -04:00
Bernd Schoolmann
dc8077c7a0 Move clientkeyhalf to os platform implementation 2025-06-10 18:32:34 +02:00
Bernd Schoolmann
45605e9752 [PM-21944] Split up userkey rotation v2 and add tests (#14900)
* Split up userkey rotation v2 and add tests

* Fix eslint

* Fix type errors

* Fix tests

* Clear up trusted key naming

* Split up getNewAccountKeys

* Add trim and lowercase

* Replace user.email with masterKeySalt

* Add wasTrustDenied to verifyTrust in key rotation service

* Move testable userkey rotation service code to testable class

* Fix build

* Undo changes

* Fix incorrect behavior on aborting key rotation and fix import

* Fix tests

* Make members of userkey rotation service protected

* Fix type error

* Cleanup and add injectable annotation

* Fix tests

* Update apps/web/src/app/key-management/key-rotation/user-key-rotation.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Remove v1 rotation request

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2025-06-10 15:57:47 +02:00
Bernd Schoolmann
97d63be323 Move clientkeyhalf to main 2025-06-10 15:31:34 +02:00
Rui Tomé
b5bddd0b06 [PM-17154] Limit item deletion feature flag removal (#15094)
* Refactor components to remove limitItemDeletion feature flag usage

This commit simplifies the logic in various components by removing the limitItemDeletion feature flag. The conditions for displaying restore and delete actions are now based solely on the cipher's permissions, enhancing code clarity and maintainability.

* Refactor cipher deletion logic to remove the feature flag and collection ID dependency

This commit updates the cipher deletion logic across multiple components and services by removing the unnecessary dependency on collection IDs. The `canDeleteCipher$` method now solely relies on the cipher's permissions, simplifying the code and improving maintainability.

* Remove LimitItemDeletion feature flag from feature-flag enum and default values

* Remove configService from ServiceContainer and MainBackground constructor parameters

* Remove configService from RestoreCommand instantiation in OssServeConfigurator and VaultProgram classes
2025-06-10 09:57:34 +01:00
cyprain-okeke
159cca8cfa Added changes for downgradenbug (#15045) 2025-06-10 07:50:00 +01:00
Bernd Schoolmann
a368b70ab5 [BEEEP] Remove legacy biometrics protocol (#15004)
* Remove legacy biometrics protocol

* Remove legacy message handling on desktop
2025-06-10 05:25:12 +02:00
renovate[bot]
9367e89bcb [deps] Platform: Update electron-builder to v26 (#14362)
* [deps] Platform: Update electron-builder to v26

* Address electron-builder changes

* Update CI Scripts to new config options

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2025-06-09 16:41:44 -04:00
renovate[bot]
aac4dc6df4 [deps] Platform: Update napi (#14721)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Addison Beck <github@addisonbeck.com>
2025-06-09 16:20:13 -04:00
renovate[bot]
dc16c71c23 chore(deps) Platform: Update electron to v36
* [deps] Platform: Update electron to v36

* Update electron-builder.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
2025-06-09 16:12:03 -04:00
Jason Ng
c4092ddcd5 [PM-22421] update copy for set pin modal (#15120) 2025-06-09 15:02:50 -04:00
Vicki League
a28fb4be65 [CL-525] Update more Angular CSPs for v19 upgrade (#15106) 2025-06-09 10:34:30 -04:00
Zihad
b43e09ea6f fix: only start ssh agent if it's enabled (#13464)
closes #13150

Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2025-06-09 10:05:34 -04:00
cyprain-okeke
a421acc47a Resolve the vault page redirect issue (#14941) 2025-06-09 13:05:21 +01:00
Justin Baur
b1f090e054 Add lang attr on desktop and browser (#14691) 2025-06-09 06:54:00 -04:00
Thomas Avery
9d743a7ee0 [PM-21705] Require userID for refreshAdditionalKeys() on key-service (#14810)
* Require userID for refreshAdditionalKeys()

* Add error handling to desktop Unlock settings

* Add more unit test coverage
2025-06-06 13:38:25 -05:00
bw-ghapp[bot]
a36e05380f Autosync the updated translations (#15102)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-06-06 14:42:19 +02:00
Oscar Hinton
18573bdc48 [PM-22250] Bump open (#15011)
Upgrade open to latest version.
2025-06-06 12:06:14 +02:00
bw-ghapp[bot]
1ec33caf1d Autosync the updated translations (#15101)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-06-06 09:29:23 +02:00
bw-ghapp[bot]
6110fcb4cc Autosync the updated translations (#15100)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2025-06-06 09:23:55 +02:00
Github Actions
e55a70d53d Bumped Desktop client to 2025.6.0 2025-06-05 20:32:12 +00:00
Todd Martin
2c404d35d4 fix(2fa): Update CLI to send email regardless of number of methods 2025-06-05 15:55:55 -04:00
Addison Beck
299976e55a fix(eslint): extend tsconfig.base in tsconfig.eslint (#15082)
* fix(eslint): extend tsconfig.base in tsconfig.eslint

* fix(eslint): clean up new lint errors
2025-06-05 11:08:03 -04:00
Nick Krantz
729d5d3134 [PM-21546] Migrate from enum to constant object (#14975)
* add generic `union-of-values` helper

* migrate `GeneratorDialogAction` to a constant

* migrate `VaultState` to a constant

* migrate `AtRiskCarouselDialogResult` to a constant

* migrate `CredentialGeneratorDialogAction` to a constant

* migrate `FolderAddEditDialogResult` to a constant

* migrate `ViewCipherDialogResult` to a constant

* migrate `VisibleVaultBanner` to a constant

* migrate `VaultFilterLabel` to a constant

* migrate `WebVaultGeneratorDialogResult` to a constant

* migrate `BulkDeleteDialogResult` to a constant

* migrate `BulkMoveDialogResult` to a constant

* migrate `AddEditCipherDialogResult` to a constant

* migrate `VaultItemDialogResult` to a constant

* migrate `BrowserPromptState` to a constant

* migrate `NudgeType` to a constant

* migrate `SecurityTaskStatus` to a constant

* migrate `CipherRepromptType` to a constant

* migrate `SecureNoteType` to a constant

* migrate `FieldType` to a constant

* migrate `LinkedIdType` to a constant

* migrate `CollectionAssignmentResult` to a constant

* migrate `AddEditFolderDialogResult` to a constant

* migrate `AttachmentDialogResult` to a constant

* fix CipherType in delete organization dialog

* fix `in` statement in VaultFilter

* Fix build errors across enum updates

* fix two more CipherType castings

* update CipherResponse `CipherType`

* define type for `fieldType` parameter

* refine how `cipherTypeNames` is generated and add utility function for grabbing cipher type name

* use `CipherType` rather than `number`

* add stricter typing for `FieldType`

* add fixme for `CipherType` to be ADR-0025 compliant

* remove error throw for `toCipherTypeName` and instead update typing to have `| undefined`

* add helpers for CipherType conversions

* prefer `undefined`
2025-06-05 08:45:52 -05:00
Alec Rippberger
7f72396cb2 chore(tailwind): [PM-20610] migrate webauthn mobile.html
* Update Bootstrap styles to Tailwind

* Ensure tailwind styles bundled
2025-06-05 09:39:40 -04:00
Jordan Aasen
7386a4fa9e [PM-19306] - [Vault] In Admin Console Policies area add the remove card item type policy (#15065)
* WIP - add restricted item types policy

* admin console restricted item types

* add comment

* update feature flag

* fix comment
2025-06-04 15:51:43 -07:00
Vijay Oommen
032fedf308 [PM-21040] Update Ciphers after editing in Reports (#14590) 2025-06-04 09:04:33 -05:00
Daniel Riera
d249d682fe PM-21736 <message> (#14902) 2025-06-04 09:43:38 -04:00
Oscar Hinton
8f74eaea1c Remove standalone true from auth (#15035)
Remove standalone: true from every instance since it's the default as of Angular 19.
2025-06-04 09:22:37 -04:00
Nick Krantz
65f4ff6909 [PM-21791] Nudge UI Bug Fixes (#15010)
* remove margin bottom from empty vault nudge

* update page title to vault options

* show badge on import of vault settings

* add margin between no items title and icon

* add mock to test

* add comment for destroying vault settings page

* fix logic for manage/create collection

* account for deleted ciphers when showing the import nudge

* refactor name of vault import nudge
2025-06-04 08:07:44 -05:00
Jordan Aasen
dcd6f7ada8 [PM-19826] - browser - clear history after creating new cipher (#14894)
* browser - clear history after creating new cipher

* fix tests
2025-06-03 15:04:46 -07:00
Bernd Schoolmann
9aaeacf2be [PM-22194] Remove key rotation v1 (#14945) 2025-06-03 23:52:53 +02:00
Jordan Aasen
6ea944393b [PM-21904] - open claimed-accounts in new tab (#14981)
* open claimed-accounts in new tab

* add noopener to anchor
2025-06-03 14:23:59 -07:00
Jonathan Prusik
6dabdd73cb replace Autofill-owned enums (#15031) 2025-06-03 16:38:51 -04:00
Maciej Zieniuk
ce3ce17010 [PM-21147] User key transferred over ipc within desktop app without its prototype (#15047)
* user key transferred over ipc within desktop app without its prototype.

`UserKey` object was transferred over IPC as regular `Object` type and not recreated as `SymmetricCryptoKey` type, losing its original functions and properties. As a result `inner` method did not exist and user key silently failed during decryption of encrypted client key halves during biometric unlock.

* ipc biometrics serializable user key type

* use encrypt service directly for decryption

* moving electron key service to KM

* log error when unlock via biometrics fails with exception in lock component

* bring back tech debt comment

* lock component logging prefix
2025-06-03 22:12:11 +02:00
SmithThe4th
2e66addd6a [PM-19632] Remove security task flag - step 1 (#14904)
* Step 1- remove business logic

* removed dependency

* removed leftover flags
2025-06-03 12:20:29 -04:00
Nick Krantz
24ae013f71 [PM-22269] Generator/Send Nudge Updates (#15049)
* remove margin from the bottom of paragraph tag in generator spotlight

* update aria-label text to match translation key

* Remove `SendNudgeStatus` nudge type

* update web send page to use new title and description

* update old no sends title and description

* hide internal contents on generator nudge

* remove NudgeService from send-v2 test
2025-06-03 14:04:29 +00:00
Oscar Hinton
deb9ba6e31 Fix ng select and product switcher (#15046)
* Fix ng select and product switcher

* Fix story

* Fix tests
2025-06-03 09:42:08 -04:00