bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 13:23:34 +00:00
Code Issues Releases Wiki Activity
19,457 Commits 1,211 Branches 568 Tags
24e159250be5c7b61e0876cf5d990f212c429bc5
Commit Graph

5493 Commits

Author SHA1 Message Date
neuronull
c2fbd3eb7e More robust error handling for desktop autotype windows implementation (#16501) 
* Desktop autotype windows error handling

* create a subdir

* extract window handle to separate file

* remove println in case tracing doesn't make it in

* touchups

* reduce scope of unsafe call

* use tracing

* Fix comparison on GetLastError result

* Remove the WindowHandle wrapper and save it for the unit testing PR

* restore apps/browser/src/platform/system-notifications/browser-system-notification.service.ts

* use the human readable message for GetLastError debug

* don't call GetLastError outside of error path

* add some more debug statements

* feedback coltonhorst: nits, fix false positive when len zero, re-add handle validation

* lint

* feedback coltonhurst: add comments and update var names
 2025-09-30 22:22:30 +00:00
Holly
0bd098dd8f [PM-19907] updated empty state messages for web (#16283) 
* updated empty state icons and copy for web vault
 2025-09-30 14:55:07 -04:00
Vijay Oommen
6499ecb6ee PM-26329 bug fixes to the cards (#16665) 2025-09-30 11:55:27 -05:00
Brandon Treston
f793c2da09 remove feature flag (#16640) 2025-09-30 11:33:39 -04:00
Maciej Zieniuk
d4f68e8bad [PM-25473] Non-encryption passkeys prevent key rotation (#16514) 
* consistent webauthn filtering as in server by prfStatus, better docs

* test coverage
 2025-09-30 17:29:58 +02:00
Nick Krantz
727689d827 [PM-24534] Archive via CLI (#16502) 
* refactor `canInteract` into a component level usage.

- The default service is going to be used in the CLI which won't make use of the UI-related aspects

* all nested entities to be imported from the vault

* initial add of archive command to the cli

* add archive to oss serve

* check for deleted cipher when attempting to archive

* add searchability/list functionality for archived ciphers

* restore an archived cipher

* unarchive a cipher when a user is editing it and has lost their premium status

* add missing feature flags

* re-export only needed services from the vault

* add needed await

* add prompt when applicable for editing an archived cipher

* move cipher archive service into `common/vault`

* fix testing code
 2025-09-30 10:45:04 -04:00
Daniel James Smith
7848b7d480 Revert "[deps] Tools: Update jsdom to v27 (#16634)" (#16666) 
This reverts commit c93586a0aa.
 2025-09-30 14:40:00 +00:00
renovate[bot]
c93586a0aa [deps] Tools: Update jsdom to v27 (#16634) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
 2025-09-30 15:56:29 +02:00
Maciej Zieniuk
25020ced5d [PM-23251] Remove low-kdf banner (#16511) 
* Remove low-kdf banner

* update tests
 2025-09-30 08:37:00 -05:00
neuronull
54a53a1c34 Use tracing in ssh_agent (#16455) 
* [BEEEP][PM-255518] Use tracing for improved observability

* feedback dani-garcia: use DefaultVisitor

* set default log level

* convert printlns in objc crate

* convert printlns in autotype crate

* convert printlns in autostart crate

* convert printlns in core/password crate

* convert printlns in core/biometric crate

* convert printlns in napi crate

* convert log usage in macos provider crate

* convert existing log macros to tracing

* fix the cargo.toml sort lint errors

* Revert "fix the cargo.toml sort lint errors"

This reverts commit fd149ab697.

* fix the sort lint using correct cargo sort version

* feedback coltonhurst: more comments/clarity on behavior

* revert changes to ssh_agent

* Use tracing in ssh_agent
 2025-09-30 06:33:32 -06:00
Maciej Zieniuk
cae01c6e0f Fix flood of Angular warning messages on policies page (#16618) 
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
 2025-09-30 11:52:04 +10:00
rr-bw
5f7e1f99bf chore(flag-removal): [Auth/PM20439] Remove flagging logic and flag (BrowserExtensionLoginApproval) (#16568) 2025-09-29 13:29:56 -07:00
Vijay Oommen
0bfc5daa7c [PM-26074] All Activities tab - Updated UI (#16587) 
* PM-26074 simplified and update the all-activities tab

* PM-26074 removed learn more

* PM-26074 fixing missing line
 2025-09-29 20:19:14 +00:00
Jeffrey Holland
f9056b2711 [PM-22458] Ensure TOTP check ignores email or username fields (#16535) 
* [PM-22458] Ensure TOTP check ignores email or username fields

* Resolve underlying totp error for shein.com Germany

* Remove a guard check and add an optional chain
 2025-09-29 17:09:41 +02:00
Colton Hurst
fc53eae4c5 [PM-22758] Configurable Keyboard Shortcut for Autotype (#16613) 
* [PM-22785] Initial push with configuration and ipc changes for the configurable autotype keyboard shortcut

* [PM-22785] Add messy code with working configurable hotkey

* [PM-22785] Add more messy rust code

* [PM-22785] Add temp changes with configurable hotkey ui

* Add shortcut display to settings

* [PM-22785] Logic updates. Ran npm run prettier and lint:fix.

* [PM-22785] Add back disableAutotype with refactors.

* [PM-22785] Clean up Rust code

* [PM-22785] Clean up Rust code v2

* [PM-22785] Add unicode bounds in Rust code

* [PM-22785] Update rust code comments

* [PM-22785] Add unicode_value byte length check post-encoding

* [PM-22785] Extract encoding to a separate function

* Various fixes for the autotype setting label

* Misc component fixes

* Disallow nunmbers and allow Win key

* Themify edit shortcut

* Change display of Super to Win

* Create autotype format method

* Autotpe modal cleanup

* [PM-22785] Some cleanup

* Add unit tests and adjust error handling

* [PM-22785] Fix build issues on Mac and Linux

* [PM-22785] Linting fix

* Remove unused message

* [PM-22785] Linting fix

* [PM-22785] More linting fix

* [PM-22785] Address initial PR comments

* [PM-22785] Comment change

* [PM-22785] If statement change

* [PM-22785] Update with fixes from PR comments

* [PM-22785] Update with fixes from PR comments version ?

* add unit tests for get_alphabetic_hot_key()

* Fix tests

* Add missing mock to tests

* [PM-22785] Update with small fixes via PR comments

---------

Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
Co-authored-by: neuronull <9162534+neuronull@users.noreply.github.com>
 2025-09-29 14:20:15 +00:00
Vijay Oommen
90fb57817a [PM-25931] Integrations - can save only if owner (#16570) 2025-09-29 08:27:21 -05:00
renovate[bot]
adbf80dd39 [deps] Platform: Update Rust crate security-framework to v3.5.0 (#16628) 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
 2025-09-29 11:31:31 +02:00
bw-ghapp[bot]
c1d749a0cf Autosync the updated translations (#16639) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-29 10:53:46 +02:00
bw-ghapp[bot]
b888274bd0 Autosync the updated translations (#16638) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-29 08:53:27 +00:00
bw-ghapp[bot]
99d7097378 Autosync the updated translations (#16637) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-29 08:53:04 +00:00
Colton Hurst
7baf250288 [PM-26192] Integrate the new Autotype Default Policy (#16604) 
* Add current WIP autotype policy integration work

* [PM-26192] Add working code that fully integrates the autotype default policy

* [PM-26192] Add comments

* Update apps/desktop/src/autofill/services/desktop-autotype.service.ts

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
 2025-09-26 15:31:31 +00:00
renovate[bot]
e5c5bf63ca [deps] Platform: Update @types/chrome to v0.1.0 (#15697) 
* [deps] Platform: Update @types/chrome to v0.1.0

* Fix typing

* Fix other build errors

* Fix strict compile

* Update pkg and fix remaining type errors

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
 2025-09-26 17:02:39 +02:00
bw-ghapp[bot]
f1a5d7af5e Autosync the updated translations (#16607) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-26 12:57:49 +02:00
bw-ghapp[bot]
82b75b72af Autosync the updated translations (#16606) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-26 12:07:56 +02:00
bw-ghapp[bot]
610bc5b7c2 Autosync the updated translations (#16608) 
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
 2025-09-26 12:05:10 +02:00
Jeffrey Holland
fd98dda0a5 Autofill form that has the focus (#16499) 2025-09-26 11:17:41 +02:00
Jeffrey Holland
4a9183adc5 Allow autofilling iframes like samsclub.com (#16560) 
* Allow autofilling iframes like samsclub.com

* Add back original checks

* Remove unused mock
 2025-09-26 10:21:28 +02:00
Daniel Riera
2f34c6b9c6 [PM-26053] Create Autotype Desktop Default Setting Policy for use within the desktop autotype service (#16537) 
* add policy type enum

* desktop autotype service which emits an observable

* add desktop autotype default setting policy to the app constructor

* update service module to include DesktopAutotypeDefaultSettingPolicy

* flag the service

* add tests

* address comments, switch to null remove false, update tests
 2025-09-25 18:09:53 -04:00
Daniel Riera
b56c9e6c9a [PM-26078] Create admin UI for Autotype Desktop Default Setting Policy (#16573) 
* PM-26078 add component and copy

* add enum

* register oss policy

* export policy definition

* update naming to match policy
 2025-09-25 16:57:31 -04:00
Jordan Aasen
bed5ea17b7 check for undefined parent and node (#16584) 2025-09-25 13:45:33 -07:00
Vicki League
e3a5111a35 [CL-849] Update and consolidate logo svgs (#16390) 2025-09-25 14:52:55 -04:00
Nick Krantz
3b2a2e3129 refactor dialogRef to be optional as the service can be used from the context of a dialog and without it (#16581) 2025-09-25 12:45:02 -05:00
Jordan Aasen
24f07dc1e1 fix css on app-root (#16588) 2025-09-25 09:15:02 -07:00
Mick Letofsky
c96a66b53f [PM-21815] Implement component form the component library & Tailwind CSS (#16491) 2025-09-25 17:23:05 +02:00
adudek-bw
f66413e653 Upgrade rusqlite to 0.37.0 (#16530) 2025-09-25 16:54:57 +02:00
Oscar Hinton
87119f9758 Remove allow(clippy::question_mark) (#16565) 
Remove the allow(clippy::question_mark) exception by reworking the code to use ?.
 2025-09-25 13:31:22 +02:00
Shane Melton
dcbe4f9e09 [PM-26055] Vault item dialog header fix (#16553) 
* [PM-26055] Fix dialog title mode mapping logic

* [PM-26055] Add unit tests
 2025-09-23 16:40:52 -07:00
Bernd Schoolmann
4b73198ce5 [PM-23230] Implement KDF Change Service (#15748) 
* Add new mp service api

* Fix tests

* Add test coverage

* Add newline

* Fix type

* Rename to "unwrapUserKeyFromMasterPasswordUnlockData"

* Fix build

* Fix build on cli

* Fix linting

* Re-sort spec

* Add tests

* Fix test and build issues

* Fix build

* Clean up

* Remove introduced function

* Clean up comments

* Fix abstract class types

* Fix comments

* Cleanup

* Cleanup

* Update libs/common/src/key-management/master-password/types/master-password.types.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/services/master-password.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/types/master-password.types.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add comments

* Fix build

* Add arg null check

* Cleanup

* Fix build

* Fix build on browser

* Implement KDF change service

* Deprecate encryptUserKeyWithMasterKey

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add tests for null params

* Fix builds

* Cleanup and deprecate more functions

* Fix formatting

* Prettier

* Clean up

* Update libs/key-management/src/abstractions/key.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Make emailToSalt private and expose abstract saltForUser

* Add tests

* Add docs

* Fix build

* Fix tests

* Fix tests

* Address feedback and fix primitive obsession

* Consolidate active account checks in change kdf confirmation component

* Update libs/common/src/key-management/kdf/services/change-kdf-service.spec.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add defensive parameter checks

* Add tests

* Add comment for follow-up epic

* Move change kdf service, remove abstraction and add api service

* Fix test

* Drop redundant null check

* Address feedback

* Add throw on empty password

* Fix tests

* Mark change kdf service as internal

* Add abstract classes

* Switch to abstraction

* use sdk EncString in MasterPasswordUnlockData

* fix remaining tests

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
Co-authored-by: Jake Fink <jfink@bitwarden.com>
 2025-09-23 16:10:54 -04:00
Jordan Aasen
d76a60cd1d [PM-26017] - Admin Console: Truncate long collection names in collection row (#16508) 
* truncate long collection names in collection row

* remove unnecessary css class
 2025-09-23 12:50:23 -07:00
Bryan Cunningham
9d82fc7dfc [CL-95] loading spinner (#16363) 
* add spiner from previous branch

* add loading spinner to button

* Add spinner to dialog

* Add spinner to icon button

* add spinner to multi select component

* fix spinner positioning

* Add mock i18n in stories where needed

* round stroke caps. Update classes

* fix ts error

* fix broken tests

* add missing translation keys to stories

* Add mising key for layout

* Add mising key for nav group

* Add mising key for spotlight

* Add mising key for product switcher

* Add mising key for dialog service

* add translation to copy click story
 2025-09-23 15:36:18 -04:00
Jordan Aasen
b12fc338cd fix logic for filtering filters (#16509) 2025-09-23 09:34:20 -07:00
Jordan Aasen
6024f6eef2 [PM-25879][PM-25881] - [Defect] Premium badges missing reusable component (#16461) 
* clean up premium badge component

* add provider to desktop settings

* rename prop.

* add provider to send component

* fix storybook

* fix test

* move dependency to new send dropdown component

* Revert "move dependency to new send dropdown component"

This reverts commit f134526279.

* remove hasPremium
 2025-09-23 09:32:45 -07:00
Jordan Aasen
7313a5f2a3 [PM-825] - Desktop not minimizing on right click password when first opened (#16464) 
* minimize item when copying regardless of action

* remove unused import
 2025-09-23 08:57:33 -07:00
Nick Krantz
82e44e0c09 move extension videos internally to the codebase (#16371) 2025-09-23 10:56:29 -05:00
Jordan Aasen
f642fbc4e6 [PM-24633] - group collections by org in individual vault filters (#16480) 
* group collections by org in individual vault filters

* update vault filter

* use OrganizationId

* fix tests
 2025-09-23 08:50:10 -07:00
rr-bw
d24524b33c refactor(device-management): Auth/[PM-19823] Cleanup DeviceManagementOldComponent (#16541) 2025-09-23 08:47:39 -07:00
Maciej Zieniuk
e0c900cb77 User's Fingerprint Phrase does not match when confirming user (#16552) 2025-09-23 16:52:43 +02:00
Jeffrey Holland
e18f3cf8c9 [PM-22417] Enable autofill overlay for siteone.com (#16457) 
* [PM-22417] Enable autofill overlay for siteone.com

* Fix broken test

* Remove the magic number
 2025-09-23 15:38:53 +02:00
Colton Hurst
3ca1395472 Separate Autotype Setting Observable (#16521) 
* Update the default autotype user setting to be separately represented

* rxjs update

* settings.component.spec.ts update
 2025-09-22 19:08:11 -04:00
Kyle Denney
c796e9514e [PM-25029] new pricing service (#16473) 
* [PM-25029] first draft of pricing service

* [PM-25029] pricing service, getting closer

* [PM-25029] pricing service and tests finished

* removing unused translation

* pr feedback

* new test names to reflect change away from monthly calculation
 2025-09-22 15:01:46 -05:00