Brandon Treston
27089fbb57
[PM-24227] Enable TS-strict for Collection Domain models ( #15765 )
...
* wip ts-strict
* wip ts-strict
* wip
* cleanup
* cleanup
* fix story
* fix story
* fix story
* wip
* clean up CollectionAdminView construction
* fix deprecated function call
* fix cli
* clean up
* fix story
* wip
* fix cli
* requested changes
* clean up, fixing minor bugs, more type saftey
* assign props in static ctor, clean up
2025-08-14 13:08:24 -04:00
Thomas Rittson
61cd0c4f51
[PM-23920] Admin Console - adopt strongly typed guids ( #15814 )
...
Update organization, collection and policy to use strongly typed IDs
2025-08-06 15:27:52 +10:00
Brandon Treston
d0d1359ff4
[PM-12048] Wire up vNextCollectionService ( #14871 )
...
* remove derived state, add cache in service. Fix ts strict errors
* cleanup
* promote vNextCollectionService
* wip
* replace callers in web WIP
* refactor tests for web
* update callers to use vNextCollectionServcie methods in CLI
* WIP make decryptMany public again, fix callers, imports
* wip cli
* wip desktop
* update callers in browser, fix tests
* remove in service cache
* cleanup
* fix test
* clean up
* address cr feedback
* remove duplicate userId
* clean up
* remove unused import
* fix vault-settings-import-nudge.service
* fix caching issue
* clean up
* refactor decryption, cleanup, update callers
* clean up
* Use in-memory statedefinition
* Ac/pm 12048 v next collection service pairing (#15239 )
* Draft from pairing with Gibson
* Add todos
* Add comment
* wip
* refactor upsert
---------
Co-authored-by: Brandon <btreston@bitwarden.com >
* clean up
* fix state definitions
* fix linter error
* cleanup
* add test, fix shareReplay
* fix item-more-options component
* fix desktop build
* refactor state to account for null as an initial value, remove caching
* add proper cache, add unit test, update callers
* clean up
* fix routing when deleting collections
* cleanup
* use combineLatest
* fix ts-strict errors, fix error handling
* refactor Collection and CollectionView properties for ts-strict
* Revert "refactor Collection and CollectionView properties for ts-strict"
This reverts commit a5c63aab76trittson@bitwarden.com >
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com >
2025-07-23 19:05:15 -04:00
Brandon Treston
92bbe0a3c2
[PM-22100] Enforce restrictions based on collection type ( #15336 )
...
* enforce restrictions based on collection type, set default collection type
* fix ts strict errors
* fix default collection enforcement in vault header
* enforce default collection restrictions in vault collection row
* enforce default collection restrictions in AC vault header
* enforce default collection restriction for select all
* fix ts strict error
* switch to signal, fix feature flag
* fix story
* clean up
* remove feature flag, move check for defaultCollecion to CollecitonView
* fix test
* remove unused configService
* fix test: coerce null to undefined for collection Id
* clean up leaky abstraction for default collection
* fix ts-strict error
* fix parens
* rename defaultCollection getter
* clean up
2025-07-18 10:53:12 -04:00
Bernd Schoolmann
60855c734f
[PM-17666] Move Encstring to KM ownership ( #15457 )
...
* Move Encstring to KM ownership
* Fix wrong import
* Fix build
* Fix remaining imports
* Fix tests
2025-07-16 11:15:24 -04:00
Brandon Treston
50cee3cd9a
[PM-22099] expose default collection in clients collection service ( #15122 )
...
* Add types
* rename types
* fix types
* fix model and tests
2025-06-11 11:39:47 -04:00
Maciej Zieniuk
5cd47ac907
[PM-18243] Improve type safety in decryption ( #12885 )
...
* Improve decrypt failure logging
* Rename decryptcontext to decrypttrace
* Improve docs
* PM-16984: Improving type safety of decryption
* Improving type safety of decryption
---------
Co-authored-by: Bernd Schoolmann <mail@quexten.com >
2025-03-11 14:06:44 +01:00
Matt Gibson
9c1e2ebd67
Typescript-strict-plugin ( #12235 )
...
* Use typescript-strict-plugin to iteratively turn on strict
* Add strict testing to pipeline
Can be executed locally through either `npm run test:types` for full type checking including spec files, or `npx tsc-strict` for only tsconfig.json included files.
* turn on strict for scripts directory
* Use plugin for all tsconfigs in monorepo
vscode is capable of executing tsc with plugins, but uses the most relevant tsconfig to do so. If the plugin is not a part of that config, it is skipped and developers get no feedback of strict compile time issues. These updates remedy that at the cost of slightly more complex removal of the plugin when the time comes.
* remove plugin from configs that extend one that already has it
* Update workspace settings to honor strict plugin
* Apply strict-plugin to native message test runner
* Update vscode workspace to use root tsc version
* `./node_modules/.bin/update-strict-comments` 🤖
This is a one-time operation. All future files should adhere to strict type checking.
* Add fixme to `ts-strict-ignore` comments
* `update-strict-comments` 🤖
repeated for new merge files
2024-12-09 20:58:50 +01:00
Addison Beck
073ee4739b
Split Organization.LimitCollectionCreationDeletion into two separate business rules ( #11223 )
...
* Declare feature flag
* Introduce new model properties
* Reference feature toggle in template
* Fix bugs caught during manual testing
2024-10-17 06:34:34 -04:00
Thomas Rittson
7c72795d1c
[PM-12747] Move CollectionService and models to AC Team ( #11278 )
2024-10-08 10:14:39 -04:00
Thomas Rittson
363acf58f9
[PM-12740] Move CollectionAdminService to AC Team ( #11269 )
2024-10-01 18:07:13 -04:00
