1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-09 13:10:17 +00:00
Commit Graph

206 Commits

Author SHA1 Message Date
✨ Audrey ✨
2ed2dd46b7 Merge branch 'main' into tools/pm-18793/port-credential-generator-service-to-providers 2025-04-01 16:36:44 -04:00
✨ Audrey ✨
93ff55c433 fix unit tests 2025-03-31 18:21:39 -04:00
Daniel James Smith
7992e0247e Fix wrong file extension being set when exporting with attachments (#14067)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-31 15:06:27 +00:00
Daniel James Smith
0311681803 Fix filename not including "_encrypted_" when selecting encrypted vault exports (#14066)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-31 16:55:04 +02:00
Daniel James Smith
49924512b8 [PM-19656] Fix zip option not being set correctly after navigating to Admin Console (#14058)
* Simplify if to reduce nesting

* Start subscribing to changes of the vaultSelector as soon as possible during ngOnInit

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-31 15:55:20 +02:00
Daniel James Smith
7ed2145393 Set correct filename extensions on vault-export (#14018)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-28 16:20:36 +01:00
Vicki League
4734cab9a6 [CL-550] Fix popup layout padding and adjust views with extra bottom space (#13562)
* [CL-550] Fix popup layout padding and adjust views with extra bottom space

* simplify css

* fix add/edit item page

* cr changes

* fix failing test

---------

Co-authored-by: Will Martin <contact@willmartian.com>
2025-03-26 17:26:05 -04:00
✨ Audrey ✨
c5e9340964 replace credential generator & eliminate dead code; breaks tests 2025-03-26 17:16:55 -04:00
Addison Beck
2b9ef7fe19 fix: use newly-minted policy methods in metadata provider (#13993)
Recently the policy service was refactored and some method signatures were
changed. One of these changes involved renaming the `getAll` observable to
`policiesByType`.

This was not merged into the metadata provider work before it was merged, so
those changes were committed using removed method signatures.

This commit updates these references.
2025-03-25 23:11:26 +00:00
✨ Audrey ✨
15b2b46b85 [PM-18665] introduce metadata provider (#13744) 2025-03-25 16:08:30 -05:00
Brandon Treston
0fd01ed7ee [PM-18566] Wire up vNextPolicyService for Clients (#13678)
* wire up vNext impl

* wire up vNextPolicyService for browser

* wire up vNextPolicyService for desktop

* wire up vNextPolicyService for cli

* fix test

* fix missed caller

* cleanup

* fix missing property assignment

* fix QA bug for PM-19205

* fix QA bug for PM-19206

* fix QA bug for pm-19228

* cleanup
2025-03-25 11:30:47 -04:00
Bernd Schoolmann
27baa92fcf [PM-10749] [BEEEP] New export format: Zip with attachments (#10465)
* Add new export format: zip

* Restrict zip export to just individual vaults

* Add tests

* Remove unused import

* Fix build error

* Fix tests

* Fix test

* Fix retrieval of ciphers by passing in activeUserId

* Guard feature behind `export-attachments`-feature-flag

* Extend cipher filter to also filter out any ciphers that are assigned to an organization

* Added apiService to retrieve AttachmentData (metaData) and then download the attachment

- Added ApiService as a depdency within DI for VaultExportService/IndividualVaultExportService
- Added unit tests for filtering ciphers
- Added unit test for downloading attachment metadata and attachments

* Moved attachment decryption into a separate method and added unit tests

* Added null check for creating the base attachment folder

* Move format check for zip within Org export into an early return/throw

* Add feature flag guard on the CLI

* Extend ExportScopeCallout to display an individual export will contain attachment when zip-format is selected

* Fix adding/removing the zip-export option based on selected vault and state of `export-attachments` feature-flag

* Separate AAA visually using whitespace within tests

* Remove unused error var

* Write test that verifies different http request failures when retrieving attachment data

* Remove uneeded ignore lint rule

* Rewrite test to actually check that ciphers assigned to an org are filtered out

* Introduce ExportedVault return type (#13842)

* Define ExportedVault type unioned by 2 new types that describe a plain-text export vs a blob-based zip-export

* Extend static getFileName to handle formats and add unit-tests

* Introduce new export return type throughout the vault export module

- Update abstractions
- Update return types within implementations
- Update callers/consumers to handle the new return value
- Fix all unit tests

* Add support for new export return type and fix download of blobs via CLI

* Add documentation to public methods

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>

---------

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-25 13:30:54 +01:00
✨ Audrey ✨
87cd180b29 fix typecheck 2025-03-24 11:32:07 -04:00
✨ Audrey ✨
071aec2556 fix broken tests 2025-03-24 11:28:05 -04:00
✨ Audrey ✨
e56b54e0f7 factor metadata request types out of metadata provider 2025-03-24 11:13:44 -04:00
✨ Audrey ✨
ddfd163b92 fix incorrect documentation 2025-03-24 11:06:07 -04:00
✨ Audrey ✨
22f56da9c3 adjust constructor type argument 2025-03-24 10:53:16 -04:00
✨ Audrey ✨
4ee0832a6d Merge branch 'main' into tools/pm-18665/introduce-metadata-provider 2025-03-24 10:44:02 -04:00
Vijay Oommen
8ed8c9af6a [PM-18685] Disable MyVault when the Person Ownership policy is true (#13930) 2025-03-24 08:33:17 -05:00
✨ Audrey ✨
518bf9ef2a Merge branch 'main' into tools/pm-18665/introduce-metadata-provider 2025-03-12 10:20:29 -04:00
Daniel James Smith
f7440c1cf2 Ensure the SendType is always set when building a SendFormConfig (#13786)
Includes a fallback to SendType.Text when non other path worked.

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-11 10:28:50 -04:00
✨ Audrey ✨
090c19fa5e prettier 2025-03-07 18:25:31 -05:00
✨ Audrey ✨
2248340956 Merge branch 'main' into tools/pm-18665/introduce-metadata-provider 2025-03-07 18:23:59 -05:00
✨ Audrey ✨
4455278704 additional tests; fix disabled semantic logger panic behavior 2025-03-07 17:36:26 -05:00
✨ Audrey ✨
f12966fe7b additional unit tests; fixes 2025-03-07 17:18:12 -05:00
✨ Audrey ✨
dcf15b496b [PM-17590] fix chrome translation bug by escaping $ (#13103)
replaces translation with hard-coded text for cross-platform compatibility
2025-03-06 20:13:04 +00:00
Jason Ng
f65daf7284 [PM-12045] search service activeuserstate (#13035)
* removing activeuserstate from search service
2025-03-06 12:26:24 -05:00
✨ Audrey ✨
fabc7037f2 Merge branch 'main' into tools/pm-18665/introduce-metadata-provider 2025-03-06 11:35:20 -05:00
✨ Audrey ✨
9761588a2a [PM-16790] introduce extension service (#13590) 2025-03-06 11:32:42 -05:00
✨ Audrey ✨
0ef36d4ca1 partial unit test implementation 2025-03-06 09:47:59 -05:00
Daniel James Smith
f95ce4e442 [PM-18913] Remove unneeded margin from send search component (#13698)
* Remove unneeded margin

* Made send-search.component ts-strict compliant

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-05 10:04:46 -05:00
Daniel James Smith
2b29bf8c23 Move SendAddEditDialog from web to bitwarden/send-ui (#13679)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-04 13:24:00 -05:00
✨ Audrey ✨
e10b5af9d3 [PM-16791] introduce generator profile provider (#13588) 2025-03-03 12:43:34 -05:00
✨ Audrey ✨
d64589724f fix compile errors; missing metadata tests 2025-03-03 10:06:38 -05:00
✨ Audrey ✨
5c6a6da101 Revert "factor out generator metadata provider"
This reverts commit 3f40d72b5c.
2025-02-28 11:56:39 -05:00
✨ Audrey ✨
86324e5744 add documentation 2025-02-27 12:45:01 -05:00
✨ Audrey ✨
3f40d72b5c factor out generator metadata provider 2025-02-27 12:04:03 -05:00
✨ Audrey ✨
19c51ca31e introduce extension service 2025-02-26 15:26:29 -05:00
Oscar Hinton
cec117459b [PM-18599] Forbid unknown property and element in tests (#13556)
Fail tests when relying on unknownProperties or unknownElements. Existing instances are whitelist and have tickets created and assigned to the relevant teams.
2025-02-25 14:02:19 -08:00
Vicki League
6d1914f43d [CL-485] Add small delay for async action loading state (#12835) 2025-02-25 09:56:01 -05:00
✨ Audrey ✨
b4bfacf6e3 [PM-16792] [PM-16822] Encapsulate encryptor and state provision within UserStateSubject (#13195) 2025-02-21 17:00:51 -06:00
albertboyd5
ca41ecba29 [PM-16171] Simplelogin alias generation only generate random words instead the domain name (#13024)
* Exposes URI property from the cipher form.
* Updates credential generator to accept the URI using a `website` attribute

---------

Co-authored-by:  Audrey  <audrey@audreyality.com>
2025-02-20 11:33:40 -05:00
Oscar Hinton
5d04efad2a [PM-18363] Remove internal dependencies from package.json (#13448)
* Remove internal dependencies from package.json

* Update lockfile

* Change workspace to include nested libs
2025-02-20 15:04:39 +01:00
Daniel James Smith
f798760dc5 [PM-17948] Migrate export from generator legacy to generator core (#13238)
* Migrate export from generator-legacy to generator-core

* Remove unused platformUtilsService

* Wire up password generation within ngOnInit

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-02-18 20:21:42 +01:00
SmithThe4th
a2945203f4 [PM-12047] Remove usage of ActiveUserState from cipher.service (#12814)
* Cipher service web changes

* Updated browser client to pass user id to cipher service observable changes

* Cli changes

* desktop changes

* Fixed test

* Libs changes

* Fixed merge conflicts

* Fixed merge conflicts

* removed duplicate reference fixed conflict

* Fixed test

* Fixed test

* Fixed test

* Fixed desturcturing issue on failed to decrypt ciphers cipher service

* Updated abstraction to use method syntax

* Fixed conflicts

* Fixed test on add edit v2

Passed active userId to delete function

* Used getUserId utility function

* made vault changes

* made suggestion changes

* made suggestion changes

* made suggestion changes

* Replace getUserId function calls with pipe operator syntax for better consistency

* fixed merge conflicts

* revert mistake made of usinf account activity during merge conflict fix

* fixed conflicts

* fixed tests
2025-02-12 08:53:31 -05:00
Vicki League
b9faf2c9c0 [PM-15975] Prevent dialogs from overlapping interactive top menu bars (#13251) 2025-02-06 13:33:07 -05:00
Bernd Schoolmann
2f8a7a95bd [PM-15994] Move encrypt service to km ownership (#13220)
* Move encrypt service to km ownership

* Update imports for encrypt service abstraction and move bulk encrypt service abstraction

* Fix imports

* Fix further imports

* Fix imports

* Fix worker import
2025-02-05 17:39:11 +01:00
✨ Audrey ✨
1fc20b55f2 [PM-15200] add "generated credential" screen reader notification (#12877)
replaces website$ dependency with `GenerateRequest`
2025-01-24 13:44:42 -06:00
Brandon Treston
b23a41ac86 [PM-17465] refactor PolicyService.getAll$ to make userId not optional (#13031)
* refactor PolicyService.getAll$ to make userId not optional

* add fix to browser

* fix test to read from mock singleUserState

* remove nested pipes, cleanup
2025-01-24 09:58:38 -05:00
Brandon Treston
a949f793ed [PM-15506] Implement vNextOrganizationService (#12839)
* [PM-15506] Wire up vNextOrganizationService for libs/common and libs/angular (#12683)

* Wire up vNextOrganizationService in PolicyService

* Wire vNextOrganizationService in SyncService

* wire vNextOrganizationService for EventCollectionService

* wire vNextOrganizationService for KeyConnectorService

* wire up vNextOrganizationService for CipherAuthorizationService

* Wire up vNextOrganizationService in PolicyService

* Wire vNextOrganizationService in SyncService

* wire vNextOrganizationService for EventCollectionService

* wire vNextOrganizationService for KeyConnectorService

* wire up vNextOrganizationService for CipherAuthorizationService

* wire vNextOrganizationService for share.component

* wire vNextOrganizationService for collections.component

* wire vNextOrganizationServcie for add-account-credit-dialog

* wire vNextOrganizationService for vault-filter.service

* fix browser errors for vNextOrganizationService implementation in libs

* fix desktop errors for vNextOrganizationService implementation for libs

* fix linter errors

* fix CLI errors on vNextOrganizationServcie implementations for libs

* [PM-15506] Wire up vNextOrganizationService for web client (#12810)

PR to a feature branch, no need to review until this goes to main.

* implement vNextOrganization service for browser client (#12844)

PR to feature branch, no need for review yet.

* wire vNextOrganizationService for licence and some web router guards

* wire vNextOrganizationService in tests

* remove vNext notation for OrganizationService and related

* Merge branch 'main' into ac/pm-15506-vNextOrganizationService

* fix tsstrict error

* fix test, fix ts strict error
2025-01-22 15:20:25 -05:00