1
0
mirror of https://github.com/bitwarden/browser synced 2026-02-11 05:53:42 +00:00
Commit Graph

3139 Commits

Author SHA1 Message Date
jaasen-livefront
2f1f8fc025 fix failing test 2025-12-02 10:37:13 -08:00
jaasen-livefront
756abc0a99 fix failing test 2025-12-02 10:19:51 -08:00
jaasen-livefront
f4c9c27e84 make id more explicit 2025-12-02 09:18:39 -08:00
jaasen-livefront
a2b825d7e3 pass null for empty folder ids 2025-12-01 16:44:11 -08:00
jaasen-livefront
2088d578b4 fix logic 2025-11-24 17:54:09 -08:00
jaasen-livefront
90fce663a0 remove remaining checks for null folder id 2025-11-24 17:40:04 -08:00
jaasen-livefront
9122a8fd40 fix test 2025-11-22 13:13:40 -08:00
jaasen-livefront
a4fec9e172 fix folder 2025-11-20 22:35:05 -08:00
jaasen-livefront
e09cab210c remove optional param to folder constructor 2025-11-20 21:58:12 -08:00
jaasen-livefront
cfb3218065 initialize id in folder constructor. fix failing tests 2025-11-20 21:56:15 -08:00
jaasen-livefront
ab47d10038 fixes to folder 2025-11-20 16:48:33 -08:00
jaasen-livefront
1d5da940a7 check for empty name in folder toDomain 2025-11-20 10:31:33 -08:00
jaasen-livefront
7a8ec65c54 no need to check for presence 2025-11-20 10:29:08 -08:00
jaasen-livefront
f58439ee10 fix tests 2025-11-20 10:23:46 -08:00
Jordan Aasen
d09853ed9c Merge branch 'main' into PM-25685 2025-11-10 10:02:13 -08:00
Kyle Denney
e3acd27dec [PM-24284] - milestone 3 (#17230)
* first draft

# Conflicts:
#	apps/web/src/app/billing/individual/upgrade/upgrade-payment/services/upgrade-payment.service.ts
#	apps/web/src/app/billing/organizations/organization-plans.component.ts
#	libs/common/src/billing/services/subscription-pricing.service.ts
#	libs/common/src/enums/feature-flag.enum.ts

* more filtering for pricing cards

* prettier

* tests

* tests v2
2025-11-10 11:50:49 -06:00
Bryan Cunningham
c8281a079b skip tooltip stories in chromatic (#17315) 2025-11-10 12:49:14 -05:00
Patrick-Pimentel-Bitwarden
5aa6d38d80 feat(prelogin): [Auth/PM-23801] Move Prelogin Request (#17080)
* feat(prelogin): [PM-23801] Move Prelogin Request - Initial implementation.

* test(prelogin): [PM-23801] Move Prelogin Request - Removed unneeded test.
2025-11-10 10:54:25 -05:00
Kyle Denney
f7899991a0 [PM-23713] always append query param to premium redirect (#17240) 2025-11-10 09:51:51 -06:00
Rui Tomé
cb863b44d5 [PM-26430] Remove Type property from PolicyRequestModel to use route parameter only (#16960)
* Remove Type property from PolicyRequestModel to use route parameter only

* Remove PolicyType property from policy update request in auto-confirm edit policy dialog

* Run prettier
2025-11-10 15:27:48 +00:00
jaasen-livefront
c2b7e7f29f more defensive typing 2025-11-07 21:45:16 -08:00
jaasen-livefront
6577b5f081 fix tests 2025-11-07 21:42:34 -08:00
jaasen-livefront
ac18055999 fix tests 2025-11-07 21:38:35 -08:00
jaasen-livefront
c878c77cd4 fix folder with id export 2025-11-07 14:53:21 -08:00
jaasen-livefront
705e2329f8 Update folder and folderview 2025-11-07 14:30:55 -08:00
jaasen-livefront
093b99e579 fix tests 2025-11-07 13:21:48 -08:00
Brandon Treston
19626d1b3e [PM-26363] Add one time setup dialog for auto confirm (#17104)
* add one time setup dialog for auto confirm

* add one time setup dialog for auto confirm

* fix copy, padding, cleanup observable logic

* cleanup

* cleanup

* refactor

* clean up

* more cleanup

* Fix deleted files

This reverts commit 7c18a5e512.
2025-11-07 15:58:39 -05:00
jaasen-livefront
939ec1b448 name name and id optional in folder model 2025-11-07 12:26:32 -08:00
Bernd Schoolmann
4f9ae78598 [PM-27515] Fix 2fa settings not working after KDF change (#17070)
* Always derive authentication data fresh for UV

* Cleanup

* Add tests

* Fix remote UV

* Fix test

* Fix test

* Address feedback

* Fix build

* Update libs/common/src/auth/types/verification.ts

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Remove unused var

* Fix relative import

* Fix types

---------

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
2025-11-07 18:36:02 +01:00
SmithThe4th
519889f8f4 Persist ssh key changes when extension loses focus (#17267) 2025-11-07 10:54:04 -05:00
John Harrington
5e094c6066 PM-27883-Defect-Windows-Edge-browser-importer-is-not-enabled (#17260)
* remove edge from unsupported browser list

* Clarify comment for CSV import handling

Updated comment to clarify supported browsers for CSV imports.
2025-11-07 13:43:10 +01:00
Daniel James Smith
3c2f44095a [PM-27656] Show error message when detecting Chromium v3 encryption, which isn't supported yet (#17156)
* Replace any-returns with types

* Show an error message when a failure from the native call is returned

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2025-11-06 20:53:13 +01:00
Maximilian Power
e9a25d4e8c [PM-27722] Deprecate risk insights terminology and rename to access intelligence (#17170)
* Deprecate risk insights terminology and rename to access intelligence
2025-11-06 18:53:32 +00:00
Maciej Zieniuk
ff12e672e6 [PM-23614] Remove activeUserOrgKeys$ from the key service (#17045)
* Remove activeUserOrgKeys$ from the key service

* test leftover

* test leftover
2025-11-06 19:27:13 +01:00
Vicki League
c404ee210b [PM-26984] Use medium instead of semibold or bold (#17191) 2025-11-06 11:27:46 -05:00
Bryan Cunningham
f865139d16 [CL-881] restore nav tree view (#17210)
* restore tree nav view

* address Claude feedback

* address feedback and fix depth calculation

* address feedback from Claude

* do not reserve space for icon
2025-11-06 11:10:17 -05:00
Vicki League
7cbfcd23a8 [PM-26984] Use medium instead of semibold or bold (#17194) 2025-11-06 09:09:17 -06:00
Nick Krantz
30af9425d8 prevent form status changes from triggering a valueChanges emission (#17181)
- previous data within the cipher can be overwritten by the initial form data
2025-11-06 08:28:05 -06:00
Shane Melton
60b16a796c [PM-27848] Undo OnPush change detection strategy change for CipherViewComponent (#17235) 2025-11-05 11:02:56 -08:00
Bryan Cunningham
74889ec754 remove spacing from checkboxes. Add media query for smaller screens (#17233) 2025-11-05 13:32:41 -05:00
Bryan Cunningham
6e97927db6 Uif/export switch (#17234)
* fix private variables used in template

* remove module

* fix test import
2025-11-05 13:28:28 -05:00
Bernd Schoolmann
3125f679d3 [PM-25206] Inject service instead of passing as param (#16801)
* Inject service instead of passing as param

* [PM-25206] Move locking logic to LockService (#16802)

* Move locking logic to lock service

* Fix tests

* Fix CLI

* Fix test

* FIx safari build

* Update call to lock service

* Remove locked callback

* Clean up lock service logic

* Add tests

* Fix cli build

* Add extension lock service

* Fix cli build

* Fix build

* Undo ac changes

* Undo ac changes

* Run prettier

* Fix build

* Remove duplicate call

* [PM-25206] Remove VaultTimeoutService lock logic (#16804)

* Move consumers off of vaulttimeoutsettingsservice lock

* Fix build

* Fix build

* Fix build

* Fix firefox build

* Fix test

* Fix ts strict errors

* Fix ts strict error

* Undo AC changes

* Cleanup

* Fix

* Fix missing service
2025-11-05 17:11:34 +01:00
Bryan Cunningham
993637c41e use regular gap instead of column gap to fix spacing (#17228) 2025-11-05 11:05:13 -05:00
John Harrington
8e8092c828 [PM-27648] [Defect] The .zip option is displayed on organizational export in Admin Console (#17140)
* consider admin console context when determining export types and callout

* checkpoint on simplified fix before swapping to signals

* Update libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Update libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

---------

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2025-11-04 22:34:22 +01:00
SmithThe4th
c42a7b2ef5 [PM-27506] CLI allows creating SSH key items with null fields (#17063)
* Added checks to on the sshkey view to prevent null fields

* Give default values to the template

* Give default values to the template

* change function signature to match ts-strct styles

* Added unit tests for the ssh key to view and replaced deafults to empty strings
2025-11-04 15:51:17 -05:00
Bryan Cunningham
203267f53c [CL-890] fix flakey tests (#17160)
* remove animations to try and fix flakey tests

* allow some diff in tootltip story

* dedicated collapsed nav story

* remove viewports and add delay

* add back animations

* add input to disable responsive behavior

* remove responsive input. open nav on lg viewports

* create story to capture collapsed nav

* remove unused import

* more explicit user preference logic
2025-11-04 15:35:23 -05:00
Vicki League
9bd7b58f6b [PM-26984] Use medium instead of semibold or bold (#17188) 2025-11-04 15:27:13 -05:00
Shane Melton
7e5f02f90c [PM-24469] Implement Risk Insights for Premium in Cipher view component (#17012)
* [PM-24469] Refactor CipherViewComponent to use Angular signals and computed properties for improved reactivity

* [PM-24469] Refactor CipherViewComponent to utilize Angular signals for organization data retrieval

* [PM-24469] Refactor CipherViewComponent to utilize Angular signals for folder data retrieval

* [PM-24469] Cleanup organization signal

* [PM-24469] Refactor CipherViewComponent to replace signal for card expiration with computed property

* [PM-24469] Improve collections loading in CipherViewComponent

* [PM-24469] Remove redundant loadCipherData method

* [PM-24469] Refactor CipherViewComponent to replace signal with computed property for pending change password tasks

* [PM-24469] Refactor LoginCredentialsViewComponent to rename hadPendingChangePasswordTask to showChangePasswordLink for clarity

* [PM-24469] Introduce showChangePasswordLink computed property for improved readability

* [PM-24469] Initial RI for premium logic

* [PM-24469] Refactor checkPassword risk checking logic

* [PM-24469] Cleanup premium check

* [PM-24469] Cleanup UI visuals

* [PM-24469] Fix missing typography import

* [PM-24469] Cleanup docs

* [PM-24469] Add feature flag

* [PM-24469] Ensure password risk check is only performed when the feature is enabled, and the cipher is editable by the user, and it has a password

* [PM-24469] Refactor password risk evaluation logic and add unit tests for risk assessment

* [PM-24469] Fix mismatched CipherId type

* [PM-24469] Fix test dependencies

* [PM-24469] Fix config service mock in emergency view dialog spec

* [PM-24469] Wait for decrypted vault before calculating cipher risk

* [PM-24469] startWith(false) for passwordIsAtRisk signal to avoid showing stale values when cipher changes

* [PM-24469] Exclude organization owned ciphers from JIT risk analysis

* [PM-24469] Add initial cipher-view component test boilerplate

* [PM-24469] Add passwordIsAtRisk signal tests

* [PM-24469] Ignore soft deleted items for RI for premium feature

* [PM-24469] Fix tests
2025-11-04 12:15:53 -08:00
Jordan Aasen
d364dfdda0 [PM-26182] - [Defect] [Browser] Safari - Autofill on page load default setting is missing yes or no (#16605)
* handle parenthesis translation

* add whitespace around placeholder with parentheses

* fix test

* fix label

* fix spec
2025-11-04 10:59:00 -08:00
rr-bw
409dbc4c44 fix(sso-login): [PM-27674] (Auth) Make 'enter' press start sso process if ssoRequired (#17186)
If user's email is NOT in the ssoRequiredCache, pressing "enter" takes them to the MP login screen. If the user's email is in the ssoRequiredCache, pressing "enter" starts the SSO login process.

Feature Flags enabled: pm-22110-disable-alternate-login-methods
2025-11-04 10:41:00 -08:00